From 6d33cbd4b512dedede99521ae838bfa5ead8c604 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Sat, 13 Feb 2021 00:37:58 +0100 Subject: [PATCH] Fold yang-model-util-ut Now that yang-model-util can depend on yang-parser-rfc7950 for testing, there is no point in keeping a separate test artifact. Move all files from yang-model-util-ut into yang-model-util. JIRA: YANGTOOLS-1052 Change-Id: Iac40aee178af24abbb2115ccf302e3550fbfee8c Signed-off-by: Robert Varga --- yang/pom.xml | 1 - yang/yang-model-util-ut/pom.xml | 46 ------------------- .../yang/model/util/ut/package-info.java | 13 ------ yang/yang-model-util/pom.xml | 4 ++ .../util}/LeafrefStaticAnalysisTest.java | 2 +- .../SchemaContextUtilIntegrationTest.java} | 6 +-- .../yang/model/util}/YT1050Test.java | 2 +- .../yang/model/util}/YT1060Test.java | 2 +- .../yang/model/util}/YT1100Test.java | 2 +- .../yang/model/util}/YT1231Test.java | 2 +- .../yangtools/yang/model/util}/YT588Test.java | 2 +- .../yangtools/yang/model/util}/YT691Test.java | 2 +- .../src/test/resources/leafrefs.yang | 0 .../schema-context-util/imported-module.yang | 0 .../schema-context-util/my-module.yang | 0 .../src/test/resources/yt1050.yang | 0 .../src/test/resources/yt1060/child.yang | 0 .../src/test/resources/yt1060/imported.yang | 0 .../src/test/resources/yt1060/parent.yang | 0 .../src/test/resources/yt1100.yang | 0 .../src/test/resources/yt1231.yang | 0 .../src/test/resources/yt588.yang | 0 .../src/test/resources/yt691/bar-sub1.yang | 0 .../src/test/resources/yt691/bar.yang | 0 .../src/test/resources/yt691/baz.yang | 0 .../src/test/resources/yt691/foo-sub1.yang | 0 .../src/test/resources/yt691/foo-sub2.yang | 0 .../src/test/resources/yt691/foo.yang | 0 yang/yang-parser-impl/pom.xml | 6 +-- 29 files changed, 16 insertions(+), 74 deletions(-) delete mode 100644 yang/yang-model-util-ut/pom.xml delete mode 100644 yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/package-info.java rename yang/{yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut => yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util}/LeafrefStaticAnalysisTest.java (99%) rename yang/{yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/SchemaContextUtilTest.java => yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/SchemaContextUtilIntegrationTest.java} (99%) rename yang/{yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut => yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util}/YT1050Test.java (97%) rename yang/{yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut => yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util}/YT1060Test.java (98%) rename yang/{yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut => yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util}/YT1100Test.java (97%) rename yang/{yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut => yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util}/YT1231Test.java (98%) rename yang/{yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut => yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util}/YT588Test.java (97%) rename yang/{yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut => yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util}/YT691Test.java (97%) rename yang/{yang-model-util-ut => yang-model-util}/src/test/resources/leafrefs.yang (100%) rename yang/{yang-model-util-ut => yang-model-util}/src/test/resources/schema-context-util/imported-module.yang (100%) rename yang/{yang-model-util-ut => yang-model-util}/src/test/resources/schema-context-util/my-module.yang (100%) rename yang/{yang-model-util-ut => yang-model-util}/src/test/resources/yt1050.yang (100%) rename yang/{yang-model-util-ut => yang-model-util}/src/test/resources/yt1060/child.yang (100%) rename yang/{yang-model-util-ut => yang-model-util}/src/test/resources/yt1060/imported.yang (100%) rename yang/{yang-model-util-ut => yang-model-util}/src/test/resources/yt1060/parent.yang (100%) rename yang/{yang-model-util-ut => yang-model-util}/src/test/resources/yt1100.yang (100%) rename yang/{yang-model-util-ut => yang-model-util}/src/test/resources/yt1231.yang (100%) rename yang/{yang-model-util-ut => yang-model-util}/src/test/resources/yt588.yang (100%) rename yang/{yang-model-util-ut => yang-model-util}/src/test/resources/yt691/bar-sub1.yang (100%) rename yang/{yang-model-util-ut => yang-model-util}/src/test/resources/yt691/bar.yang (100%) rename yang/{yang-model-util-ut => yang-model-util}/src/test/resources/yt691/baz.yang (100%) rename yang/{yang-model-util-ut => yang-model-util}/src/test/resources/yt691/foo-sub1.yang (100%) rename yang/{yang-model-util-ut => yang-model-util}/src/test/resources/yt691/foo-sub2.yang (100%) rename yang/{yang-model-util-ut => yang-model-util}/src/test/resources/yt691/foo.yang (100%) diff --git a/yang/pom.xml b/yang/pom.xml index 742e488e26..e7c0fadf0c 100644 --- a/yang/pom.xml +++ b/yang/pom.xml @@ -36,7 +36,6 @@ yang-model-spi yang-model-export yang-model-util - yang-model-util-ut yang-xpath-api diff --git a/yang/yang-model-util-ut/pom.xml b/yang/yang-model-util-ut/pom.xml deleted file mode 100644 index 427ffd84a2..0000000000 --- a/yang/yang-model-util-ut/pom.xml +++ /dev/null @@ -1,46 +0,0 @@ - - - - - 4.0.0 - - org.opendaylight.yangtools - bundle-parent - 7.0.0-SNAPSHOT - ../../bundle-parent - - - - yang-model-util-ut - jar - ${project.artifactId} - ${project.artifactId} - - - true - true - - - - - org.opendaylight.yangtools - yang-model-util - - - - org.opendaylight.yangtools - yang-test-util - - - org.opendaylight.yangtools - mockito-configuration - test - - - diff --git a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/package-info.java b/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/package-info.java deleted file mode 100644 index 0a672793de..0000000000 --- a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/package-info.java +++ /dev/null @@ -1,13 +0,0 @@ -/* - * Copyright (c) 2019 PANTHEON.tech, s.r.o. and others. All rights reserved. - * - * This program and the accompanying materials are made available under the - * terms of the Eclipse Public License v1.0 which accompanies this distribution, - * and is available at http://www.eclipse.org/legal/epl-v10.html - */ -/** - * Additional unit test suite for {@code yang-model-util}, which are using YANG parser to construct the testing data - * and thus cannot live directly in that artifact. - */ -// FIXME: YANTTOOLS-1052: this should be eliminated -package org.opendaylight.yangtools.yang.model.util.ut; \ No newline at end of file diff --git a/yang/yang-model-util/pom.xml b/yang/yang-model-util/pom.xml index b3372a11d1..4d8f65c61d 100644 --- a/yang/yang-model-util/pom.xml +++ b/yang/yang-model-util/pom.xml @@ -36,6 +36,10 @@ mockito-configuration test + + org.opendaylight.yangtools + yang-test-util + ch.qos.logback logback-classic diff --git a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/LeafrefStaticAnalysisTest.java b/yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/LeafrefStaticAnalysisTest.java similarity index 99% rename from yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/LeafrefStaticAnalysisTest.java rename to yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/LeafrefStaticAnalysisTest.java index ee9da81e17..b651a5237a 100644 --- a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/LeafrefStaticAnalysisTest.java +++ b/yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/LeafrefStaticAnalysisTest.java @@ -5,7 +5,7 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ -package org.opendaylight.yangtools.yang.model.util.ut; +package org.opendaylight.yangtools.yang.model.util; import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.isA; diff --git a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/SchemaContextUtilTest.java b/yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/SchemaContextUtilIntegrationTest.java similarity index 99% rename from yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/SchemaContextUtilTest.java rename to yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/SchemaContextUtilIntegrationTest.java index a46c1e75c3..7676fad6f3 100644 --- a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/SchemaContextUtilTest.java +++ b/yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/SchemaContextUtilIntegrationTest.java @@ -5,7 +5,7 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ -package org.opendaylight.yangtools.yang.model.util.ut; +package org.opendaylight.yangtools.yang.model.util; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNotNull; @@ -29,11 +29,9 @@ import org.opendaylight.yangtools.yang.model.api.RpcDefinition; import org.opendaylight.yangtools.yang.model.api.SchemaContext; import org.opendaylight.yangtools.yang.model.api.SchemaNode; import org.opendaylight.yangtools.yang.model.api.SchemaPath; -import org.opendaylight.yangtools.yang.model.util.PathExpressionImpl; -import org.opendaylight.yangtools.yang.model.util.SchemaContextUtil; import org.opendaylight.yangtools.yang.test.util.YangParserTestUtils; -public class SchemaContextUtilTest { +public class SchemaContextUtilIntegrationTest { private static SchemaContext context; private static Module myModule; diff --git a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT1050Test.java b/yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT1050Test.java similarity index 97% rename from yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT1050Test.java rename to yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT1050Test.java index e3c5e304de..cb124aa3e5 100644 --- a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT1050Test.java +++ b/yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT1050Test.java @@ -5,7 +5,7 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ -package org.opendaylight.yangtools.yang.model.util.ut; +package org.opendaylight.yangtools.yang.model.util; import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.isA; diff --git a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT1060Test.java b/yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT1060Test.java similarity index 98% rename from yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT1060Test.java rename to yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT1060Test.java index 8a5755f0ea..693884dc25 100644 --- a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT1060Test.java +++ b/yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT1060Test.java @@ -5,7 +5,7 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ -package org.opendaylight.yangtools.yang.model.util.ut; +package org.opendaylight.yangtools.yang.model.util; import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.isA; diff --git a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT1100Test.java b/yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT1100Test.java similarity index 97% rename from yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT1100Test.java rename to yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT1100Test.java index fe12686e58..9de18c8594 100644 --- a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT1100Test.java +++ b/yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT1100Test.java @@ -5,7 +5,7 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ -package org.opendaylight.yangtools.yang.model.util.ut; +package org.opendaylight.yangtools.yang.model.util; import static org.hamcrest.CoreMatchers.instanceOf; import static org.hamcrest.MatcherAssert.assertThat; diff --git a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT1231Test.java b/yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT1231Test.java similarity index 98% rename from yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT1231Test.java rename to yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT1231Test.java index 49fbd4bedd..f08a5e7602 100644 --- a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT1231Test.java +++ b/yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT1231Test.java @@ -5,7 +5,7 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ -package org.opendaylight.yangtools.yang.model.util.ut; +package org.opendaylight.yangtools.yang.model.util; import static org.hamcrest.CoreMatchers.instanceOf; import static org.hamcrest.MatcherAssert.assertThat; diff --git a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT588Test.java b/yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT588Test.java similarity index 97% rename from yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT588Test.java rename to yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT588Test.java index 65c7b27bad..c75b93ad59 100644 --- a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT588Test.java +++ b/yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT588Test.java @@ -5,7 +5,7 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ -package org.opendaylight.yangtools.yang.model.util.ut; +package org.opendaylight.yangtools.yang.model.util; import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.isA; diff --git a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT691Test.java b/yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT691Test.java similarity index 97% rename from yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT691Test.java rename to yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT691Test.java index 211f10970e..b7afea71d5 100644 --- a/yang/yang-model-util-ut/src/test/java/org/opendaylight/yangtools/yang/model/util/ut/YT691Test.java +++ b/yang/yang-model-util/src/test/java/org/opendaylight/yangtools/yang/model/util/YT691Test.java @@ -5,7 +5,7 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ -package org.opendaylight.yangtools.yang.model.util.ut; +package org.opendaylight.yangtools.yang.model.util; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; diff --git a/yang/yang-model-util-ut/src/test/resources/leafrefs.yang b/yang/yang-model-util/src/test/resources/leafrefs.yang similarity index 100% rename from yang/yang-model-util-ut/src/test/resources/leafrefs.yang rename to yang/yang-model-util/src/test/resources/leafrefs.yang diff --git a/yang/yang-model-util-ut/src/test/resources/schema-context-util/imported-module.yang b/yang/yang-model-util/src/test/resources/schema-context-util/imported-module.yang similarity index 100% rename from yang/yang-model-util-ut/src/test/resources/schema-context-util/imported-module.yang rename to yang/yang-model-util/src/test/resources/schema-context-util/imported-module.yang diff --git a/yang/yang-model-util-ut/src/test/resources/schema-context-util/my-module.yang b/yang/yang-model-util/src/test/resources/schema-context-util/my-module.yang similarity index 100% rename from yang/yang-model-util-ut/src/test/resources/schema-context-util/my-module.yang rename to yang/yang-model-util/src/test/resources/schema-context-util/my-module.yang diff --git a/yang/yang-model-util-ut/src/test/resources/yt1050.yang b/yang/yang-model-util/src/test/resources/yt1050.yang similarity index 100% rename from yang/yang-model-util-ut/src/test/resources/yt1050.yang rename to yang/yang-model-util/src/test/resources/yt1050.yang diff --git a/yang/yang-model-util-ut/src/test/resources/yt1060/child.yang b/yang/yang-model-util/src/test/resources/yt1060/child.yang similarity index 100% rename from yang/yang-model-util-ut/src/test/resources/yt1060/child.yang rename to yang/yang-model-util/src/test/resources/yt1060/child.yang diff --git a/yang/yang-model-util-ut/src/test/resources/yt1060/imported.yang b/yang/yang-model-util/src/test/resources/yt1060/imported.yang similarity index 100% rename from yang/yang-model-util-ut/src/test/resources/yt1060/imported.yang rename to yang/yang-model-util/src/test/resources/yt1060/imported.yang diff --git a/yang/yang-model-util-ut/src/test/resources/yt1060/parent.yang b/yang/yang-model-util/src/test/resources/yt1060/parent.yang similarity index 100% rename from yang/yang-model-util-ut/src/test/resources/yt1060/parent.yang rename to yang/yang-model-util/src/test/resources/yt1060/parent.yang diff --git a/yang/yang-model-util-ut/src/test/resources/yt1100.yang b/yang/yang-model-util/src/test/resources/yt1100.yang similarity index 100% rename from yang/yang-model-util-ut/src/test/resources/yt1100.yang rename to yang/yang-model-util/src/test/resources/yt1100.yang diff --git a/yang/yang-model-util-ut/src/test/resources/yt1231.yang b/yang/yang-model-util/src/test/resources/yt1231.yang similarity index 100% rename from yang/yang-model-util-ut/src/test/resources/yt1231.yang rename to yang/yang-model-util/src/test/resources/yt1231.yang diff --git a/yang/yang-model-util-ut/src/test/resources/yt588.yang b/yang/yang-model-util/src/test/resources/yt588.yang similarity index 100% rename from yang/yang-model-util-ut/src/test/resources/yt588.yang rename to yang/yang-model-util/src/test/resources/yt588.yang diff --git a/yang/yang-model-util-ut/src/test/resources/yt691/bar-sub1.yang b/yang/yang-model-util/src/test/resources/yt691/bar-sub1.yang similarity index 100% rename from yang/yang-model-util-ut/src/test/resources/yt691/bar-sub1.yang rename to yang/yang-model-util/src/test/resources/yt691/bar-sub1.yang diff --git a/yang/yang-model-util-ut/src/test/resources/yt691/bar.yang b/yang/yang-model-util/src/test/resources/yt691/bar.yang similarity index 100% rename from yang/yang-model-util-ut/src/test/resources/yt691/bar.yang rename to yang/yang-model-util/src/test/resources/yt691/bar.yang diff --git a/yang/yang-model-util-ut/src/test/resources/yt691/baz.yang b/yang/yang-model-util/src/test/resources/yt691/baz.yang similarity index 100% rename from yang/yang-model-util-ut/src/test/resources/yt691/baz.yang rename to yang/yang-model-util/src/test/resources/yt691/baz.yang diff --git a/yang/yang-model-util-ut/src/test/resources/yt691/foo-sub1.yang b/yang/yang-model-util/src/test/resources/yt691/foo-sub1.yang similarity index 100% rename from yang/yang-model-util-ut/src/test/resources/yt691/foo-sub1.yang rename to yang/yang-model-util/src/test/resources/yt691/foo-sub1.yang diff --git a/yang/yang-model-util-ut/src/test/resources/yt691/foo-sub2.yang b/yang/yang-model-util/src/test/resources/yt691/foo-sub2.yang similarity index 100% rename from yang/yang-model-util-ut/src/test/resources/yt691/foo-sub2.yang rename to yang/yang-model-util/src/test/resources/yt691/foo-sub2.yang diff --git a/yang/yang-model-util-ut/src/test/resources/yt691/foo.yang b/yang/yang-model-util/src/test/resources/yt691/foo.yang similarity index 100% rename from yang/yang-model-util-ut/src/test/resources/yt691/foo.yang rename to yang/yang-model-util/src/test/resources/yt691/foo.yang diff --git a/yang/yang-parser-impl/pom.xml b/yang/yang-parser-impl/pom.xml index 70139bd359..57f4d5d513 100644 --- a/yang/yang-parser-impl/pom.xml +++ b/yang/yang-parser-impl/pom.xml @@ -36,11 +36,11 @@ org.opendaylight.yangtools - yang-parser-api + yang-model-spi org.opendaylight.yangtools - yang-parser-reactor + yang-parser-api org.opendaylight.yangtools @@ -48,7 +48,7 @@ org.opendaylight.yangtools - yang-model-util + yang-parser-reactor -- 2.36.6