From 01ea06a6bb49d840cc3f2b3362bbdde7a5764fdc Mon Sep 17 00:00:00 2001 From: Steven Pisarski Date: Mon, 18 May 2015 15:30:31 -0600 Subject: [PATCH] Fixing the setting of the DSCP_TOSOverwrite value with the DSCPTOS object to write the value to correct element of the data byte array. The setter that uses the byte value was correct and set index 1 where the other setter was setting the byte value to index 2. Gate COPS data will need additional unit testing and really should be refactored for normalization and semantics. Change-Id: I719f186d661b3749ed7d9f9f3bef20a7323d4910 Signed-off-by: Steven Pisarski --- .../src/main/java/org/pcmm/gates/impl/GateSpec.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packetcable-driver/src/main/java/org/pcmm/gates/impl/GateSpec.java b/packetcable-driver/src/main/java/org/pcmm/gates/impl/GateSpec.java index 9148558..c802d32 100644 --- a/packetcable-driver/src/main/java/org/pcmm/gates/impl/GateSpec.java +++ b/packetcable-driver/src/main/java/org/pcmm/gates/impl/GateSpec.java @@ -90,13 +90,13 @@ public class GateSpec extends PCMMBaseObject implements IGateSpec { @Override public void setDSCP_TOSOverwrite(DSCPTOS dscpTos) { // OR in the DSCPTOS enable flag with the Direction flag - flags |= dscpTos.getValue(); - setByte(flags, (short) 0); + setDSCP_TOSOverwrite(dscpTos.getValue()); } @Override public void setDSCP_TOSOverwrite(byte dscpTos) { - setByte(dscpTos, (short) 1); + flags |= dscpTos; + setByte(flags, (short) 1); } -- 2.36.6