From 03de42f0b69b93597dc2a0d81351c251e5bb4da9 Mon Sep 17 00:00:00 2001 From: Marian Adamjak Date: Mon, 27 Oct 2014 10:57:38 +0100 Subject: [PATCH] BUG 2245 - Fixed Singular Field Change-Id: I9489b5e8c9cb221cf7a29e7e41d4c909204ed9c7 Signed-off-by: Marian Adamjak --- .../openflowjava/protocol/impl/core/UdpHandler.java | 3 +-- .../openflowjava/protocol/impl/clients/SimpleClient.java | 3 +-- .../openflowjava/protocol/impl/clients/UdpSimpleClient.java | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/UdpHandler.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/UdpHandler.java index c0f958d2..8a04efa4 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/UdpHandler.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/UdpHandler.java @@ -37,7 +37,6 @@ public final class UdpHandler implements ServerFacade { private static final Logger LOGGER = LoggerFactory .getLogger(UdpHandler.class); private int port; - private String address; private EventLoopGroup group; private final InetAddress startupAddress; private final SettableFuture isOnlineFuture; @@ -91,7 +90,7 @@ public final class UdpHandler implements ServerFacade { try { InetSocketAddress isa = (InetSocketAddress) f.channel().localAddress(); - this.address = isa.getHostString(); + String address = isa.getHostString(); // Update port, as it may have been specified as 0 this.port = isa.getPort(); diff --git a/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/SimpleClient.java b/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/SimpleClient.java index e31c3674..fee80aa4 100644 --- a/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/SimpleClient.java +++ b/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/SimpleClient.java @@ -36,7 +36,6 @@ public class SimpleClient implements OFClient { private EventLoopGroup group; private SettableFuture isOnlineFuture; private SettableFuture scenarioDone; - private SimpleClientInitializer clientInitializer; private ScenarioHandler scenarioHandler; /** @@ -62,7 +61,7 @@ public class SimpleClient implements OFClient { @Override public void run() { group = new NioEventLoopGroup(); - clientInitializer = new SimpleClientInitializer(isOnlineFuture, securedClient); + SimpleClientInitializer clientInitializer = new SimpleClientInitializer(isOnlineFuture, securedClient); clientInitializer.setScenario(scenarioHandler); try { Bootstrap b = new Bootstrap(); diff --git a/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/UdpSimpleClient.java b/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/UdpSimpleClient.java index 685dbd2a..52dcb425 100644 --- a/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/UdpSimpleClient.java +++ b/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/UdpSimpleClient.java @@ -36,7 +36,6 @@ public class UdpSimpleClient implements OFClient { private EventLoopGroup group; private SettableFuture isOnlineFuture; private SettableFuture scenarioDone; - private UdpSimpleClientInitializer clientInitializer; private ScenarioHandler scenarioHandler; /** @@ -62,7 +61,7 @@ public class UdpSimpleClient implements OFClient { @Override public void run() { group = new NioEventLoopGroup(); - clientInitializer = new UdpSimpleClientInitializer(isOnlineFuture); + UdpSimpleClientInitializer clientInitializer = new UdpSimpleClientInitializer(isOnlineFuture); clientInitializer.setScenario(scenarioHandler); try { Bootstrap b = new Bootstrap(); -- 2.36.6