From 0def27b981bf0c830c6d4fb618e1a74b729e8255 Mon Sep 17 00:00:00 2001 From: Martin Bobak Date: Tue, 19 May 2015 14:03:47 +0200 Subject: [PATCH] Rework of handleServiceCall method Second type parameter of method was removed. Change-Id: I447fae85a8e2142a0c755d67f838f0c7326a1bd9 Signed-off-by: Jozef Gloncak Signed-off-by: Martin Bobak --- .../impl/services/CommonService.java | 11 +------- .../impl/services/SalFlowServiceImpl.java | 2 +- .../impl/services/SalGroupServiceImpl.java | 20 +++++++-------- .../impl/services/SalMeterServiceImpl.java | 20 +++++++-------- .../impl/services/SalPortServiceImpl.java | 10 ++++---- .../impl/services/SalTableServiceImpl.java | 10 ++++---- ...OpendaylightFlowStatisticsServiceImpl.java | 25 +++++++++++-------- ...aylightFlowTableStatisticsServiceImpl.java | 5 ++-- ...pendaylightGroupStatisticsServiceImpl.java | 25 +++++++++++-------- ...pendaylightMeterStatisticsServiceImpl.java | 24 +++++++++--------- ...OpendaylightPortStatisticsServiceImpl.java | 16 ++++++------ ...pendaylightQueueStatisticsServiceImpl.java | 19 +++++++------- .../dedicated/StatisticsGatheringService.java | 10 ++++---- .../impl/util/StatisticsServiceUtil.java | 4 +-- 14 files changed, 100 insertions(+), 101 deletions(-) diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/CommonService.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/CommonService.java index aa28370282..169d06cf8a 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/CommonService.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/CommonService.java @@ -24,7 +24,6 @@ import org.opendaylight.yangtools.yang.common.RpcResultBuilder; import org.slf4j.Logger; public abstract class CommonService { - protected static final RpcResult SUCCESSFUL_RPCRESULT = RpcResultBuilder.success().build(); private static final Logger LOG = org.slf4j.LoggerFactory.getLogger(CommonService.class); private static final long WAIT_TIME = 2000; private static final BigInteger PRIMARY_CONNECTION = BigInteger.ZERO; @@ -97,14 +96,7 @@ public abstract class CommonService { return primaryConnectionAdapter; } - - /** - * @param - * @param - * @param function - * @return - */ - public final ListenableFuture> handleServiceCall(final Function, ListenableFuture>> function) { + public final ListenableFuture> handleServiceCall(final Function, ListenableFuture>> function) { LOG.trace("Handling general service call"); final RequestContext requestContext = createRequestContext(); @@ -118,7 +110,6 @@ public abstract class CommonService { deviceContext.getMessageSpy().spyMessage(requestContext.getClass(), MessageSpy.STATISTIC_GROUP.TO_SWITCH_RESERVATION_REJECTED); return RequestContextUtil.closeRequestContextWithRpcError(requestContext, "Outbound queue wasn't able to reserve XID."); } - final ListenableFuture> resultFromOFLib; messageSpy.spyMessage(requestContext.getClass(), MessageSpy.STATISTIC_GROUP.TO_SWITCH_READY_FOR_SUBMIT); function.apply(requestContext); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalFlowServiceImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalFlowServiceImpl.java index 72ac619220..d5d8605d24 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalFlowServiceImpl.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalFlowServiceImpl.java @@ -103,7 +103,7 @@ public class SalFlowServiceImpl extends CommonService implements SalFlowService @Override public Future> removeFlow(final RemoveFlowInput input) { LOG.trace("Calling remove flow for flow with ID ={}.", input.getFlowRef()); - return this.handleServiceCall(new Function, ListenableFuture>>() { + return handleServiceCall(new Function, ListenableFuture>>() { @Override public ListenableFuture> apply(final RequestContext requestContext) { final FlowModInputBuilder ofFlowModInput = FlowConvertor.toFlowModInput(input, getVersion(), diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalGroupServiceImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalGroupServiceImpl.java index 7460e7a741..d5643d7fb9 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalGroupServiceImpl.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalGroupServiceImpl.java @@ -47,9 +47,9 @@ public class SalGroupServiceImpl extends CommonService implements SalGroupServic @Override public Future> addGroup(final AddGroupInput input) { getDeviceContext().getDeviceGroupRegistry().store(input.getGroupId()); - return this.handleServiceCall(new Function, ListenableFuture>>() { + return handleServiceCall(new Function, ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { return convertAndSend(input, requestContext); } }); @@ -57,10 +57,10 @@ public class SalGroupServiceImpl extends CommonService implements SalGroupServic @Override public Future> updateGroup(final UpdateGroupInput input) { - return this.handleServiceCall(new Function, ListenableFuture>>() { + return handleServiceCall(new Function, ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { return convertAndSend(input.getUpdatedGroup(), requestContext); } }); @@ -69,22 +69,22 @@ public class SalGroupServiceImpl extends CommonService implements SalGroupServic @Override public Future> removeGroup(final RemoveGroupInput input) { getDeviceContext().getDeviceGroupRegistry().markToBeremoved(input.getGroupId()); - return this.handleServiceCall(new Function, ListenableFuture>>() { + return handleServiceCall(new Function, ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { return convertAndSend(input, requestContext); } }); } - ListenableFuture> convertAndSend(final Group iputGroup, final RequestContext requestContext) { + ListenableFuture> convertAndSend(final Group iputGroup, final RequestContext requestContext) { final OutboundQueue outboundQueue = getDeviceContext().getPrimaryConnectionContext().getOutboundQueueProvider(); getMessageSpy().spyMessage(iputGroup.getImplementedInterface(), MessageSpy.STATISTIC_GROUP.TO_SWITCH_SUBMIT_SUCCESS); final GroupModInputBuilder ofGroupModInput = GroupConvertor.toGroupModInput(iputGroup, getVersion(), getDatapathId()); final Xid xid = requestContext.getXid(); ofGroupModInput.setXid(xid.getValue()); - final SettableFuture> settableFuture = SettableFuture.create(); + final SettableFuture> settableFuture = SettableFuture.create(); final GroupModInput groupModInput = ofGroupModInput.build(); outboundQueue.commitEntry(xid.getValue(), groupModInput, new FutureCallback() { @Override @@ -92,12 +92,12 @@ public class SalGroupServiceImpl extends CommonService implements SalGroupServic RequestContextUtil.closeRequstContext(requestContext); getMessageSpy().spyMessage(groupModInput.getImplementedInterface(), MessageSpy.STATISTIC_GROUP.TO_SWITCH_SUBMIT_SUCCESS); - settableFuture.set(RpcResultBuilder.success().build()); + settableFuture.set(RpcResultBuilder.success().build()); } @Override public void onFailure(final Throwable throwable) { - RpcResultBuilder rpcResultBuilder = RpcResultBuilder.failed().withError(RpcError.ErrorType.APPLICATION, throwable.getMessage(), throwable); + RpcResultBuilder rpcResultBuilder = RpcResultBuilder.failed().withError(RpcError.ErrorType.APPLICATION, throwable.getMessage(), throwable); RequestContextUtil.closeRequstContext(requestContext); getMessageSpy().spyMessage(groupModInput.getImplementedInterface(), MessageSpy.STATISTIC_GROUP.TO_SWITCH_SUBMIT_FAILURE); settableFuture.set(rpcResultBuilder.build()); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalMeterServiceImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalMeterServiceImpl.java index 5ddf898f98..f7061b9e4e 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalMeterServiceImpl.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalMeterServiceImpl.java @@ -46,9 +46,9 @@ public class SalMeterServiceImpl extends CommonService implements SalMeterServic @Override public Future> addMeter(final AddMeterInput input) { getDeviceContext().getDeviceMeterRegistry().store(input.getMeterId()); - return this.handleServiceCall(new Function, ListenableFuture>>() { + return handleServiceCall(new Function, ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { return convertAndSend(input, requestContext); } }); @@ -56,9 +56,9 @@ public class SalMeterServiceImpl extends CommonService implements SalMeterServic @Override public Future> updateMeter(final UpdateMeterInput input) { - return this.handleServiceCall(new Function, ListenableFuture>>() { + return handleServiceCall(new Function, ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { return convertAndSend(input.getUpdatedMeter(), requestContext); } }); @@ -67,22 +67,22 @@ public class SalMeterServiceImpl extends CommonService implements SalMeterServic @Override public Future> removeMeter(final RemoveMeterInput input) { getDeviceContext().getDeviceMeterRegistry().markToBeremoved(input.getMeterId()); - return this.handleServiceCall(new Function, ListenableFuture>>() { + return handleServiceCall(new Function, ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { return convertAndSend(input, requestContext); } }); } - ListenableFuture> convertAndSend(final Meter iputMeter, final RequestContext requestContext) { + ListenableFuture> convertAndSend(final Meter iputMeter, final RequestContext requestContext) { getMessageSpy().spyMessage(iputMeter.getImplementedInterface(), MessageSpy.STATISTIC_GROUP.TO_SWITCH_SUBMIT_SUCCESS); final OutboundQueue outboundQueue = getDeviceContext().getPrimaryConnectionContext().getOutboundQueueProvider(); final MeterModInputBuilder ofMeterModInput = MeterConvertor.toMeterModInput(iputMeter, getVersion()); final Xid xid = requestContext.getXid(); ofMeterModInput.setXid(xid.getValue()); - final SettableFuture> settableFuture = SettableFuture.create(); + final SettableFuture> settableFuture = SettableFuture.create(); final MeterModInput meterModInput = ofMeterModInput.build(); outboundQueue.commitEntry(xid.getValue(), meterModInput, new FutureCallback() { @Override @@ -90,12 +90,12 @@ public class SalMeterServiceImpl extends CommonService implements SalMeterServic RequestContextUtil.closeRequstContext(requestContext); getMessageSpy().spyMessage(meterModInput.getImplementedInterface(), MessageSpy.STATISTIC_GROUP.TO_SWITCH_SUBMIT_SUCCESS); - settableFuture.set(RpcResultBuilder.success().build()); + settableFuture.set(RpcResultBuilder.success().build()); } @Override public void onFailure(final Throwable throwable) { - RpcResultBuilder rpcResultBuilder = RpcResultBuilder.failed().withError(RpcError.ErrorType.APPLICATION, throwable.getMessage(), throwable); + RpcResultBuilder rpcResultBuilder = RpcResultBuilder.failed().withError(RpcError.ErrorType.APPLICATION, throwable.getMessage(), throwable); RequestContextUtil.closeRequstContext(requestContext); getMessageSpy().spyMessage(meterModInput.getImplementedInterface(), MessageSpy.STATISTIC_GROUP.TO_SWITCH_SUBMIT_FAILURE); settableFuture.set(rpcResultBuilder.build()); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalPortServiceImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalPortServiceImpl.java index 76639c0e25..9a55cd78d6 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalPortServiceImpl.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalPortServiceImpl.java @@ -40,9 +40,9 @@ public class SalPortServiceImpl extends CommonService implements SalPortService @Override public Future> updatePort(final UpdatePortInput input) { - return this.handleServiceCall(new Function, ListenableFuture>>() { + return handleServiceCall(new Function, ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { getMessageSpy().spyMessage(input.getImplementedInterface(), MessageSpy.STATISTIC_GROUP.TO_SWITCH_SUBMIT_SUCCESS); final Port inputPort = input.getUpdatedPort().getPort().getPort().get(0); @@ -52,7 +52,7 @@ public class SalPortServiceImpl extends CommonService implements SalPortService final OutboundQueue outboundQueue = getDeviceContext().getPrimaryConnectionContext().getOutboundQueueProvider(); mdInput.setXid(xid.getValue()); - final SettableFuture> settableFuture = SettableFuture.create(); + final SettableFuture> settableFuture = SettableFuture.create(); final PortModInput portModInput = mdInput.build(); outboundQueue.commitEntry(xid.getValue(), portModInput, new FutureCallback() { @Override @@ -60,12 +60,12 @@ public class SalPortServiceImpl extends CommonService implements SalPortService RequestContextUtil.closeRequstContext(requestContext); getMessageSpy().spyMessage(portModInput.getImplementedInterface(), MessageSpy.STATISTIC_GROUP.TO_SWITCH_SUBMIT_SUCCESS); - settableFuture.set(RpcResultBuilder.success().build()); + settableFuture.set(RpcResultBuilder.success().build()); } @Override public void onFailure(final Throwable throwable) { - RpcResultBuilder rpcResultBuilder = RpcResultBuilder.failed().withError(RpcError.ErrorType.APPLICATION, throwable.getMessage(), throwable); + RpcResultBuilder rpcResultBuilder = RpcResultBuilder.failed().withError(RpcError.ErrorType.APPLICATION, throwable.getMessage(), throwable); RequestContextUtil.closeRequstContext(requestContext); getMessageSpy().spyMessage(portModInput.getImplementedInterface(), MessageSpy.STATISTIC_GROUP.TO_SWITCH_SUBMIT_FAILURE); settableFuture.set(rpcResultBuilder.build()); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalTableServiceImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalTableServiceImpl.java index 2c321bbf08..d4a9d36c94 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalTableServiceImpl.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/services/SalTableServiceImpl.java @@ -70,10 +70,10 @@ public class SalTableServiceImpl extends CommonService implements SalTableServic @Override public Future> updateTable(final UpdateTableInput input) { class FunctionImpl implements - Function>, ListenableFuture>> { + Function>, ListenableFuture>>> { @Override - public ListenableFuture> apply(final RequestContext> requestContext) { + public ListenableFuture>> apply(final RequestContext> requestContext) { getMessageSpy().spyMessage(input.getImplementedInterface(), MessageSpy.STATISTIC_GROUP.TO_SWITCH_SUBMIT_SUCCESS); @@ -93,7 +93,7 @@ public class SalTableServiceImpl extends CommonService implements SalTableServic mprInput.setMultipartRequestBody(caseBuilder.build()); final OutboundQueue outboundQueue = getDeviceContext().getPrimaryConnectionContext().getOutboundQueueProvider(); - final SettableFuture> settableFuture = SettableFuture.create(); + final SettableFuture>> settableFuture = SettableFuture.create(); final MultiMsgCollector multiMsgCollector = getDeviceContext().getMultiMsgCollector(); multiMsgCollector.registerMultipartRequestContext(requestContext); @@ -112,12 +112,12 @@ public class SalTableServiceImpl extends CommonService implements SalTableServic } } getMessageSpy().spyMessage(multipartRequestInput.getImplementedInterface(), MessageSpy.STATISTIC_GROUP.TO_SWITCH_SUBMIT_SUCCESS); - settableFuture.set(RpcResultBuilder.success().build()); + settableFuture.set(RpcResultBuilder.>success().build()); } @Override public void onFailure(final Throwable throwable) { - RpcResultBuilder rpcResultBuilder = RpcResultBuilder.failed().withError(RpcError.ErrorType.APPLICATION, throwable.getMessage(), throwable); + RpcResultBuilder> rpcResultBuilder = RpcResultBuilder.>failed().withError(RpcError.ErrorType.APPLICATION, throwable.getMessage(), throwable); RequestContextUtil.closeRequstContext(requestContext); multiMsgCollector.registerMultipartRequestContext(requestContext); getMessageSpy().spyMessage(multipartRequestInput.getImplementedInterface(), MessageSpy.STATISTIC_GROUP.TO_SWITCH_SUBMIT_FAILURE); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowStatisticsServiceImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowStatisticsServiceImpl.java index f7aa6b3bf2..832ef48d88 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowStatisticsServiceImpl.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowStatisticsServiceImpl.java @@ -70,11 +70,12 @@ public class OpendaylightFlowStatisticsServiceImpl extends CommonService impleme final GetAggregateFlowStatisticsFromFlowTableForAllFlowsInput input) { - return this.handleServiceCall( - new Function, ListenableFuture>>() { + return handleServiceCall( + new Function, + ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { // Create multipart request body for fetch all the group stats final MultipartRequestAggregateCaseBuilder multipartRequestAggregateCaseBuilder = new MultipartRequestAggregateCaseBuilder(); @@ -108,10 +109,10 @@ public class OpendaylightFlowStatisticsServiceImpl extends CommonService impleme ListenableFuture>> rpcResultListenableFuture = handleServiceCall( - new Function>, ListenableFuture>>() { + new Function>, ListenableFuture>>>() { @Override - public ListenableFuture> apply(final RequestContext> requestContext) { + public ListenableFuture>> apply(final RequestContext> requestContext) { final Xid xid = requestContext.getXid(); final DeviceContext deviceContext = getDeviceContext(); deviceContext.getMultiMsgCollector().registerMultipartRequestContext(requestContext); @@ -204,10 +205,11 @@ public class OpendaylightFlowStatisticsServiceImpl extends CommonService impleme public Future> getAllFlowStatisticsFromFlowTable( final GetAllFlowStatisticsFromFlowTableInput input) { - return this.handleServiceCall(new Function, ListenableFuture>>() { + return handleServiceCall(new Function, + ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { final MultipartRequestFlowBuilder mprFlowRequestBuilder = new MultipartRequestFlowBuilder(); mprFlowRequestBuilder.setTableId(input.getTableId().getValue()); @@ -237,10 +239,11 @@ public class OpendaylightFlowStatisticsServiceImpl extends CommonService impleme final GetAllFlowsStatisticsFromAllFlowTablesInput input) { - return this.handleServiceCall(new Function, ListenableFuture>>() { + return handleServiceCall(new Function, + ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { final MultipartRequestFlowCaseBuilder multipartRequestFlowCaseBuilder = new MultipartRequestFlowCaseBuilder(); final MultipartRequestFlowBuilder mprFlowRequestBuilder = new MultipartRequestFlowBuilder(); @@ -268,10 +271,10 @@ public class OpendaylightFlowStatisticsServiceImpl extends CommonService impleme final GetFlowStatisticsFromFlowTableInput input) { - return this.handleServiceCall(new Function, ListenableFuture>>() { + return handleServiceCall(new Function, ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { final MultipartRequestFlowCaseBuilder multipartRequestFlowCaseBuilder = new MultipartRequestFlowCaseBuilder(); final MultipartRequestFlowBuilder mprFlowRequestBuilder = new MultipartRequestFlowBuilder(); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowTableStatisticsServiceImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowTableStatisticsServiceImpl.java index 410c44f034..ad16b6ac90 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowTableStatisticsServiceImpl.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightFlowTableStatisticsServiceImpl.java @@ -41,10 +41,11 @@ public class OpendaylightFlowTableStatisticsServiceImpl extends CommonService im final GetFlowTablesStatisticsInput input) { - return this.handleServiceCall(new Function, ListenableFuture>>() { + return handleServiceCall(new Function, + ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { // Create multipart request body for fetch all the group stats final MultipartRequestTableCaseBuilder multipartRequestTableCaseBuilder = new MultipartRequestTableCaseBuilder(); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightGroupStatisticsServiceImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightGroupStatisticsServiceImpl.java index 9062b46b41..7f627e47bd 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightGroupStatisticsServiceImpl.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightGroupStatisticsServiceImpl.java @@ -51,10 +51,11 @@ public class OpendaylightGroupStatisticsServiceImpl extends CommonService implem public Future> getAllGroupStatistics(final GetAllGroupStatisticsInput input) { - return this.handleServiceCall(new Function, ListenableFuture>>() { + return handleServiceCall(new Function, + ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { final MultipartRequestGroupCaseBuilder caseBuilder = new MultipartRequestGroupCaseBuilder(); final MultipartRequestGroupBuilder mprGroupBuild = new MultipartRequestGroupBuilder(); @@ -85,11 +86,12 @@ public class OpendaylightGroupStatisticsServiceImpl extends CommonService implem @Override public Future> getGroupDescription(final GetGroupDescriptionInput input) { - return this.handleServiceCall( - new Function, ListenableFuture>>() { + return handleServiceCall( + new Function, + ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { final MultipartRequestGroupDescCaseBuilder mprGroupDescCaseBuild = new MultipartRequestGroupDescCaseBuilder(); final Xid xid = requestContext.getXid(); @@ -105,11 +107,12 @@ public class OpendaylightGroupStatisticsServiceImpl extends CommonService implem @Override public Future> getGroupFeatures(final GetGroupFeaturesInput input) { - return this.handleServiceCall( - new Function, ListenableFuture>>() { + return handleServiceCall( + new Function, + ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { final MultipartRequestGroupFeaturesCaseBuilder mprGroupFeaturesBuild = new MultipartRequestGroupFeaturesCaseBuilder(); final Xid xid = requestContext.getXid(); @@ -125,11 +128,11 @@ public class OpendaylightGroupStatisticsServiceImpl extends CommonService implem @Override public Future> getGroupStatistics(final GetGroupStatisticsInput input) { - return this.handleServiceCall( - new Function, ListenableFuture>>() { + return handleServiceCall( + new Function, ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { final MultipartRequestGroupCaseBuilder caseBuilder = new MultipartRequestGroupCaseBuilder(); final MultipartRequestGroupBuilder mprGroupBuild = new MultipartRequestGroupBuilder(); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightMeterStatisticsServiceImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightMeterStatisticsServiceImpl.java index 38b983f13f..4c1c4d0ced 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightMeterStatisticsServiceImpl.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightMeterStatisticsServiceImpl.java @@ -51,11 +51,11 @@ public class OpendaylightMeterStatisticsServiceImpl extends CommonService implem @Override public Future> getAllMeterConfigStatistics( final GetAllMeterConfigStatisticsInput input) { - return this - .handleServiceCall(new Function, ListenableFuture>>() { + return handleServiceCall(new Function, + ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { MultipartRequestMeterConfigCaseBuilder caseBuilder = new MultipartRequestMeterConfigCaseBuilder(); @@ -80,10 +80,10 @@ public class OpendaylightMeterStatisticsServiceImpl extends CommonService implem @Override public Future> getAllMeterStatistics(final GetAllMeterStatisticsInput input) { - return this.handleServiceCall( - new Function, ListenableFuture>>() { + return handleServiceCall( + new Function, ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { MultipartRequestMeterCaseBuilder caseBuilder = new MultipartRequestMeterCaseBuilder(); @@ -108,10 +108,10 @@ public class OpendaylightMeterStatisticsServiceImpl extends CommonService implem @Override public Future> getMeterFeatures(final GetMeterFeaturesInput input) { - return this.handleServiceCall( - new Function, ListenableFuture>>() { + return handleServiceCall( + new Function, ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { MultipartRequestMeterFeaturesCaseBuilder mprMeterFeaturesBuild = new MultipartRequestMeterFeaturesCaseBuilder(); @@ -128,10 +128,10 @@ public class OpendaylightMeterStatisticsServiceImpl extends CommonService implem @Override public Future> getMeterStatistics(final GetMeterStatisticsInput input) { - return this.handleServiceCall( - new Function, ListenableFuture>>() { + return handleServiceCall( + new Function, ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { MultipartRequestMeterCaseBuilder caseBuilder = new MultipartRequestMeterCaseBuilder(); MultipartRequestMeterBuilder mprMeterBuild = diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightPortStatisticsServiceImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightPortStatisticsServiceImpl.java index b04f5ff79e..fed18d7f6d 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightPortStatisticsServiceImpl.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightPortStatisticsServiceImpl.java @@ -44,12 +44,12 @@ public class OpendaylightPortStatisticsServiceImpl extends CommonService impleme @Override public Future> getAllNodeConnectorsStatistics( final GetAllNodeConnectorsStatisticsInput input) { - return this - .handleServiceCall( - new Function, ListenableFuture>>() { + return handleServiceCall( + new Function, + ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { MultipartRequestPortStatsCaseBuilder caseBuilder = new MultipartRequestPortStatsCaseBuilder(); @@ -72,12 +72,12 @@ public class OpendaylightPortStatisticsServiceImpl extends CommonService impleme @Override public Future> getNodeConnectorStatistics( final GetNodeConnectorStatisticsInput input) { - return this - .handleServiceCall( - new Function, ListenableFuture>>() { + return handleServiceCall( + new Function, + ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { MultipartRequestPortStatsCaseBuilder caseBuilder = new MultipartRequestPortStatsCaseBuilder(); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightQueueStatisticsServiceImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightQueueStatisticsServiceImpl.java index ae405f3145..702c2dd290 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightQueueStatisticsServiceImpl.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/OpendaylightQueueStatisticsServiceImpl.java @@ -46,11 +46,12 @@ public class OpendaylightQueueStatisticsServiceImpl extends CommonService implem @Override public Future> getAllQueuesStatisticsFromAllPorts( final GetAllQueuesStatisticsFromAllPortsInput input) { - return this.handleServiceCall( - new Function, ListenableFuture>>() { + return handleServiceCall( + new Function, + ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { MultipartRequestQueueCaseBuilder caseBuilder = new MultipartRequestQueueCaseBuilder(); @@ -78,11 +79,11 @@ public class OpendaylightQueueStatisticsServiceImpl extends CommonService implem @Override public Future> getAllQueuesStatisticsFromGivenPort( final GetAllQueuesStatisticsFromGivenPortInput input) { - return this.handleServiceCall( - new Function, ListenableFuture>>() { + return handleServiceCall( + new Function, ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { MultipartRequestQueueCaseBuilder caseBuilder = new MultipartRequestQueueCaseBuilder(); MultipartRequestQueueBuilder mprQueueBuilder = new MultipartRequestQueueBuilder(); @@ -109,11 +110,11 @@ public class OpendaylightQueueStatisticsServiceImpl extends CommonService implem @Override public Future> getQueueStatisticsFromGivenPort( final GetQueueStatisticsFromGivenPortInput input) { - return this.handleServiceCall( - new Function, ListenableFuture>>() { + return handleServiceCall( + new Function, ListenableFuture>>() { @Override - public ListenableFuture> apply(final RequestContext requestContext) { + public ListenableFuture> apply(final RequestContext requestContext) { MultipartRequestQueueCaseBuilder caseBuilder = new MultipartRequestQueueCaseBuilder(); MultipartRequestQueueBuilder mprQueueBuilder = new MultipartRequestQueueBuilder(); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/dedicated/StatisticsGatheringService.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/dedicated/StatisticsGatheringService.java index 20d68431ae..6ae6d9ff43 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/dedicated/StatisticsGatheringService.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/services/dedicated/StatisticsGatheringService.java @@ -47,9 +47,9 @@ public class StatisticsGatheringService extends CommonService { public Future>> getStatisticsOfType(final MultipartType type) { - return handleServiceCall(new Function>, ListenableFuture>>() { + return handleServiceCall(new Function>, ListenableFuture>>>() { @Override - public ListenableFuture> apply(final RequestContext> requestContext) { + public ListenableFuture>> apply(final RequestContext> requestContext) { final Xid xid = requestContext.getXid(); final DeviceContext deviceContext = getDeviceContext(); final MultiMsgCollector multiMsgCollector = deviceContext.getMultiMsgCollector(); @@ -60,13 +60,13 @@ public class StatisticsGatheringService extends CommonService { getVersion(), type); final OutboundQueue outboundQueue = deviceContext.getPrimaryConnectionContext().getOutboundQueueProvider(); - final SettableFuture> settableFuture = SettableFuture.create(); + final SettableFuture>> settableFuture = SettableFuture.create(); outboundQueue.commitEntry(xid.getValue(), multipartRequestInput, new FutureCallback() { @Override public void onSuccess(final OfHeader ofHeader) { if (ofHeader instanceof MultipartReply) { final MultipartReply multipartReply = (MultipartReply) ofHeader; - settableFuture.set(RpcResultBuilder.success().build()); + settableFuture.set(RpcResultBuilder.>success().build()); multiMsgCollector.addMultipartMsg(multipartReply); } else { if (null != ofHeader) { @@ -79,7 +79,7 @@ public class StatisticsGatheringService extends CommonService { @Override public void onFailure(final Throwable throwable) { - RpcResultBuilder rpcResultBuilder = RpcResultBuilder.failed().withError(RpcError.ErrorType.APPLICATION, throwable.getMessage()); + RpcResultBuilder> rpcResultBuilder = RpcResultBuilder.>failed().withError(RpcError.ErrorType.APPLICATION, throwable.getMessage()); RequestContextUtil.closeRequstContext(requestContext); settableFuture.set(rpcResultBuilder.build()); diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/util/StatisticsServiceUtil.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/util/StatisticsServiceUtil.java index 6cac89d7f9..59b48f4d73 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/util/StatisticsServiceUtil.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/util/StatisticsServiceUtil.java @@ -27,10 +27,10 @@ public class StatisticsServiceUtil { throw new IllegalStateException("This class should not be instantiated"); } - public static ListenableFuture> getRpcResultListenableFuture(final Xid xid, + public static ListenableFuture> getRpcResultListenableFuture(final Xid xid, final MultipartRequestInput multipartRequestInput, final DeviceContext deviceContext) { - final SettableFuture> settableFuture = SettableFuture.create(); + final SettableFuture> settableFuture = SettableFuture.create(); final OutboundQueue outboundQueue = deviceContext.getPrimaryConnectionContext().getOutboundQueueProvider(); outboundQueue.commitEntry(xid.getValue(), multipartRequestInput, new FutureCallback() { @Override -- 2.36.6