From 0f25685b9cfa3757fa74b546221a1ad0d0ab4d7e Mon Sep 17 00:00:00 2001
From: Robert Varga <robert.varga@pantheon.tech>
Date: Wed, 9 May 2018 11:07:31 +0200
Subject: [PATCH] Fix code smells in AlwaysFailOperation

Concentrate IllegalStateException into a utility method.

Change-Id: I45fe9e20cc6c6facfdc4f468cd27d5a2f05719f2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---
 .../impl/schema/tree/AlwaysFailOperation.java | 24 +++++++++++--------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/tree/AlwaysFailOperation.java b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/tree/AlwaysFailOperation.java
index 8463c836e8..9c662e5779 100644
--- a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/tree/AlwaysFailOperation.java
+++ b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/tree/AlwaysFailOperation.java
@@ -28,39 +28,43 @@ final class AlwaysFailOperation extends ModificationApplyOperation {
     }
 
     @Override
-    Optional<TreeNode> apply(final ModifiedNode modification,
-            final Optional<TreeNode> storeMeta, final Version version) {
-        throw new IllegalStateException("Schema Context is not available.");
+    Optional<TreeNode> apply(final ModifiedNode modification, final Optional<TreeNode> storeMeta,
+            final Version version) {
+        throw ise();
     }
 
     @Override
     void checkApplicable(final YangInstanceIdentifier path, final NodeModification modification,
             final Optional<TreeNode> storeMetadata, final Version version) {
-        throw new IllegalStateException("Schema Context is not available.");
+        throw ise();
     }
 
     @Override
     public Optional<ModificationApplyOperation> getChild(final PathArgument child) {
-        throw new IllegalStateException("Schema Context is not available.");
+        throw ise();
     }
 
     @Override
     void verifyStructure(final NormalizedNode<?, ?> modification, final boolean verifyChildren) {
-        throw new IllegalStateException("Schema Context is not available.");
+        throw ise();
     }
 
     @Override
     ChildTrackingPolicy getChildPolicy() {
-        throw new IllegalStateException("Schema Context is not available.");
+        throw ise();
     }
 
     @Override
     void mergeIntoModifiedNode(final ModifiedNode node, final NormalizedNode<?, ?> value, final Version version) {
-        throw new IllegalStateException("Schema Context is not available.");
+        throw ise();
     }
 
     @Override
     void recursivelyVerifyStructure(final NormalizedNode<?, ?> value) {
-        throw new IllegalStateException("Schema Context is not available.");
+        throw ise();
     }
-}
\ No newline at end of file
+
+    private static IllegalStateException ise() {
+        return new IllegalStateException("Schema Context is not available.");
+    }
+}
-- 
2.36.6