From 1205cf477f9c61c4b6b57d5ca6ca96438cc3d9be Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Tue, 17 Jan 2023 21:38:10 +0100 Subject: [PATCH] Add FIXMEs to Rpc{Input,Output} DataObject has implications which cover the possibility of being an interior node of a structured data. RpcInput and RpcOutput are explicitly excluded from that contract, similarly as BaseNotification is. Add FIXMEs to reconcile this modeling problem. Change-Id: I84b6f5ca90cbfb685209559863f29634c5744772 Signed-off-by: Robert Varga --- .../org/opendaylight/yangtools/yang/binding/RpcInput.java | 1 + .../org/opendaylight/yangtools/yang/binding/RpcOutput.java | 6 +----- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/binding/yang-binding/src/main/java/org/opendaylight/yangtools/yang/binding/RpcInput.java b/binding/yang-binding/src/main/java/org/opendaylight/yangtools/yang/binding/RpcInput.java index 4f04b27fb8..d17d0ac787 100644 --- a/binding/yang-binding/src/main/java/org/opendaylight/yangtools/yang/binding/RpcInput.java +++ b/binding/yang-binding/src/main/java/org/opendaylight/yangtools/yang/binding/RpcInput.java @@ -11,6 +11,7 @@ package org.opendaylight.yangtools.yang.binding; * Marker interface for all interfaces generated for {@code input} statement within an {@code action} or an {@code rpc} * statement. */ +// FIXME: this should not really be a DataObject, but a separate DataContainer and a BindingObject public interface RpcInput extends DataObject { @Override Class implementedInterface(); diff --git a/binding/yang-binding/src/main/java/org/opendaylight/yangtools/yang/binding/RpcOutput.java b/binding/yang-binding/src/main/java/org/opendaylight/yangtools/yang/binding/RpcOutput.java index 2f35be1ac0..c24e11f83f 100644 --- a/binding/yang-binding/src/main/java/org/opendaylight/yangtools/yang/binding/RpcOutput.java +++ b/binding/yang-binding/src/main/java/org/opendaylight/yangtools/yang/binding/RpcOutput.java @@ -7,15 +7,11 @@ */ package org.opendaylight.yangtools.yang.binding; -import com.google.common.annotations.Beta; - /** * Marker interface for all interfaces generated for {@code output} statement within an {@code action} or an {@code rpc} * statement. - * - * @author Robert Varga */ -@Beta +// FIXME: this should not really be a DataObject, but a separate DataContainer and a BindingObject public interface RpcOutput extends DataObject { @Override Class implementedInterface(); -- 2.36.6