From 15c403836c65097741408e7e4d4d6b0a2352f3cd Mon Sep 17 00:00:00 2001
From: Robert Varga <robert.varga@pantheon.tech>
Date: Tue, 26 Nov 2019 17:14:55 +0100
Subject: [PATCH] Remove checkstyle/spotbugs plugin overrides

checkstyle/spotbugs come configured in enforcing mode from odlparent,
hence we do not need to override the configuration.

Change-Id: I067ed0914deb0ff0dfc1d434e87c6ddf70bc9e46
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---
 bgp/path-selection-mode/pom.xml |  7 -------
 binding-parent/pom.xml          | 14 --------------
 parent/pom.xml                  | 14 --------------
 pcep/base-parser/pom.xml        | 12 ------------
 pcep/impl/pom.xml               |  7 -------
 testtool-parent/pom.xml         | 14 --------------
 6 files changed, 68 deletions(-)

diff --git a/bgp/path-selection-mode/pom.xml b/bgp/path-selection-mode/pom.xml
index ba0136cec5..3e5895935e 100644
--- a/bgp/path-selection-mode/pom.xml
+++ b/bgp/path-selection-mode/pom.xml
@@ -95,13 +95,6 @@
 
     <build>
         <plugins>
-            <plugin>
-                <groupId>com.github.spotbugs</groupId>
-                <artifactId>spotbugs-maven-plugin</artifactId>
-                <configuration>
-                    <failOnError>true</failOnError>
-                </configuration>
-            </plugin>
             <plugin>
                 <groupId>org.apache.felix</groupId>
                 <artifactId>maven-bundle-plugin</artifactId>
diff --git a/binding-parent/pom.xml b/binding-parent/pom.xml
index bdbd474991..c9042a2263 100644
--- a/binding-parent/pom.xml
+++ b/binding-parent/pom.xml
@@ -36,20 +36,6 @@
 
     <build>
         <plugins>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-checkstyle-plugin</artifactId>
-                <configuration>
-                     <propertyExpansion>checkstyle.violationSeverity=error</propertyExpansion>
-                 </configuration>
-            </plugin>
-            <plugin>
-                <groupId>com.github.spotbugs</groupId>
-                <artifactId>spotbugs-maven-plugin</artifactId>
-                <configuration>
-                    <failOnError>true</failOnError>
-                </configuration>
-            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-dependency-plugin</artifactId>
diff --git a/parent/pom.xml b/parent/pom.xml
index 36a4cdafca..e140f48c09 100644
--- a/parent/pom.xml
+++ b/parent/pom.xml
@@ -158,20 +158,6 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-checkstyle-plugin</artifactId>
-                <configuration>
-                    <propertyExpansion>checkstyle.violationSeverity=error</propertyExpansion>
-                </configuration>
-            </plugin>
-            <plugin>
-                <groupId>com.github.spotbugs</groupId>
-                <artifactId>spotbugs-maven-plugin</artifactId>
-                <configuration>
-                    <failOnError>true</failOnError>
-                </configuration>
-            </plugin>
         </plugins>
     </build>
     <scm>
diff --git a/pcep/base-parser/pom.xml b/pcep/base-parser/pom.xml
index 51aa3bbdd0..7e4683a175 100644
--- a/pcep/base-parser/pom.xml
+++ b/pcep/base-parser/pom.xml
@@ -67,18 +67,6 @@
         </dependency>
     </dependencies>
 
-    <build>
-        <plugins>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-checkstyle-plugin</artifactId>
-                <configuration>
-                    <violationSeverity>warn</violationSeverity>
-                </configuration>
-            </plugin>
-        </plugins>
-    </build>
-
     <scm>
         <connection>scm:git:ssh://git.opendaylight.org:29418/bgpcep.git</connection>
         <developerConnection>scm:git:ssh://git.opendaylight.org:29418/bgpcep.git</developerConnection>
diff --git a/pcep/impl/pom.xml b/pcep/impl/pom.xml
index fb3c6518c5..e23bf13aa5 100644
--- a/pcep/impl/pom.xml
+++ b/pcep/impl/pom.xml
@@ -142,13 +142,6 @@
                     </execution>
                 </executions>
             </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-checkstyle-plugin</artifactId>
-                <configuration>
-                    <violationSeverity>warn</violationSeverity>
-                </configuration>
-            </plugin>
         </plugins>
     </build>
 
diff --git a/testtool-parent/pom.xml b/testtool-parent/pom.xml
index 2e456e331f..940124864a 100644
--- a/testtool-parent/pom.xml
+++ b/testtool-parent/pom.xml
@@ -42,20 +42,6 @@
 
     <build>
         <plugins>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-checkstyle-plugin</artifactId>
-                <configuration>
-                    <propertyExpansion>checkstyle.violationSeverity=error</propertyExpansion>
-                </configuration>
-            </plugin>
-            <plugin>
-                <groupId>com.github.spotbugs</groupId>
-                <artifactId>spotbugs-maven-plugin</artifactId>
-                <configuration>
-                    <failOnError>true</failOnError>
-                </configuration>
-            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-dependency-plugin</artifactId>
-- 
2.36.6