From 22670a222e99a7d8cdfb4d9bd75262d6f4424d01 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Wed, 9 May 2018 14:33:10 +0200 Subject: [PATCH] Move trailing comments This is to make sonar happy. Change-Id: Iadb582329c5774c6e302317a70d718869444d2f2 Signed-off-by: Robert Varga --- .../util/concurrent/CachedThreadPoolExecutor.java | 8 +++++--- .../yangtools/util/concurrent/FastThreadPoolExecutor.java | 7 ++++--- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/common/util/src/main/java/org/opendaylight/yangtools/util/concurrent/CachedThreadPoolExecutor.java b/common/util/src/main/java/org/opendaylight/yangtools/util/concurrent/CachedThreadPoolExecutor.java index 0db9a83767..47fcb03d70 100644 --- a/common/util/src/main/java/org/opendaylight/yangtools/util/concurrent/CachedThreadPoolExecutor.java +++ b/common/util/src/main/java/org/opendaylight/yangtools/util/concurrent/CachedThreadPoolExecutor.java @@ -54,9 +54,10 @@ public class CachedThreadPoolExecutor extends ThreadPoolExecutor { * @param loggerIdentity * the class to use as logger name for logging uncaught exceptions from the threads. */ - @SuppressWarnings("checkstyle:LoggerFactoryClassParameter") // due to loggerIdentity argument usage + // due to loggerIdentity argument usage + @SuppressWarnings("checkstyle:LoggerFactoryClassParameter") public CachedThreadPoolExecutor(final int maximumPoolSize, final int maximumQueueSize, final String threadPrefix, - Class loggerIdentity) { + final Class loggerIdentity) { // We're using a custom SynchronousQueue that has a backing bounded LinkedBlockingQueue. // We don't specify any core threads (first parameter) so, when a task is submitted, // the base class will always try to offer to the queue. If there is an existing waiting @@ -142,7 +143,8 @@ public class CachedThreadPoolExecutor extends ThreadPoolExecutor { private static final long POLL_WAIT_TIME_IN_MS = 300; - @SuppressFBWarnings("SE_BAD_FIELD") // Runnable is not Serializable + @SuppressFBWarnings("SE_BAD_FIELD") + // Runnable is not Serializable private final TrackingLinkedBlockingQueue backingQueue; ExecutorQueue(final int maxBackingQueueSize) { diff --git a/common/util/src/main/java/org/opendaylight/yangtools/util/concurrent/FastThreadPoolExecutor.java b/common/util/src/main/java/org/opendaylight/yangtools/util/concurrent/FastThreadPoolExecutor.java index b205493647..24159770ff 100644 --- a/common/util/src/main/java/org/opendaylight/yangtools/util/concurrent/FastThreadPoolExecutor.java +++ b/common/util/src/main/java/org/opendaylight/yangtools/util/concurrent/FastThreadPoolExecutor.java @@ -43,7 +43,7 @@ public class FastThreadPoolExecutor extends ThreadPoolExecutor { * the class to use as logger name for logging uncaught exceptions from the threads. */ public FastThreadPoolExecutor(final int maximumPoolSize, final int maximumQueueSize, final String threadPrefix, - Class loggerIdentity) { + final Class loggerIdentity) { this(maximumPoolSize, maximumQueueSize, DEFAULT_IDLE_TIMEOUT_IN_SEC, TimeUnit.SECONDS, threadPrefix, loggerIdentity); } @@ -90,9 +90,10 @@ public class FastThreadPoolExecutor extends ThreadPoolExecutor { * @param loggerIdentity * the class to use as logger name for logging uncaught exceptions from the threads. */ - @SuppressWarnings("checkstyle:LoggerFactoryClassParameter") // due to loggerIdentity argument usage + // due to loggerIdentity argument usage + @SuppressWarnings("checkstyle:LoggerFactoryClassParameter") public FastThreadPoolExecutor(final int maximumPoolSize, final int maximumQueueSize, final long keepAliveTime, - final TimeUnit unit, final String threadPrefix, Class loggerIdentity) { + final TimeUnit unit, final String threadPrefix, final Class loggerIdentity) { // We use all core threads (the first 2 parameters below equal) so, when a task is submitted, // if the thread limit hasn't been reached, a new thread will be spawned to execute // the task even if there is an existing idle thread in the pool. This is faster than -- 2.36.6