From 24d6a23810dad0d90b19b2bcc6c011be924f9f8b Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Sun, 24 Aug 2014 22:12:09 +0200 Subject: [PATCH] BUG-1611: make sure runtime components create short comments The two instantiations here are performance-critical at runtime, and the comments in them get discarded. Let us not waste time generating them. Change-Id: If1e9a7507dac5b07011d3a9bcc75e42fbff340e1 Signed-off-by: Robert Varga --- .../generator/impl/RuntimeGeneratedMappingServiceImpl.java | 6 +++++- .../sal/binding/generator/util/BindingRuntimeContext.java | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/code-generator/binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/impl/RuntimeGeneratedMappingServiceImpl.java b/code-generator/binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/impl/RuntimeGeneratedMappingServiceImpl.java index da757095d6..29a532228d 100644 --- a/code-generator/binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/impl/RuntimeGeneratedMappingServiceImpl.java +++ b/code-generator/binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/impl/RuntimeGeneratedMappingServiceImpl.java @@ -13,6 +13,7 @@ import com.google.common.collect.HashMultimap; import com.google.common.collect.Multimap; import com.google.common.util.concurrent.ListenableFuture; import com.google.common.util.concurrent.SettableFuture; + import java.net.URI; import java.util.AbstractMap.SimpleEntry; import java.util.ArrayList; @@ -27,8 +28,11 @@ import java.util.Set; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; import java.util.concurrent.ExecutionException; + import javassist.ClassPool; + import javax.annotation.concurrent.GuardedBy; + import org.opendaylight.yangtools.binding.generator.util.BindingGeneratorUtil; import org.opendaylight.yangtools.binding.generator.util.ReferencedTypeImpl; import org.opendaylight.yangtools.binding.generator.util.Types; @@ -134,7 +138,7 @@ SchemaLock, AutoCloseable, SchemaContextHolder, TypeResolver { @GuardedBy("this") private void recreateBindingContext(final SchemaContext schemaContext) { - BindingGeneratorImpl newBinding = new BindingGeneratorImpl(); + BindingGeneratorImpl newBinding = new BindingGeneratorImpl(false); newBinding.generateTypes(schemaContext); for (Map.Entry entry : newBinding.getModuleContexts().entrySet()) { diff --git a/code-generator/binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/util/BindingRuntimeContext.java b/code-generator/binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/util/BindingRuntimeContext.java index 1b40b8895c..a69e30ea1f 100644 --- a/code-generator/binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/util/BindingRuntimeContext.java +++ b/code-generator/binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/util/BindingRuntimeContext.java @@ -77,7 +77,7 @@ public class BindingRuntimeContext implements Immutable { this.strategy = strategy; this.schemaContext = schema; - BindingGeneratorImpl generator = new BindingGeneratorImpl(); + BindingGeneratorImpl generator = new BindingGeneratorImpl(false); generator.generateTypes(schema); Map modules = generator.getModuleContexts(); -- 2.36.6