From 28204b1caf363e7f7ae8d184ad305cf958a24608 Mon Sep 17 00:00:00 2001
From: Lorand Jakab <lojakab@cisco.com>
Date: Thu, 2 Feb 2017 02:06:01 +0200
Subject: [PATCH] Checkstyle: no space inside parentheses

Add the ParenPad check to odl_checks.xml, which makes sure there is no
space after a left parenthesis and before a right parenthesis. Fix the
violations in odlparent.

Change-Id: Ib6cf36f05598f68ad034af67be17b8963bafba07
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
---
 .../org/opendaylight/odlparent/bundlestest/BundleDiagInfos.java | 2 +-
 .../org/opendaylight/odlparent/bundlestest/TestBundleDiag.java  | 2 +-
 .../opendaylight/odlparent/bundles4test/BundleDiagInfos.java    | 2 +-
 .../org/opendaylight/odlparent/bundles4test/TestBundleDiag.java | 2 +-
 checkstyle/src/main/resources/odl_checks.xml                    | 1 +
 5 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/bundles-test/src/main/java/org/opendaylight/odlparent/bundlestest/BundleDiagInfos.java b/bundles-test/src/main/java/org/opendaylight/odlparent/bundlestest/BundleDiagInfos.java
index 547e14999..8a53d68b8 100644
--- a/bundles-test/src/main/java/org/opendaylight/odlparent/bundlestest/BundleDiagInfos.java
+++ b/bundles-test/src/main/java/org/opendaylight/odlparent/bundlestest/BundleDiagInfos.java
@@ -36,7 +36,7 @@ public class BundleDiagInfos {
     private final Map<BundleState, Integer> bundleStatesCounters;
 
     private static final Map<String, BundleState> WHITELISTED_BUNDLES = ImmutableMap.of(
-            "slf4j.log4j12", Installed );
+            "slf4j.log4j12", Installed);
 
     public static BundleDiagInfos forContext(BundleContext bundleContext, BundleService bundleService) {
         List<String> okBundleStateInfoTexts = new ArrayList<>();
diff --git a/bundles-test/src/main/java/org/opendaylight/odlparent/bundlestest/TestBundleDiag.java b/bundles-test/src/main/java/org/opendaylight/odlparent/bundlestest/TestBundleDiag.java
index 4d72552fe..7a0732ff4 100644
--- a/bundles-test/src/main/java/org/opendaylight/odlparent/bundlestest/TestBundleDiag.java
+++ b/bundles-test/src/main/java/org/opendaylight/odlparent/bundlestest/TestBundleDiag.java
@@ -57,7 +57,7 @@ public class TestBundleDiag {
                     .conditionEvaluationListener(
                         condition -> LOG.info("{} (elapsed time {}s, remaining time {}s)",
                             ((BundleDiagInfos) condition.getValue()).getSummaryText(),
-                            condition.getElapsedTimeInMS() / 1000, condition.getRemainingTimeInMS() / 1000 ))
+                            condition.getElapsedTimeInMS() / 1000, condition.getRemainingTimeInMS() / 1000))
                     .until(() -> getBundleDiagInfos(), new BundleServiceSummaryMatcher());
 
             // If we're here then either BundleServiceSummaryMatcher quit because of Active, Failure or Stopping..
diff --git a/bundles4-test/src/main/java/org/opendaylight/odlparent/bundles4test/BundleDiagInfos.java b/bundles4-test/src/main/java/org/opendaylight/odlparent/bundles4test/BundleDiagInfos.java
index 47f6f6e53..47d698c5a 100644
--- a/bundles4-test/src/main/java/org/opendaylight/odlparent/bundles4test/BundleDiagInfos.java
+++ b/bundles4-test/src/main/java/org/opendaylight/odlparent/bundles4test/BundleDiagInfos.java
@@ -36,7 +36,7 @@ public class BundleDiagInfos {
     private final Map<BundleState, Integer> bundleStatesCounters;
 
     private static final Map<String, BundleState> WHITELISTED_BUNDLES = ImmutableMap.of(
-            "slf4j.log4j12", Installed );
+            "slf4j.log4j12", Installed);
 
     public static BundleDiagInfos forContext(BundleContext bundleContext, BundleService bundleService) {
         List<String> okBundleStateInfoTexts = new ArrayList<>();
diff --git a/bundles4-test/src/main/java/org/opendaylight/odlparent/bundles4test/TestBundleDiag.java b/bundles4-test/src/main/java/org/opendaylight/odlparent/bundles4test/TestBundleDiag.java
index d1b87d91b..88a585b37 100644
--- a/bundles4-test/src/main/java/org/opendaylight/odlparent/bundles4test/TestBundleDiag.java
+++ b/bundles4-test/src/main/java/org/opendaylight/odlparent/bundles4test/TestBundleDiag.java
@@ -57,7 +57,7 @@ public class TestBundleDiag {
                     .conditionEvaluationListener(
                         condition -> LOG.info("{} (elapsed time {}s, remaining time {}s)",
                             ((BundleDiagInfos) condition.getValue()).getSummaryText(),
-                            condition.getElapsedTimeInMS() / 1000, condition.getRemainingTimeInMS() / 1000 ))
+                            condition.getElapsedTimeInMS() / 1000, condition.getRemainingTimeInMS() / 1000))
                     .until(() -> getBundleDiagInfos(), new BundleServiceSummaryMatcher());
 
             // If we're here then either BundleServiceSummaryMatcher quit because of Active, Failure or Stopping..
diff --git a/checkstyle/src/main/resources/odl_checks.xml b/checkstyle/src/main/resources/odl_checks.xml
index db4f698d0..f1c23365b 100644
--- a/checkstyle/src/main/resources/odl_checks.xml
+++ b/checkstyle/src/main/resources/odl_checks.xml
@@ -75,6 +75,7 @@
              <message key="ws.notPreceded"
              value="WhitespaceAround: ''{0}'' is not preceded with whitespace."/>
         </module>
+        <module name="ParenPad" />
         <module name="OneStatementPerLine"/>
         <module name="MultipleVariableDeclarations"/>
         <module name="ArrayTypeStyle"/>
-- 
2.36.6