From 28b2c230f2277d53dd80892e95122d82276ec871 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Thu, 24 Mar 2022 13:30:16 +0100 Subject: [PATCH] Do not shuffle PathArguments needlessly There is no point in creating a separate collection if we are not doing anything with it. Change-Id: I3199c7232c63464b315eff8f69aac98181946ebd Signed-off-by: Robert Varga --- .../common/serializer/AbstractWebsocketSerializer.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/restconf/restconf-common/src/main/java/org/opendaylight/restconf/common/serializer/AbstractWebsocketSerializer.java b/restconf/restconf-common/src/main/java/org/opendaylight/restconf/common/serializer/AbstractWebsocketSerializer.java index 369e3c97af..8dfcdef775 100644 --- a/restconf/restconf-common/src/main/java/org/opendaylight/restconf/common/serializer/AbstractWebsocketSerializer.java +++ b/restconf/restconf-common/src/main/java/org/opendaylight/restconf/common/serializer/AbstractWebsocketSerializer.java @@ -41,14 +41,13 @@ public abstract class AbstractWebsocketSerializer { public final void serialize(final DataTreeCandidate candidate, final boolean leafNodesOnly, final boolean skipData) throws T { - final Deque path = new ArrayDeque<>(); - path.addAll(candidate.getRootPath().getPathArguments()); if (leafNodesOnly) { + final Deque path = new ArrayDeque<>(); + path.addAll(candidate.getRootPath().getPathArguments()); serializeLeafNodesOnly(path, candidate.getRootNode(), skipData); - return; + } else { + serializeData(candidate.getRootPath().getPathArguments(), candidate.getRootNode(), skipData); } - - serializeData(path, candidate.getRootNode(), skipData); } void serializeLeafNodesOnly(final Deque path, final DataTreeCandidateNode candidate, -- 2.36.6