From 2aaa5ff2d71fe5e6eec76a63fab1c0c18d049689 Mon Sep 17 00:00:00 2001 From: Jozef Gloncak Date: Fri, 21 Aug 2015 15:39:55 +0200 Subject: [PATCH] BUG-4084: Li: Log unsuccessful submiting of write transactiion If some exception occures during transaction submiting it is logged (until now it was silently ignored). Change-Id: I576572949259e9dd41be3efd6bd6a0a0a07955ee Signed-off-by: Jozef Gloncak --- .../impl/device/TransactionChainManager.java | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/TransactionChainManager.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/TransactionChainManager.java index d249231757..4706cc1df8 100644 --- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/TransactionChainManager.java +++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/device/TransactionChainManager.java @@ -107,7 +107,22 @@ class TransactionChainManager implements TransactionChainListener, AutoCloseable LOG.trace("nothing to commit - submit returns true"); return true; } - wTx.submit(); + final CheckedFuture submitFuture = wTx.submit(); + Futures.addCallback(submitFuture, new FutureCallback() { + @Override + public void onSuccess(Void result) { + //no action required + } + + @Override + public void onFailure(Throwable t) { + if (t instanceof TransactionCommitFailedException) { + LOG.error("Transaction commit failed. {}", t); + } else { + LOG.error("Exception during transaction submitting. {}", t); + } + } + }); wTx = null; } return true; -- 2.36.6