From 2d23ef5a1a519ceab436ed033c364b5334b5e5e9 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Thu, 18 Feb 2021 01:40:52 +0100 Subject: [PATCH] Do not build unknown statements twice SpotBugs is spotting this in an unrelated change, we should be checking the product. Change-Id: I822eb8667d2788b6887a0f72a4f78e294c367600 Signed-off-by: Robert Varga --- .../parser/rfc7950/stmt/UnknownEffectiveStatementBase.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/UnknownEffectiveStatementBase.java b/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/UnknownEffectiveStatementBase.java index d24b29cb21..4e910c2694 100644 --- a/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/UnknownEffectiveStatementBase.java +++ b/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/UnknownEffectiveStatementBase.java @@ -7,7 +7,8 @@ */ package org.opendaylight.yangtools.yang.parser.rfc7950.stmt; -import com.google.common.base.Preconditions; +import static com.google.common.base.Preconditions.checkState; + import com.google.common.collect.ImmutableList; import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.yangtools.yang.common.QName; @@ -44,9 +45,9 @@ public abstract class UnknownEffectiveStatementBase effective = extensionInit.buildEffective(); - Preconditions.checkState(effective instanceof ExtensionDefinition, + checkState(effective instanceof ExtensionDefinition, "Statement %s is not an ExtensionDefinition", effective); - extension = (ExtensionDefinition) extensionInit.buildEffective(); + extension = (ExtensionDefinition) effective; nodeType = null; } -- 2.36.6