From 2eb8e4e4449d2a9450c78f00428e6d2bf834bea9 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Thu, 2 Mar 2023 12:37:29 +0100 Subject: [PATCH] Synchronize SegmentedJournal.open() SpotBugs is pointing out a problem with synchronization to currentSegment. This is a false positive, as we only call this method from the constructor, but slap a synchronized keyword on it anyway. JIRA: CONTROLLER-2071 Change-Id: Iaf3a13c4122a3321b615eb5629327494165c0bed Signed-off-by: Robert Varga --- .../main/java/io/atomix/storage/journal/SegmentedJournal.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/third-party/atomix/storage/src/main/java/io/atomix/storage/journal/SegmentedJournal.java b/third-party/atomix/storage/src/main/java/io/atomix/storage/journal/SegmentedJournal.java index fed7ab8d3e..45490757f8 100644 --- a/third-party/atomix/storage/src/main/java/io/atomix/storage/journal/SegmentedJournal.java +++ b/third-party/atomix/storage/src/main/java/io/atomix/storage/journal/SegmentedJournal.java @@ -230,7 +230,7 @@ public final class SegmentedJournal implements Journal { /** * Opens the segments. */ - private void open() { + private synchronized void open() { // Load existing log segments from disk. for (JournalSegment segment : loadSegments()) { segments.put(segment.descriptor().index(), segment); -- 2.36.6