From 326a30321507d88f8a048ebe0c2fdd9f94b97e1a Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Fri, 11 Dec 2020 03:41:24 +0100 Subject: [PATCH] Fix a sonar complaint Sonar wants us to merge the two if statements, which makes sense. Also use a method reference instead of a full lambda. Change-Id: I465ab536ab9b5bedde870b741a47becbc271ca8b Signed-off-by: Robert Varga --- .../mdsal/replicate/netty/SinkSingletonService.java | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/replicate/mdsal-replicate-netty/src/main/java/org/opendaylight/mdsal/replicate/netty/SinkSingletonService.java b/replicate/mdsal-replicate-netty/src/main/java/org/opendaylight/mdsal/replicate/netty/SinkSingletonService.java index 98e154e3d8..02aa97eb3c 100644 --- a/replicate/mdsal-replicate-netty/src/main/java/org/opendaylight/mdsal/replicate/netty/SinkSingletonService.java +++ b/replicate/mdsal-replicate-netty/src/main/java/org/opendaylight/mdsal/replicate/netty/SinkSingletonService.java @@ -170,14 +170,10 @@ final class SinkSingletonService extends ChannelInitializer imple } private synchronized void channelClosed(final ChannelFuture completedFuture, final ScheduledExecutorService group) { - if (futureChannel != null && futureChannel.channel() == completedFuture.channel()) { - if (!closingInstance) { - LOG.info("Channel {} lost connection to source {}, reconnecting in {}", completedFuture.channel(), - sourceAddress, reconnectDelay.getSeconds()); - group.schedule(() -> { - reconnect(); - }, reconnectDelay.toNanos(), TimeUnit.NANOSECONDS); - } + if (futureChannel != null && futureChannel.channel() == completedFuture.channel() && !closingInstance) { + LOG.info("Channel {} lost connection to source {}, reconnecting in {}", completedFuture.channel(), + sourceAddress, reconnectDelay.getSeconds()); + group.schedule(this::reconnect, reconnectDelay.toNanos(), TimeUnit.NANOSECONDS); } } -- 2.36.6