From 36ba2a9c81dc310d1dcdc19f28605282b8a004ca Mon Sep 17 00:00:00 2001 From: Daniel Farrell Date: Mon, 8 Oct 2018 18:50:14 -0400 Subject: [PATCH] Clarify docstrings for pkg java ver unit tests Fix one wrong docstring, clarify others in unit tests for package building logic. Change-Id: Ibebb35826456510f60bc72e006693ad86b2e7000 Signed-off-by: Daniel Farrell --- packages/test_lib.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/test_lib.py b/packages/test_lib.py index 6a6f95a..4fc26f3 100644 --- a/packages/test_lib.py +++ b/packages/test_lib.py @@ -263,47 +263,47 @@ class TestGetJavaVersion(unittest.TestCase): self.assertIsInstance(java_version, int) def test_type_given_str(self): - """Pass int, check that returned value is of the right type.""" + """Pass str, check that returned value is of the right type.""" java_version = lib.get_java_version("6") self.assertIsInstance(java_version, int) def test_old_given_int(self): - """Pass old ODL major version, check that Java 7 returned.""" + """Pass old ODL major version as int, check that Java 7 returned.""" java_version = lib.get_java_version(4) self.assertEqual(java_version, 7) def test_old_given_str(self): - """Pass old ODL major version, check that Java 7 returned.""" + """Pass old ODL major version as str, check that Java 7 returned.""" java_version = lib.get_java_version("4") self.assertEqual(java_version, 7) def test_oxygen_given_int(self): - """Pass Oxygen major version, check that Java 8 returned.""" + """Pass Oxygen major version as int, check that Java 8 returned.""" java_version = lib.get_java_version(8) self.assertEqual(java_version, 8) def test_oxygen_given_str(self): - """Pass Oxygen major version, check that Java 8 returned.""" + """Pass Oxygen major version as str, check that Java 8 returned.""" java_version = lib.get_java_version("8") self.assertEqual(java_version, 8) def test_fluorine_given_int(self): - """Pass Fluorine major version, check that Java 8 returned.""" + """Pass Fluorine major version as int, check that Java 8 returned.""" java_version = lib.get_java_version(9) self.assertEqual(java_version, 8) def test_fluorine_given_str(self): - """Pass Fluorine major version, check that Java 8 returned.""" + """Pass Fluorine major version as str, check that Java 8 returned.""" java_version = lib.get_java_version("9") self.assertEqual(java_version, 8) def test_neon_given_int(self): - """Pass Neon major version, check that Java 8 returned.""" + """Pass Neon major version as int, check that Java 8 returned.""" java_version = lib.get_java_version(10) self.assertEqual(java_version, 8) def test_neon_given_str(self): - """Pass Neon major version, check that Java 8 returned.""" + """Pass Neon major version as str, check that Java 8 returned.""" java_version = lib.get_java_version("10") self.assertEqual(java_version, 8) -- 2.36.6