From 377ac01712fd31f4239abf649aa0e76b0e7e3b2e Mon Sep 17 00:00:00 2001
From: Robert Varga <robert.varga@pantheon.tech>
Date: Fri, 3 Jul 2020 10:42:26 +0200
Subject: [PATCH] Remove AbstractEffectiveModule.name

This field is just shadowing argument(), remove it.

JIRA: YANGTOOLS-1065
Change-Id: Ib3b078548269b50ae69f4cecceee47dc9890b562
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---
 .../yang/parser/rfc7950/stmt/AbstractEffectiveModule.java   | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/AbstractEffectiveModule.java b/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/AbstractEffectiveModule.java
index ea7e7f1c72..bf49263c37 100644
--- a/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/AbstractEffectiveModule.java
+++ b/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/AbstractEffectiveModule.java
@@ -68,7 +68,6 @@ public abstract class AbstractEffectiveModule<D extends DeclaredStatement<String
         E extends DataTreeAwareEffectiveStatement<String, D>>
         extends AbstractEffectiveDocumentedNodeWithStatus<String, D>
         implements Module, NotificationNodeContainerCompat<String, D, E> {
-    private final String name;
     private final String prefix;
     private final YangVersion yangVersion;
     private final String organization;
@@ -103,7 +102,6 @@ public abstract class AbstractEffectiveModule<D extends DeclaredStatement<String
         // Data tree check, not currently used
         createDataTreeNamespace(ctx.getStatementSourceReference(), schemaTree.values(), schemaTreeNamespace);
 
-        this.name = argument();
         this.prefix = requireNonNull(prefix);
         this.yangVersion = findFirstEffectiveSubstatementArgument(YangVersionEffectiveStatement.class)
                 .orElse(YangVersion.VERSION_1);
@@ -193,7 +191,7 @@ public abstract class AbstractEffectiveModule<D extends DeclaredStatement<String
 
     @Override
     public String getName() {
-        return name;
+        return argument();
     }
 
     @Override
@@ -306,7 +304,7 @@ public abstract class AbstractEffectiveModule<D extends DeclaredStatement<String
     @Override
     public String toString() {
         return MoreObjects.toStringHelper(this).omitNullValues()
-                .add("name", name)
+                .add("name", getName())
                 .add("namespace", getNamespace())
                 .add("revision", getRevision().orElse(null))
                 .add("prefix", prefix)
-- 
2.36.6