From 39564529217a08265adf9790e3f9a9d9ef0c4b6d Mon Sep 17 00:00:00 2001 From: Ryan Goulding Date: Tue, 27 Feb 2018 16:26:19 -0500 Subject: [PATCH] ODLPARENT-142: Don't package mysql-connector-java Heavy handed approach to removing mysql-connector-java artifact from our distribution. Karaf includes this artifact for use with its "jdbc" feature as of [4,5). However, it is not license friendly (it is GPL), so we should not ship it as part of our distribution. Since we prepopulate "system" with all of the necessary jars to start ODL offline, this approach just deletes the artifact in the prepare-package phase. This means that if someone attempts to use our base distribution w/ "jdbc", then they will get a nasty error since mysql client classes won't exist. If they have a use case that allows GPL licensing, they can always deploy it using an out of band method (i.e., hot deployment of the artifact, or copying it into system by hand). In the future, we should address PAXJDBC-128 as a proper fix. This is a stopgap measure for the meantime, since the aforementioned solution requires a new version of pax-features-jdbc, a new version of karaf, and a new version of odlparent. We should additionally release-note this as a known issue with odlparent's karaf4-parent, since some downstream distributions likely inherit from odlparent (instead of integration/distribution), and should be made aware that they need to disclude this file themselves. Change-Id: I5126f9ae8cdbe554fbb8a01dcc6af2d8deaa8939 Signed-off-by: Ryan Goulding Signed-off-by: Stephen Kitt --- karaf/pom.xml | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/karaf/pom.xml b/karaf/pom.xml index 304a42fc..8b0fe949 100644 --- a/karaf/pom.xml +++ b/karaf/pom.xml @@ -131,6 +131,27 @@ + + + + org.apache.maven.plugins + maven-antrun-plugin + + + prepare-package + + run + + + + + + + + + + + -- 2.36.6