From 437f014183830c9cf723ff56adcd84571dd79281 Mon Sep 17 00:00:00 2001 From: Jozef Behran Date: Tue, 17 May 2016 14:26:50 +0200 Subject: [PATCH] More readable log message for ExecuteCommandOnRemoteSystem The original logging command produced a message like "Attempting to execute sudo /sbin/iptables -I OUTPUT -p all --source 10.30.32.162 --destination 10.30.32.204 -j DROP on 10.30.32.162 by jenkins with any and >" which is pretty confusing as it is not clear what part is the command to be execute, what part is the remote system to be executed and so on. The new format is something like 'Attempting to execute command "sudo /sbin/iptables -I OUTPUT -p all --source 10.30.32.162 --destination 10.30.32.204 -j DROP" on remote system "10.30.32.162" by user "jenkins" with keyfile "any" and prompt ">"' which is far more readable as now the message described each of the items it contains and also uses quotes to make it explicit where the items start and end in the message. Change-Id: I886059bd7bae6ebde866977a49b4bf6eb63354d1 Signed-off-by: Jozef Behran --- csit/libraries/Utils.robot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/csit/libraries/Utils.robot b/csit/libraries/Utils.robot index d9bfedfc82..13b1dd1b29 100644 --- a/csit/libraries/Utils.robot +++ b/csit/libraries/Utils.robot @@ -233,7 +233,7 @@ Run Command On Remote System ... robot keyword, taking care to log in with a public key and. The command given is written ... and the output returned. No test conditions are checked. ${current_ssh_connection}= SSHLibrary.Get Connection - Log Attempting to execute ${cmd} on ${system} by ${user} with ${keyfile_pass} and ${prompt} + Log Attempting to execute command "${cmd}" on remote system "${system}" by user "${user}" with keyfile pass "${keyfile_pass}" and prompt "${prompt}" ${conn_id}= SSHLibrary.Open Connection ${system} prompt=${prompt} timeout=${prompt_timeout} Flexible SSH Login ${user} ${password} ${stdout} ${stderr} SSHLibrary.Execute Command ${cmd} return_stderr=True -- 2.36.6