From 4db9f81b58fb7b20f7bbf0b83db0f5ca8616c099 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Wed, 4 Sep 2019 14:44:47 +0200 Subject: [PATCH] Fix ClassTemplate.genConstructor() declaration Using an array here is forcing us to needlessly unwrap the arraylist (a perfectly iterable thing) to an array, which is only iterater over. Fix this by passing down an iterable, which means the list can be passed down as is. Change-Id: I1572729d554c3ce8ae6ab94c1ba3d5547399e7ab Signed-off-by: Robert Varga --- .../mdsal/binding/java/api/generator/ClassTemplate.xtend | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/ClassTemplate.xtend b/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/ClassTemplate.xtend index 02d52bffda..ddce529380 100644 --- a/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/ClassTemplate.xtend +++ b/binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/ClassTemplate.xtend @@ -260,7 +260,7 @@ class ClassTemplate extends BaseTemplate { ''' - def protected genConstructor(GeneratedProperty property, GeneratedProperty... other) ''' + def protected genConstructor(GeneratedProperty property, Iterable other) ''' public «type.name»(«property.returnType.importedName + " " + property.name») { «IF false == parentProperties.empty» super(«parentProperties.asArguments»); -- 2.36.6