From 55112d628f5db3c7ad81d252d16aa5c4f71821ad Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Mon, 17 Feb 2020 23:36:15 +0100 Subject: [PATCH 1/1] Deprecate BindingRuntimeContext.getEnumMapping() Generated enumerations capture their YANG-declared name and expose it as their method. JIRA: MDSAL-392 Change-Id: Iac16b6b3599565f059332ed079c432c0603ac500 Signed-off-by: Robert Varga --- .../mdsal/binding/generator/util/BindingRuntimeContext.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/mdsal/binding/generator/util/BindingRuntimeContext.java b/binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/mdsal/binding/generator/util/BindingRuntimeContext.java index dc2be63654..400bed420f 100644 --- a/binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/mdsal/binding/generator/util/BindingRuntimeContext.java +++ b/binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/mdsal/binding/generator/util/BindingRuntimeContext.java @@ -47,6 +47,7 @@ import org.opendaylight.mdsal.binding.spec.naming.BindingMapping; import org.opendaylight.yangtools.concepts.Immutable; import org.opendaylight.yangtools.yang.binding.Action; import org.opendaylight.yangtools.yang.binding.Augmentation; +import org.opendaylight.yangtools.yang.binding.Enumeration; import org.opendaylight.yangtools.yang.common.QName; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.AugmentationIdentifier; import org.opendaylight.yangtools.yang.model.api.ActionDefinition; @@ -310,7 +311,9 @@ public final class BindingRuntimeContext implements Immutable { * * @param enumClass enum generated class * @return mapped enum constants from yang with their corresponding values in generated binding classes + * @deprecated This method is not guaranteed to be accurate. Use {@link Enumeration#getName()} instead. */ + @Deprecated public BiMap getEnumMapping(final Class enumClass) { final Entry typeWithSchema = getTypeWithSchema(enumClass); return getEnumMapping(typeWithSchema); @@ -321,7 +324,9 @@ public final class BindingRuntimeContext implements Immutable { * * @param enumClassName enum generated class name * @return mapped enum constants from yang with their corresponding values in generated binding classes + * @deprecated This method is not guaranteed to be accurate. Use {@link Enumeration#getName()} instead. */ + @Deprecated public BiMap getEnumMapping(final String enumClassName) { return getEnumMapping(findTypeWithSchema(enumClassName)); } -- 2.36.6