From 5885e041c56a454801ca41a94bc1489c7fa15111 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Tue, 12 Sep 2017 20:38:11 +0200 Subject: [PATCH] Fix checkstyle in yang-parser-spi This is public contract, clean up checkstyle issues and expand documentation a bit. Change-Id: Iead665f037bb0396bd0ff294d54c427a0e82168c Signed-off-by: Robert Varga --- yang/yang-parser-spi/pom.xml | 12 ++ .../yang/parser/spi/ExtensionNamespace.java | 12 +- .../yang/parser/spi/FeatureNamespace.java | 13 +- .../yang/parser/spi/GroupingNamespace.java | 16 +- .../yang/parser/spi/IdentityNamespace.java | 7 +- .../yang/parser/spi/ModuleNamespace.java | 3 +- .../yang/parser/spi/NamespaceToModule.java | 9 +- .../parser/spi/PreLinkageModuleNamespace.java | 3 +- .../spi/SchemaNodeIdentifierNamespace.java | 18 +-- .../yang/parser/spi/SubmoduleNamespace.java | 7 +- .../yang/parser/spi/TypeNamespace.java | 16 +- .../spi/meta/AbstractStatementSupport.java | 40 +++-- .../yang/parser/spi/meta/CopyHistory.java | 1 + .../spi/meta/DerivedIdentitiesNamespace.java | 9 +- .../spi/meta/DerivedNamespaceBehaviour.java | 7 +- .../spi/meta/ImportedNamespaceContext.java | 2 +- .../parser/spi/meta/InferenceException.java | 2 +- .../meta/InvalidSubstatementException.java | 11 +- .../meta/MissingSubstatementException.java | 5 +- .../parser/spi/meta/ModelActionBuilder.java | 102 ++++++------ .../parser/spi/meta/ModelProcessingPhase.java | 15 +- .../parser/spi/meta/NamespaceBehaviour.java | 65 ++++---- .../meta/NamespaceNotAvailableException.java | 5 +- .../meta/SemanticVersionModuleNamespace.java | 4 +- .../spi/meta/SemanticVersionNamespace.java | 2 +- .../parser/spi/meta/StatementSupport.java | 78 ++++----- .../spi/meta/StatementSupportBundle.java | 33 ++-- .../yang/parser/spi/meta/StmtContext.java | 6 +- .../parser/spi/meta/StmtContextUtils.java | 149 +++++++++--------- .../spi/meta/SubstatementValidator.java | 46 +++--- .../source/AnyxmlSchemaLocationNamespace.java | 10 +- .../spi/source/AugmentToChoiceNamespace.java | 4 +- .../spi/source/BelongsToModuleContext.java | 5 +- .../BelongsToPrefixToModuleIdentifier.java | 10 +- .../source/BelongsToPrefixToModuleName.java | 5 +- .../spi/source/DeclarationInTextSource.java | 101 ++++++------ .../source/ImpPrefixToModuleIdentifier.java | 5 +- .../spi/source/ImpPrefixToNamespace.java | 4 +- .../ImpPrefixToSemVerModuleIdentifier.java | 4 +- .../IncludedSubmoduleNameToIdentifier.java | 5 +- .../source/ModuleCtxToModuleIdentifier.java | 6 +- .../spi/source/ModuleCtxToModuleQName.java | 4 +- .../source/ModuleIdentifierToModuleQName.java | 6 +- .../spi/source/ModuleNameToModuleQName.java | 4 +- .../spi/source/ModuleNameToNamespace.java | 4 +- .../source/ModuleNamespaceForBelongsTo.java | 2 +- .../spi/source/ModuleQNameToModuleName.java | 7 +- .../parser/spi/source/PrefixToModule.java | 8 +- .../parser/spi/source/PrefixToModuleMap.java | 13 +- .../source/QNameToStatementDefinition.java | 5 +- .../source/QNameToStatementDefinitionMap.java | 3 +- .../spi/source/StatementSourceReference.java | 24 ++- .../spi/source/StatementStreamSource.java | 71 ++++----- .../parser/spi/source/StatementWriter.java | 14 +- .../ValidationBundlesNamespace.java | 18 +-- 55 files changed, 484 insertions(+), 556 deletions(-) diff --git a/yang/yang-parser-spi/pom.xml b/yang/yang-parser-spi/pom.xml index 4e6b17a4a2..a8733c1ab4 100644 --- a/yang/yang-parser-spi/pom.xml +++ b/yang/yang-parser-spi/pom.xml @@ -51,6 +51,18 @@ + + + + org.apache.maven.plugins + maven-checkstyle-plugin + + checkstyle.violationSeverity=error + + + + +