From 59e764bc67d3c349cc112e0a64ba2a3bb679079e Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Thu, 22 Sep 2022 11:48:29 +0200 Subject: [PATCH] Iterate over simple array There is no point in using Arrays.asList(), as we end up only iterating over the list anyway. Change-Id: I7e0345ea6ae92fc61d8814a0424837c51719612c Signed-off-by: Robert Varga --- .../impl/CustomFilterAdapterConfigurationImpl.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/aaa-filterchain/src/main/java/org/opendaylight/aaa/filterchain/configuration/impl/CustomFilterAdapterConfigurationImpl.java b/aaa-filterchain/src/main/java/org/opendaylight/aaa/filterchain/configuration/impl/CustomFilterAdapterConfigurationImpl.java index 0b1ec8a57..0890da97c 100644 --- a/aaa-filterchain/src/main/java/org/opendaylight/aaa/filterchain/configuration/impl/CustomFilterAdapterConfigurationImpl.java +++ b/aaa-filterchain/src/main/java/org/opendaylight/aaa/filterchain/configuration/impl/CustomFilterAdapterConfigurationImpl.java @@ -12,7 +12,6 @@ import static java.util.Objects.requireNonNull; import com.google.common.base.Strings; import com.google.common.collect.ImmutableList; import com.google.common.collect.Iterators; -import java.util.Arrays; import java.util.Collection; import java.util.Collections; import java.util.Enumeration; @@ -256,11 +255,8 @@ public final class CustomFilterAdapterConfigurationImpl implements CustomFilterA final String customFilterListValue = configuration.get(CUSTOM_FILTER_LIST_KEY); final ImmutableList.Builder customFilterListBuilder = ImmutableList.builder(); if (customFilterListValue != null) { - // Creates the list from comma separate values; whitespace is - // removed first - final List filterClazzNames = Arrays - .asList(customFilterListValue.replaceAll("\\s", "").split(FILTER_DTO_SEPARATOR)); - for (String filterClazzName : filterClazzNames) { + // Creates the list from comma separate values; whitespace is removed first + for (String filterClazzName : customFilterListValue.replaceAll("\\s", "").split(FILTER_DTO_SEPARATOR)) { if (!Strings.isNullOrEmpty(filterClazzName)) { final Map applicableConfigs = extractPropertiesForFilter(filterClazzName, configuration); -- 2.36.6