From 62506a770072186715da157c11360cbd6adf7ad3 Mon Sep 17 00:00:00 2001 From: Marian Adamjak Date: Mon, 27 Oct 2014 10:19:32 +0100 Subject: [PATCH] BUG 2245 - Fixed Redundant Modifier Change-Id: Iabdb33c37646cd3bff16c978abac73914875aeb5 Signed-off-by: Marian Adamjak --- .../api/connection/ConnectionAdapter.java | 16 ++++++++-------- .../connection/ConnectionConfiguration.java | 15 +++++++-------- .../connection/ConnectionReadyListener.java | 2 +- .../connection/SwitchConnectionHandler.java | 4 ++-- .../api/connection/ThreadConfiguration.java | 4 ++-- .../api/connection/TlsConfiguration.java | 18 +++++++++--------- .../DeserializerExtensionProvider.java | 8 ++++---- .../extensibility/DeserializerRegistry.java | 8 ++++---- .../DeserializerRegistryInjector.java | 2 +- .../api/extensibility/HeaderDeserializer.java | 2 +- .../api/extensibility/HeaderSerializer.java | 2 +- .../api/extensibility/OFDeserializer.java | 2 +- .../api/extensibility/OFSerializer.java | 2 +- .../SerializerExtensionProvider.java | 16 ++++++++-------- .../api/extensibility/SerializerRegistry.java | 6 +++--- .../SerializerRegistryInjector.java | 2 +- .../connection/ConnectionAdapterFactory.java | 2 +- .../impl/connection/MessageConsumer.java | 2 +- .../impl/connection/OnlineProvider.java | 2 +- .../protocol/impl/connection/ServerFacade.java | 2 +- .../impl/connection/ShutdownProvider.java | 2 +- .../protocol/impl/util/CodeKeyMaker.java | 2 +- .../protocol/impl/util/TypeKeyMaker.java | 2 +- .../protocol/impl/clients/ClientEvent.java | 2 +- .../protocol/impl/clients/OFClient.java | 8 ++++---- 25 files changed, 66 insertions(+), 67 deletions(-) diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/ConnectionAdapter.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/ConnectionAdapter.java index d9d63228..50a85fbc 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/ConnectionAdapter.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/ConnectionAdapter.java @@ -26,41 +26,41 @@ public interface ConnectionAdapter extends OpenflowProtocolService { * disconnect corresponding switch * @return future set to true, when disconnect completed */ - public Future disconnect(); + Future disconnect(); /** * @return true, if connection to switch is alive */ - public boolean isAlive(); + boolean isAlive(); /** * @return address of the remote end - address of a switch if connected */ - public InetSocketAddress getRemoteAddress(); + InetSocketAddress getRemoteAddress(); /** * @param messageListener here will be pushed all messages from switch */ - public void setMessageListener(OpenflowProtocolListener messageListener); + void setMessageListener(OpenflowProtocolListener messageListener); /** * @param systemListener here will be pushed all system messages from library */ - public void setSystemListener(SystemNotificationsListener systemListener); + void setSystemListener(SystemNotificationsListener systemListener); /** * Throws exception if any of required listeners is missing */ - public void checkListeners(); + void checkListeners(); /** * notify listener about connection ready-to-use event */ - public void fireConnectionReadyNotification(); + void fireConnectionReadyNotification(); /** * set listener for connection became ready-to-use event * @param connectionReadyListener */ - public void setConnectionReadyListener(ConnectionReadyListener connectionReadyListener); + void setConnectionReadyListener(ConnectionReadyListener connectionReadyListener); } diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/ConnectionConfiguration.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/ConnectionConfiguration.java index 8b344769..6a61b585 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/ConnectionConfiguration.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/ConnectionConfiguration.java @@ -6,7 +6,6 @@ * and is available at http://www.eclipse.org/legal/epl-v10.html */ - package org.opendaylight.openflowjava.protocol.api.connection; import java.net.InetAddress; @@ -24,35 +23,35 @@ public interface ConnectionConfiguration { /** * @return address to bind, if null, all available interfaces will be used */ - public InetAddress getAddress(); + InetAddress getAddress(); /** * @return port to bind */ - public int getPort(); + int getPort(); /** * @return transport protocol to use */ - public Object getTransferProtocol(); + Object getTransferProtocol(); /** * @return TLS configuration object */ - public TlsConfiguration getTlsConfiguration(); + TlsConfiguration getTlsConfiguration(); /** * @return silence time (in milliseconds) - after this time {@link SwitchIdleEvent} message is sent upstream */ - public long getSwitchIdleTimeout(); + long getSwitchIdleTimeout(); /** * @return seed for {@link SSLEngine} */ - public Object getSslContext(); + Object getSslContext(); /** * @return thread numbers for TcpHandler's eventloopGroups */ - public ThreadConfiguration getThreadConfiguration(); + ThreadConfiguration getThreadConfiguration(); } \ No newline at end of file diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/ConnectionReadyListener.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/ConnectionReadyListener.java index 55152fb7..0c7e026d 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/ConnectionReadyListener.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/ConnectionReadyListener.java @@ -17,5 +17,5 @@ public interface ConnectionReadyListener { /** * fired when connection becomes ready-to-use */ - public void onConnectionReady(); + void onConnectionReady(); } diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/SwitchConnectionHandler.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/SwitchConnectionHandler.java index 82dd0f0e..c5f26fc1 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/SwitchConnectionHandler.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/SwitchConnectionHandler.java @@ -21,12 +21,12 @@ public interface SwitchConnectionHandler { /** * @param connection to switch proving message sending/receiving, connection management */ - public void onSwitchConnected(ConnectionAdapter connection); + void onSwitchConnected(ConnectionAdapter connection); /** * @param switchAddress * @return true, if connection from switch having given address shell be accepted; false otherwise */ - public boolean accept(InetAddress switchAddress); + boolean accept(InetAddress switchAddress); } diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/ThreadConfiguration.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/ThreadConfiguration.java index 6ce39ee3..89dae4a2 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/ThreadConfiguration.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/ThreadConfiguration.java @@ -17,10 +17,10 @@ public interface ThreadConfiguration { /** * @return desired number of workerThreads processing the Openflow I/O */ - public int getWorkerThreadCount(); + int getWorkerThreadCount(); /** * @return desired number of bossThreads registering incomming Openflow connections */ - public int getBossThreadCount(); + int getBossThreadCount(); } diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/TlsConfiguration.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/TlsConfiguration.java index 00e1a410..fde44efb 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/TlsConfiguration.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/connection/TlsConfiguration.java @@ -21,45 +21,45 @@ public interface TlsConfiguration { /** * @return keystore location */ - public String getTlsKeystore(); + String getTlsKeystore(); /** * @return keystore type */ - public KeystoreType getTlsKeystoreType(); + KeystoreType getTlsKeystoreType(); /** * @return truststore location */ - public String getTlsTruststore(); + String getTlsTruststore(); /** * @return truststore type */ - public KeystoreType getTlsTruststoreType(); + KeystoreType getTlsTruststoreType(); /** * @return keystore path type (CLASSPATH or PATH) */ - public PathType getTlsKeystorePathType(); + PathType getTlsKeystorePathType(); /** * @return truststore path type (CLASSPATH or PATH) */ - public PathType getTlsTruststorePathType(); + PathType getTlsTruststorePathType(); /** * @return password protecting specified keystore */ - public String getKeystorePassword(); + String getKeystorePassword(); /** * @return password protecting certificate */ - public String getCertificatePassword(); + String getCertificatePassword(); /** * @return password protecting specified truststore */ - public String getTruststorePassword(); + String getTruststorePassword(); } diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/DeserializerExtensionProvider.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/DeserializerExtensionProvider.java index 30da38c6..0fd529db 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/DeserializerExtensionProvider.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/DeserializerExtensionProvider.java @@ -40,14 +40,14 @@ public interface DeserializerExtensionProvider { * @return true if deserializer was removed, * false if no deserializer was found under specified key */ - public boolean unregisterDeserializer(ExperimenterDeserializerKey key); + boolean unregisterDeserializer(ExperimenterDeserializerKey key); /** * Registers action deserializer * @param key used for deserializer lookup * @param deserializer deserializer instance */ - public void registerActionDeserializer(ExperimenterActionDeserializerKey key, + void registerActionDeserializer(ExperimenterActionDeserializerKey key, OFGeneralDeserializer deserializer); /** @@ -55,7 +55,7 @@ public interface DeserializerExtensionProvider { * @param key used for deserializer lookup * @param deserializer deserializer instance */ - public void registerInstructionDeserializer(ExperimenterInstructionDeserializerKey key, + void registerInstructionDeserializer(ExperimenterInstructionDeserializerKey key, OFGeneralDeserializer deserializer); /** @@ -63,7 +63,7 @@ public interface DeserializerExtensionProvider { * @param key used for deserializer lookup * @param deserializer deserializer instance */ - public void registerMatchEntryDeserializer(MatchEntryDeserializerKey key, + void registerMatchEntryDeserializer(MatchEntryDeserializerKey key, OFGeneralDeserializer deserializer); /** diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/DeserializerRegistry.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/DeserializerRegistry.java index eeeac0a4..646f4e08 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/DeserializerRegistry.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/DeserializerRegistry.java @@ -17,13 +17,13 @@ public interface DeserializerRegistry { /** * Initializes deserializers */ - public void init(); + void init(); /** * @param key used for deserializer lookup * @return deserializer found */ - public + SERIALIZERTYPE getDeserializer(MessageCodeKey key); /** @@ -37,7 +37,7 @@ public interface DeserializerRegistry { * @param key used for deserializer lookup * @param deserializer deserializer instance */ - public void registerDeserializer(MessageCodeKey key, + void registerDeserializer(MessageCodeKey key, OFGeneralDeserializer deserializer); /** @@ -47,5 +47,5 @@ public interface DeserializerRegistry { * @return true if deserializer was removed, * false if no deserializer was found under specified key */ - public boolean unregisterDeserializer(MessageCodeKey key); + boolean unregisterDeserializer(MessageCodeKey key); } diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/DeserializerRegistryInjector.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/DeserializerRegistryInjector.java index 5f029a2d..662ac802 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/DeserializerRegistryInjector.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/DeserializerRegistryInjector.java @@ -17,5 +17,5 @@ public interface DeserializerRegistryInjector { * Injects deserializer registry into deserializer * @param deserializerRegistry */ - public void injectDeserializerRegistry(DeserializerRegistry deserializerRegistry); + void injectDeserializerRegistry(DeserializerRegistry deserializerRegistry); } diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/HeaderDeserializer.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/HeaderDeserializer.java index 205c7692..594f3d02 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/HeaderDeserializer.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/HeaderDeserializer.java @@ -23,5 +23,5 @@ public interface HeaderDeserializer extends OFGeneralDeser * @param rawMessage message as bytes in ByteBuf * @return POJO/DTO */ - public E deserializeHeader(ByteBuf rawMessage); + E deserializeHeader(ByteBuf rawMessage); } diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/HeaderSerializer.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/HeaderSerializer.java index 3392f817..cd8cf038 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/HeaderSerializer.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/HeaderSerializer.java @@ -23,5 +23,5 @@ public interface HeaderSerializer extends OF * @param input object whose headers should be serialized * @param outBuffer output buffer */ - public void serializeHeader(SERIALIZER_TYPE input, ByteBuf outBuffer); + void serializeHeader(SERIALIZER_TYPE input, ByteBuf outBuffer); } diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/OFDeserializer.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/OFDeserializer.java index a514e00f..25a04ac3 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/OFDeserializer.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/OFDeserializer.java @@ -26,5 +26,5 @@ public interface OFDeserializer extends OFGeneralDeseriali * @param message message as bytes in ByteBuf * @return POJO/DTO */ - public E deserialize(ByteBuf message); + E deserialize(ByteBuf message); } diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/OFSerializer.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/OFSerializer.java index 2572a6f2..ad463f45 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/OFSerializer.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/OFSerializer.java @@ -25,6 +25,6 @@ public interface OFSerializer extends OFGen * @param input object to be serialized * @param outBuffer output buffer */ - public void serialize(SERIALIZER_TYPE input, ByteBuf outBuffer); + void serialize(SERIALIZER_TYPE input, ByteBuf outBuffer); } diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerExtensionProvider.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerExtensionProvider.java index 9bbc85c3..f658f5f1 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerExtensionProvider.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerExtensionProvider.java @@ -40,14 +40,14 @@ public interface SerializerExtensionProvider { * @return true if serializer was removed, * false if no serializer was found under specified key */ - public boolean unregisterSerializer(ExperimenterSerializerKey key); + boolean unregisterSerializer(ExperimenterSerializerKey key); /** * Registers action serializer * @param key used for serializer lookup * @param serializer serializer implementation */ - public void registerActionSerializer(ExperimenterActionSerializerKey key, + void registerActionSerializer(ExperimenterActionSerializerKey key, OFGeneralSerializer serializer); /** @@ -55,7 +55,7 @@ public interface SerializerExtensionProvider { * @param key used for serializer lookup * @param serializer serializer implementation */ - public void registerInstructionSerializer(ExperimenterInstructionSerializerKey key, + void registerInstructionSerializer(ExperimenterInstructionSerializerKey key, OFGeneralSerializer serializer); /** @@ -63,7 +63,7 @@ public interface SerializerExtensionProvider { * @param key used for serializer lookup * @param serializer serializer implementation */ - public void registerMatchEntrySerializer( + void registerMatchEntrySerializer( MatchEntrySerializerKey key,OFGeneralSerializer serializer); /** @@ -71,7 +71,7 @@ public interface SerializerExtensionProvider { * @param key used for serializer lookup * @param serializer serializer implementation */ - public void registerExperimenterMessageSerializer(ExperimenterIdSerializerKey key, + void registerExperimenterMessageSerializer(ExperimenterIdSerializerKey key, OFSerializer serializer); /** @@ -79,7 +79,7 @@ public interface SerializerExtensionProvider { * @param key used for serializer lookup * @param serializer serializer implementation */ - public void registerMultipartRequestSerializer(ExperimenterIdSerializerKey key, + void registerMultipartRequestSerializer(ExperimenterIdSerializerKey key, OFSerializer serializer); /** @@ -87,7 +87,7 @@ public interface SerializerExtensionProvider { * @param key used for serializer lookup * @param serializer serializer implementation */ - public void registerMultipartRequestTFSerializer(ExperimenterIdSerializerKey key, + void registerMultipartRequestTFSerializer(ExperimenterIdSerializerKey key, OFGeneralSerializer serializer); /** @@ -95,6 +95,6 @@ public interface SerializerExtensionProvider { * @param key used for serializer lookup * @param serializer serializer implementation */ - public void registerMeterBandSerializer(ExperimenterIdSerializerKey key, + void registerMeterBandSerializer(ExperimenterIdSerializerKey key, OFSerializer serializer); } \ No newline at end of file diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerRegistry.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerRegistry.java index a53faa5c..c0590140 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerRegistry.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerRegistry.java @@ -26,7 +26,7 @@ public interface SerializerRegistry { * @param msgTypeKey lookup key * @return serializer or NullPointerException if no serializer was found */ - public SERIALIZERTYPE + SERIALIZERTYPE getSerializer(MessageTypeKey msgTypeKey); /** @@ -40,7 +40,7 @@ public interface SerializerRegistry { * @param key used for serializer lookup * @param serializer serializer implementation */ - public void registerSerializer(MessageTypeKey key, + void registerSerializer(MessageTypeKey key, OFGeneralSerializer serializer); /** @@ -50,5 +50,5 @@ public interface SerializerRegistry { * @return true if serializer was removed, * false if no serializer was found under specified key */ - public boolean unregisterSerializer(MessageTypeKey key); + boolean unregisterSerializer(MessageTypeKey key); } diff --git a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerRegistryInjector.java b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerRegistryInjector.java index 260c2cc4..1204055e 100644 --- a/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerRegistryInjector.java +++ b/openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/extensibility/SerializerRegistryInjector.java @@ -17,6 +17,6 @@ public interface SerializerRegistryInjector { * Injects serializer registry * @param serializerRegistry registry instance */ - public void injectSerializerRegistry(SerializerRegistry serializerRegistry); + void injectSerializerRegistry(SerializerRegistry serializerRegistry); } diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ConnectionAdapterFactory.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ConnectionAdapterFactory.java index dba298b7..cf4e83f0 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ConnectionAdapterFactory.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ConnectionAdapterFactory.java @@ -23,6 +23,6 @@ public interface ConnectionAdapterFactory { * @param ch * @return connection adapter tcp-implementation */ - public ConnectionFacade createConnectionFacade(Channel ch, InetSocketAddress address) ; + ConnectionFacade createConnectionFacade(Channel ch, InetSocketAddress address) ; } diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/MessageConsumer.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/MessageConsumer.java index fe833311..81c1796e 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/MessageConsumer.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/MessageConsumer.java @@ -19,6 +19,6 @@ public interface MessageConsumer { /** * @param message to process */ - public void consume(DataObject message); + void consume(DataObject message); } diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/OnlineProvider.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/OnlineProvider.java index e828d9ae..01207ec6 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/OnlineProvider.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/OnlineProvider.java @@ -19,6 +19,6 @@ public interface OnlineProvider { /** * @return the isOnlineFuture */ - public ListenableFuture getIsOnlineFuture(); + ListenableFuture getIsOnlineFuture(); } diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ServerFacade.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ServerFacade.java index 39a6eb7e..4759b657 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ServerFacade.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ServerFacade.java @@ -20,5 +20,5 @@ public interface ServerFacade extends ShutdownProvider, OnlineProvider, Runnable * Sets thread configuration * @param threadConfig desired thread configuration */ - public void setThreadConfig(ThreadConfiguration threadConfig); + void setThreadConfig(ThreadConfiguration threadConfig); } diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ShutdownProvider.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ShutdownProvider.java index 21870cc4..facecb9f 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ShutdownProvider.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/connection/ShutdownProvider.java @@ -20,6 +20,6 @@ public interface ShutdownProvider { /** * @return shutdown future */ - public ListenableFuture shutdown(); + ListenableFuture shutdown(); } diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/CodeKeyMaker.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/CodeKeyMaker.java index bd5fff2a..52c2a4de 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/CodeKeyMaker.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/CodeKeyMaker.java @@ -21,6 +21,6 @@ public interface CodeKeyMaker { * @param input buffer that will be the needed data gathered from * @return key for deserializer lookup */ - public abstract MessageCodeKey make(ByteBuf input); + abstract MessageCodeKey make(ByteBuf input); } diff --git a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/TypeKeyMaker.java b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/TypeKeyMaker.java index 4e17dfcd..a9dab19e 100644 --- a/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/TypeKeyMaker.java +++ b/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/TypeKeyMaker.java @@ -21,6 +21,6 @@ public interface TypeKeyMaker { * @return key that will be used for serializer lookup in * the serializer registry */ - public abstract MessageTypeKey make(T entry); + abstract MessageTypeKey make(T entry); } diff --git a/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ClientEvent.java b/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ClientEvent.java index 39b86460..8538d7ba 100644 --- a/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ClientEvent.java +++ b/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/ClientEvent.java @@ -19,5 +19,5 @@ public interface ClientEvent { * Common method for triggering events * @return true if event executed successfully */ - public boolean eventExecuted(); + boolean eventExecuted(); } diff --git a/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/OFClient.java b/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/OFClient.java index f7b4bafa..0d4046ef 100644 --- a/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/OFClient.java +++ b/simple-client/src/main/java/org/opendaylight/openflowjava/protocol/impl/clients/OFClient.java @@ -20,21 +20,21 @@ public interface OFClient extends Runnable { /** * @return the isOnlineFuture which is set when client is started */ - public SettableFuture getIsOnlineFuture(); + SettableFuture getIsOnlineFuture(); /** * @return the scenarioDone when scenario is successfully finished */ - public SettableFuture getScenarioDone(); + SettableFuture getScenarioDone(); /** * @param scenario list of desired actions */ - public void setScenarioHandler(ScenarioHandler scenario); + void setScenarioHandler(ScenarioHandler scenario); /** * @param securedClient true is client should use encrypted communication, * false otherwise */ - public void setSecuredClient(boolean securedClient); + void setSecuredClient(boolean securedClient); } \ No newline at end of file -- 2.36.6