From 6251dfa737d5dd2a99117c61eba1ec7eef90fa0d Mon Sep 17 00:00:00 2001
From: Iveta Halanova <iveta.halanova@pantheon.sk>
Date: Wed, 27 May 2015 13:28:38 +0200
Subject: [PATCH] Sonar method complexity issue

Method: validateMonitoringMetrics
Extracted switch into private method insertObject

Change-Id: I3d129957dc245e4e3a117f10c0177cb1a1be8f99
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
---
 .../protocol/pcep/impl/spi/Util.java          | 42 +++++++++----------
 1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/spi/Util.java b/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/spi/Util.java
index 54dcb0751f..62bc03c892 100644
--- a/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/spi/Util.java
+++ b/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/spi/Util.java
@@ -50,6 +50,26 @@ public final class Util {
         }
     }
 
+    private static State insertObject(final MetricPceBuilder metricPceBuilder, final State state, final Object obj) {
+        switch(state) {
+        case START :
+            if (obj instanceof ProcTime) {
+                metricPceBuilder.setProcTime((ProcTime) obj);
+                return State.PROC_TIME;
+            }
+        case PROC_TIME :
+            if (obj instanceof Overload) {
+                metricPceBuilder.setOverload((Overload) obj);
+                return State.OVERLOAD;
+            }
+        case OVERLOAD :
+        case END :
+            return State.END;
+        default:
+            return state;
+        }
+    }
+
     public static MetricPce validateMonitoringMetrics(final List<Object> objects) throws PCEPDeserializerException {
         final MetricPceBuilder metricPceBuilder = new MetricPceBuilder();
         if (!(objects.get(0) instanceof PceId)) {
@@ -60,27 +80,7 @@ public final class Util {
         State state = State.START;
         while (!objects.isEmpty() && !state.equals(State.END)) {
             final Object obj = objects.get(0);
-            switch(state) {
-            case START :
-                state = State.PROC_TIME;
-                if (obj instanceof ProcTime) {
-                    metricPceBuilder.setProcTime((ProcTime) obj);
-                    break;
-                }
-            case PROC_TIME :
-                state = State.OVERLOAD;
-                if (obj instanceof Overload) {
-                    metricPceBuilder.setOverload((Overload) obj);
-                    break;
-                }
-            case OVERLOAD :
-                state = State.END;
-                break;
-            case END :
-                break;
-            default:
-                break;
-            }
+            state = insertObject(metricPceBuilder, state, obj);
             if (!state.equals(State.END)) {
                 objects.remove(0);
             }
-- 
2.36.6