From 67a02d8938146cd216b9e34919e34fa254d62910 Mon Sep 17 00:00:00 2001 From: Martin Ciglan Date: Tue, 28 Mar 2017 13:12:08 +0200 Subject: [PATCH] BindingDOMRpcImplementationAdapter code clean-up - warnings - package-private access - typo - white-spaces Change-Id: I78f73f503d1f5570b9776f19ce5e0ef88750afad Signed-off-by: Martin Ciglan --- .../adapter/BindingDOMRpcImplementationAdapter.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMRpcImplementationAdapter.java b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMRpcImplementationAdapter.java index 095302941a..5ebf65632f 100644 --- a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMRpcImplementationAdapter.java +++ b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMRpcImplementationAdapter.java @@ -18,6 +18,7 @@ import java.util.HashMap; import java.util.Map; import java.util.Map.Entry; import java.util.concurrent.ExecutionException; +import javax.annotation.Nonnull; import org.opendaylight.mdsal.dom.api.DOMRpcException; import org.opendaylight.mdsal.dom.api.DOMRpcIdentifier; import org.opendaylight.mdsal.dom.api.DOMRpcImplementation; @@ -45,7 +46,7 @@ public class BindingDOMRpcImplementationAdapter implements DOMRpcImplementation private final RpcService delegate; private final QName inputQname; - public BindingDOMRpcImplementationAdapter(final BindingNormalizedNodeCodecRegistry codec, + BindingDOMRpcImplementationAdapter(final BindingNormalizedNodeCodecRegistry codec, final Class type, final Map localNameToMethod, final T delegate) { try { this.invoker = SERVICE_INVOKERS.get(type, () -> { @@ -65,12 +66,14 @@ public class BindingDOMRpcImplementationAdapter implements DOMRpcImplementation inputQname = QName.create(BindingReflections.getQNameModule(type), "input").intern(); } + @Nonnull @Override - public CheckedFuture invokeRpc(final DOMRpcIdentifier rpc, + public CheckedFuture invokeRpc(@Nonnull final DOMRpcIdentifier rpc, final NormalizedNode input) { + final SchemaPath schemaPath = rpc.getType(); - final DataObject bindingInput = input != null ? deserilialize(rpc.getType(),input) : null; - final ListenableFuture> bindingResult = invoke(schemaPath,bindingInput); + final DataObject bindingInput = input != null ? deserialize(rpc.getType(), input) : null; + final ListenableFuture> bindingResult = invoke(schemaPath, bindingInput); return transformResult(bindingResult); } @@ -79,7 +82,7 @@ public class BindingDOMRpcImplementationAdapter implements DOMRpcImplementation return COST; } - private DataObject deserilialize(final SchemaPath rpcPath, final NormalizedNode input) { + private DataObject deserialize(final SchemaPath rpcPath, final NormalizedNode input) { if (input instanceof LazySerializedContainerNode) { return ((LazySerializedContainerNode) input).bindingData(); } -- 2.36.6