From 6d010052210376b4c794a527d52b7a8e35848969 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Fri, 29 Nov 2013 12:12:04 +0100 Subject: [PATCH] Remove modifiers to keep sonar happy Change-Id: I2e91cf0f3134b1429d08c2a822bd53c5ffe9847d Signed-off-by: Robert Varga --- .../protocol/bgp/parser/BGPSession.java | 2 +- .../bgp/parser/spi/AddressFamilyRegistry.java | 4 ++-- .../bgp/parser/spi/AttributeParser.java | 2 +- .../bgp/parser/spi/AttributeRegistry.java | 4 ++-- .../bgp/parser/spi/AttributeSerializer.java | 2 +- .../spi/BGPExtensionConsumerActivator.java | 4 ++-- .../spi/BGPExtensionConsumerContext.java | 14 +++++------ .../spi/BGPExtensionProviderActivator.java | 4 ++-- .../spi/BGPExtensionProviderContext.java | 24 +++++++++---------- .../bgp/parser/spi/CapabilityParser.java | 2 +- .../bgp/parser/spi/CapabilityRegistry.java | 4 ++-- .../bgp/parser/spi/CapabilitySerializer.java | 2 +- .../bgp/parser/spi/MessageParser.java | 2 +- .../bgp/parser/spi/MessageRegistry.java | 4 ++-- .../bgp/parser/spi/MessageSerializer.java | 2 +- .../protocol/bgp/parser/spi/NlriParser.java | 4 ++-- .../protocol/bgp/parser/spi/NlriRegistry.java | 5 ++-- .../bgp/parser/spi/NlriSerializer.java | 2 +- .../bgp/parser/spi/ParameterParser.java | 2 +- .../bgp/parser/spi/ParameterRegistry.java | 4 ++-- .../bgp/parser/spi/ParameterSerializer.java | 2 +- .../spi/SubsequentAddressFamilyRegistry.java | 4 ++-- .../framework/AbstractDispatcher.java | 2 +- .../protocol/framework/ProtocolSession.java | 2 +- .../protocol/framework/ReconnectStrategy.java | 6 ++--- .../framework/ReconnectStrategyFactory.java | 2 +- .../protocol/framework/SessionListener.java | 8 +++---- .../protocol/framework/TerminationReason.java | 2 +- 28 files changed, 60 insertions(+), 61 deletions(-) diff --git a/bgp/parser-api/src/main/java/org/opendaylight/protocol/bgp/parser/BGPSession.java b/bgp/parser-api/src/main/java/org/opendaylight/protocol/bgp/parser/BGPSession.java index b5f2ec6dd9..ace160c813 100644 --- a/bgp/parser-api/src/main/java/org/opendaylight/protocol/bgp/parser/BGPSession.java +++ b/bgp/parser-api/src/main/java/org/opendaylight/protocol/bgp/parser/BGPSession.java @@ -22,5 +22,5 @@ import org.opendaylight.yangtools.yang.binding.Notification; */ public interface BGPSession extends ProtocolSession { - public Set getAdvertisedTableTypes(); + Set getAdvertisedTableTypes(); } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AddressFamilyRegistry.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AddressFamilyRegistry.java index 105444ba9d..306e17320b 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AddressFamilyRegistry.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AddressFamilyRegistry.java @@ -10,6 +10,6 @@ package org.opendaylight.protocol.bgp.parser.spi; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.AddressFamily; public interface AddressFamilyRegistry { - public Class classForFamily(int number); - public Integer numberForClass(Class clazz); + Class classForFamily(int number); + Integer numberForClass(Class clazz); } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeParser.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeParser.java index e50c4ed33a..71b7ac6f12 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeParser.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeParser.java @@ -12,5 +12,5 @@ import org.opendaylight.protocol.bgp.parser.BGPParsingException; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.update.PathAttributesBuilder; public interface AttributeParser { - public void parseAttribute(final byte[] bytes, PathAttributesBuilder builder) throws BGPDocumentedException, BGPParsingException; + void parseAttribute(final byte[] bytes, PathAttributesBuilder builder) throws BGPDocumentedException, BGPParsingException; } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeRegistry.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeRegistry.java index 31efdef59e..0cff08e207 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeRegistry.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeRegistry.java @@ -13,6 +13,6 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.mess import org.opendaylight.yangtools.yang.binding.DataObject; public interface AttributeRegistry { - public PathAttributes parseAttributes(final byte[] bytes) throws BGPDocumentedException, BGPParsingException; - public byte[] serializeAttribute(DataObject attribute); + PathAttributes parseAttributes(byte[] bytes) throws BGPDocumentedException, BGPParsingException; + byte[] serializeAttribute(DataObject attribute); } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeSerializer.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeSerializer.java index 377c03b144..8637f809fd 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeSerializer.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AttributeSerializer.java @@ -10,5 +10,5 @@ package org.opendaylight.protocol.bgp.parser.spi; import org.opendaylight.yangtools.yang.binding.DataObject; public interface AttributeSerializer { - public byte[] serializeAttribute(final DataObject attribute); + byte[] serializeAttribute(final DataObject attribute); } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionConsumerActivator.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionConsumerActivator.java index 29fcdae40f..882832d86e 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionConsumerActivator.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionConsumerActivator.java @@ -8,6 +8,6 @@ package org.opendaylight.protocol.bgp.parser.spi; public interface BGPExtensionConsumerActivator { - public void start(BGPExtensionConsumerContext context) throws Exception; - public void stop() throws Exception; + void start(BGPExtensionConsumerContext context) throws Exception; + void stop() throws Exception; } \ No newline at end of file diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionConsumerContext.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionConsumerContext.java index 94d09d54ac..08d2308835 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionConsumerContext.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionConsumerContext.java @@ -8,11 +8,11 @@ package org.opendaylight.protocol.bgp.parser.spi; public interface BGPExtensionConsumerContext { - public AddressFamilyRegistry getAddressFamilyRegistry(); - public AttributeRegistry getAttributeRegistry(); - public CapabilityRegistry getCapabilityRegistry(); - public MessageRegistry getMessageRegistry(); - public NlriRegistry getNlriRegistry(); - public ParameterRegistry getParameterRegistry(); - public SubsequentAddressFamilyRegistry getSubsequentAddressFamilyRegistry(); + AddressFamilyRegistry getAddressFamilyRegistry(); + AttributeRegistry getAttributeRegistry(); + CapabilityRegistry getCapabilityRegistry(); + MessageRegistry getMessageRegistry(); + NlriRegistry getNlriRegistry(); + ParameterRegistry getParameterRegistry(); + SubsequentAddressFamilyRegistry getSubsequentAddressFamilyRegistry(); } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionProviderActivator.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionProviderActivator.java index bc4a177b1c..d397746ce6 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionProviderActivator.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionProviderActivator.java @@ -8,6 +8,6 @@ package org.opendaylight.protocol.bgp.parser.spi; public interface BGPExtensionProviderActivator { - public void start(BGPExtensionProviderContext context); - public void stop(); + void start(BGPExtensionProviderContext context); + void stop(); } \ No newline at end of file diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionProviderContext.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionProviderContext.java index 033232e6a4..bd186afb6d 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionProviderContext.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/BGPExtensionProviderContext.java @@ -15,21 +15,21 @@ import org.opendaylight.yangtools.yang.binding.DataObject; import org.opendaylight.yangtools.yang.binding.Notification; public interface BGPExtensionProviderContext extends BGPExtensionConsumerContext { - public AutoCloseable registerAddressFamily(Class clazz, int number); - public AutoCloseable registerSubsequentAddressFamily(Class clazz, int number); + AutoCloseable registerAddressFamily(Class clazz, int number); + AutoCloseable registerSubsequentAddressFamily(Class clazz, int number); - public AutoCloseable registerAttributeParser(int attributeType, AttributeParser parser); - public AutoCloseable registerAttributeSerializer(Class attributeClass, AttributeSerializer serializer); + AutoCloseable registerAttributeParser(int attributeType, AttributeParser parser); + AutoCloseable registerAttributeSerializer(Class attributeClass, AttributeSerializer serializer); - public AutoCloseable registerCapabilityParser(int capabilityType, CapabilityParser parser); - public AutoCloseable registerCapabilitySerializer(Class capabilityClass, CapabilitySerializer serializer); + AutoCloseable registerCapabilityParser(int capabilityType, CapabilityParser parser); + AutoCloseable registerCapabilitySerializer(Class capabilityClass, CapabilitySerializer serializer); - public AutoCloseable registerMessageParser(int messageType, MessageParser parser); - public AutoCloseable registerMessageSerializer(Class messageClass, MessageSerializer serializer); + AutoCloseable registerMessageParser(int messageType, MessageParser parser); + AutoCloseable registerMessageSerializer(Class messageClass, MessageSerializer serializer); - public AutoCloseable registerNlriParser(Class afi, Class safi, NlriParser parser); - public AutoCloseable registerNlriSerializer(Class nlriClass, NlriSerializer serializer); + AutoCloseable registerNlriParser(Class afi, Class safi, NlriParser parser); + AutoCloseable registerNlriSerializer(Class nlriClass, NlriSerializer serializer); - public AutoCloseable registerParameterParser(int parameterType, ParameterParser parser); - public AutoCloseable registerParameterSerializer(Class paramClass, ParameterSerializer serializer); + AutoCloseable registerParameterParser(int parameterType, ParameterParser parser); + AutoCloseable registerParameterSerializer(Class paramClass, ParameterSerializer serializer); } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilityParser.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilityParser.java index 3f643ddba3..3726a2984d 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilityParser.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilityParser.java @@ -12,5 +12,5 @@ import org.opendaylight.protocol.bgp.parser.BGPParsingException; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.open.bgp.parameters.CParameters; public interface CapabilityParser { - public CParameters parseCapability(final byte[] bytes) throws BGPDocumentedException, BGPParsingException; + CParameters parseCapability(byte[] bytes) throws BGPDocumentedException, BGPParsingException; } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilityRegistry.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilityRegistry.java index 816ed28cbd..289a19f01c 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilityRegistry.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilityRegistry.java @@ -12,6 +12,6 @@ import org.opendaylight.protocol.bgp.parser.BGPParsingException; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.open.bgp.parameters.CParameters; public interface CapabilityRegistry { - public CParameters parseCapability(final int type, final byte[] bytes) throws BGPDocumentedException, BGPParsingException; - public byte[] serializeCapability(CParameters capability); + CParameters parseCapability(int type, byte[] bytes) throws BGPDocumentedException, BGPParsingException; + byte[] serializeCapability(CParameters capability); } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilitySerializer.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilitySerializer.java index 1d71f1203b..733d484a8e 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilitySerializer.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/CapabilitySerializer.java @@ -10,5 +10,5 @@ package org.opendaylight.protocol.bgp.parser.spi; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.open.bgp.parameters.CParameters; public interface CapabilitySerializer { - public byte[] serializeCapability(final CParameters capability); + byte[] serializeCapability(final CParameters capability); } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageParser.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageParser.java index e9910bcff3..e6b7f2502d 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageParser.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageParser.java @@ -11,5 +11,5 @@ import org.opendaylight.protocol.bgp.parser.BGPDocumentedException; import org.opendaylight.yangtools.yang.binding.Notification; public interface MessageParser { - public Notification parseMessageBody(final byte[] body, final int messageLength) throws BGPDocumentedException; + Notification parseMessageBody(byte[] body, int messageLength) throws BGPDocumentedException; } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageRegistry.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageRegistry.java index d4dd27d62a..adf364314d 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageRegistry.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageRegistry.java @@ -12,6 +12,6 @@ import org.opendaylight.protocol.bgp.parser.BGPParsingException; import org.opendaylight.yangtools.yang.binding.Notification; public interface MessageRegistry { - public Notification parseMessage(final byte[] bytes) throws BGPDocumentedException, BGPParsingException; - public byte[] serializeMessage(Notification message); + Notification parseMessage(byte[] bytes) throws BGPDocumentedException, BGPParsingException; + byte[] serializeMessage(Notification message); } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageSerializer.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageSerializer.java index 3b5cf0f4e7..bf21f742b3 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageSerializer.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/MessageSerializer.java @@ -10,5 +10,5 @@ package org.opendaylight.protocol.bgp.parser.spi; import org.opendaylight.yangtools.yang.binding.Notification; public interface MessageSerializer { - public byte[] serializeMessage(final Notification message); + byte[] serializeMessage(Notification message); } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriParser.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriParser.java index a3bb3d4267..db0c8814cf 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriParser.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriParser.java @@ -12,6 +12,6 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.mult import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.multiprotocol.rev130919.update.path.attributes.MpUnreachNlriBuilder; public interface NlriParser { - public void parseNlri(byte[] nlri, MpUnreachNlriBuilder builder) throws BGPParsingException; - public void parseNlri(byte[] nlri, byte[] nextHop, MpReachNlriBuilder builder) throws BGPParsingException; + void parseNlri(byte[] nlri, MpUnreachNlriBuilder builder) throws BGPParsingException; + void parseNlri(byte[] nlri, byte[] nextHop, MpReachNlriBuilder builder) throws BGPParsingException; } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriRegistry.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriRegistry.java index 208c4b5841..8294bd516a 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriRegistry.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriRegistry.java @@ -12,7 +12,6 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.mult import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.multiprotocol.rev130919.update.path.attributes.MpUnreachNlri; public interface NlriRegistry { - public MpUnreachNlri parseMpUnreach(final byte[] bytes) throws BGPParsingException; - - public MpReachNlri parseMpReach(final byte[] bytes) throws BGPParsingException; + MpReachNlri parseMpReach(final byte[] bytes) throws BGPParsingException; + MpUnreachNlri parseMpUnreach(final byte[] bytes) throws BGPParsingException; } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriSerializer.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriSerializer.java index a9d41db34f..d4bc432c92 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriSerializer.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/NlriSerializer.java @@ -10,5 +10,5 @@ package org.opendaylight.protocol.bgp.parser.spi; import org.opendaylight.yangtools.yang.binding.DataObject; public interface NlriSerializer { - public byte[] serializeAttribute(final DataObject attribute); + byte[] serializeAttribute(DataObject attribute); } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterParser.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterParser.java index c9a0f00d21..32f4c22da8 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterParser.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterParser.java @@ -12,5 +12,5 @@ import org.opendaylight.protocol.bgp.parser.BGPParsingException; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.open.BgpParameters; public interface ParameterParser { - public BgpParameters parseParameter(final byte[] bytes) throws BGPParsingException, BGPDocumentedException; + BgpParameters parseParameter(byte[] bytes) throws BGPParsingException, BGPDocumentedException; } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterRegistry.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterRegistry.java index d42f551fb7..394767b4f8 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterRegistry.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterRegistry.java @@ -12,6 +12,6 @@ import org.opendaylight.protocol.bgp.parser.BGPParsingException; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.open.BgpParameters; public interface ParameterRegistry { - public BgpParameters parseParameter(int parameterType, final byte[] bytes) throws BGPParsingException, BGPDocumentedException; - public byte[] serializeParameter(final BgpParameters parameter); + BgpParameters parseParameter(int parameterType, byte[] bytes) throws BGPParsingException, BGPDocumentedException; + byte[] serializeParameter(BgpParameters parameter); } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterSerializer.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterSerializer.java index 44a75eb2e3..37e8c03b42 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterSerializer.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/ParameterSerializer.java @@ -10,5 +10,5 @@ package org.opendaylight.protocol.bgp.parser.spi; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.open.BgpParameters; public interface ParameterSerializer { - public byte[] serializeParameter(final BgpParameters parameter); + byte[] serializeParameter(BgpParameters parameter); } diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/SubsequentAddressFamilyRegistry.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/SubsequentAddressFamilyRegistry.java index 4d8e9518cf..d08d5994ef 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/SubsequentAddressFamilyRegistry.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/SubsequentAddressFamilyRegistry.java @@ -10,6 +10,6 @@ package org.opendaylight.protocol.bgp.parser.spi; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.SubsequentAddressFamily; public interface SubsequentAddressFamilyRegistry { - public Class classForFamily(int number); - public Integer numberForClass(Class clazz); + Class classForFamily(int number); + Integer numberForClass(Class clazz); } diff --git a/framework/src/main/java/org/opendaylight/protocol/framework/AbstractDispatcher.java b/framework/src/main/java/org/opendaylight/protocol/framework/AbstractDispatcher.java index 93bb4c1809..edc6407767 100644 --- a/framework/src/main/java/org/opendaylight/protocol/framework/AbstractDispatcher.java +++ b/framework/src/main/java/org/opendaylight/protocol/framework/AbstractDispatcher.java @@ -42,7 +42,7 @@ public abstract class AbstractDispatcher, L extends * @param channel whose pipeline should be defined, also to be passed to {@link SessionNegotiatorFactory} * @param promise to be passed to {@link SessionNegotiatorFactory} */ - public void initializeChannel(SocketChannel channel, Promise promise); + void initializeChannel(SocketChannel channel, Promise promise); } diff --git a/framework/src/main/java/org/opendaylight/protocol/framework/ProtocolSession.java b/framework/src/main/java/org/opendaylight/protocol/framework/ProtocolSession.java index c27173dc90..0e45f8a1ab 100644 --- a/framework/src/main/java/org/opendaylight/protocol/framework/ProtocolSession.java +++ b/framework/src/main/java/org/opendaylight/protocol/framework/ProtocolSession.java @@ -19,5 +19,5 @@ import java.io.Closeable; */ public interface ProtocolSession extends Closeable { @Override - public void close(); + void close(); } diff --git a/framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategy.java b/framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategy.java index bbbff39411..b1de4f6943 100644 --- a/framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategy.java +++ b/framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategy.java @@ -31,7 +31,7 @@ public interface ReconnectStrategy { * 0 for infinite (or system-default) timeout * @throws Exception if the connection should not be attempted */ - public int getConnectTimeout() throws Exception; + int getConnectTimeout() throws Exception; /** * Schedule a connection attempt. The precise time when the connection @@ -43,11 +43,11 @@ public interface ReconnectStrategy { * @throws IllegalStateException when a connection attempt is currently * scheduled. */ - public Future scheduleReconnect(Throwable cause); + Future scheduleReconnect(Throwable cause); /** * Reset the strategy state. Users call this method once the reconnection * process succeeds. */ - public void reconnectSuccessful(); + void reconnectSuccessful(); } diff --git a/framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategyFactory.java b/framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategyFactory.java index 010cf67463..bafd3ac480 100644 --- a/framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategyFactory.java +++ b/framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategyFactory.java @@ -18,6 +18,6 @@ public interface ReconnectStrategyFactory { * * @return a new reconnecty strategy */ - public ReconnectStrategy createReconnectStrategy(); + ReconnectStrategy createReconnectStrategy(); } diff --git a/framework/src/main/java/org/opendaylight/protocol/framework/SessionListener.java b/framework/src/main/java/org/opendaylight/protocol/framework/SessionListener.java index 8b49e4e971..2ba0ae5933 100644 --- a/framework/src/main/java/org/opendaylight/protocol/framework/SessionListener.java +++ b/framework/src/main/java/org/opendaylight/protocol/framework/SessionListener.java @@ -20,7 +20,7 @@ public interface SessionListener, T extends Term * * @param remoteParams Peer address families which we accepted */ - public void onSessionUp(S session); + void onSessionUp(S session); /** * Fired when the session went down because of an IO error. Implementation should take care of closing underlying @@ -29,7 +29,7 @@ public interface SessionListener, T extends Term * @param session that went down * @param e Exception that was thrown as the cause of session being down */ - public void onSessionDown(S session, Exception e); + void onSessionDown(S session, Exception e); /** * Fired when the session is terminated locally. The session has already been closed and transitioned to IDLE state. @@ -37,12 +37,12 @@ public interface SessionListener, T extends Term * * @param reason the cause why the session went down */ - public void onSessionTerminated(S session, T reason); + void onSessionTerminated(S session, T reason); /** * Fired when a normal protocol message is received. * * @param message Protocol message */ - public void onMessage(S session, M message); + void onMessage(S session, M message); } diff --git a/framework/src/main/java/org/opendaylight/protocol/framework/TerminationReason.java b/framework/src/main/java/org/opendaylight/protocol/framework/TerminationReason.java index 9f7af5614c..42a524c4ec 100644 --- a/framework/src/main/java/org/opendaylight/protocol/framework/TerminationReason.java +++ b/framework/src/main/java/org/opendaylight/protocol/framework/TerminationReason.java @@ -16,6 +16,6 @@ public interface TerminationReason { * Get cause of session termination. * @return human-readable cause. */ - public String getErrorMessage(); + String getErrorMessage(); } -- 2.36.6