From 7f35a90e650e9ca3a479a08dba2037908e1117b0 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Fri, 18 Jul 2014 00:16:31 +0200 Subject: [PATCH] BUG-865: prune deprecated constructors This patch removes long-deprecated QName constructors in favor of static factory methods. Change-Id: I818cdcd8f1a71a1318c1a688b3594de62581a535 Signed-off-by: Robert Varga --- .../yangtools/yang/common/QName.java | 53 ------------------- .../yangtools/yang/model/util/BaseTypes.java | 2 +- 2 files changed, 1 insertion(+), 54 deletions(-) diff --git a/yang/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/QName.java b/yang/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/QName.java index d2ccf637d7..0ac89ae8da 100644 --- a/yang/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/QName.java +++ b/yang/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/QName.java @@ -117,59 +117,6 @@ public final class QName implements Immutable, Serializable, Comparable { return localName; } - /** - * QName Constructor. - * - * @param namespace - * the namespace assigned to the YANG module - * @param revision - * the revision of the YANG module - * @param localName - * YANG schema identifier - * - * @deprecated Use {@link #create(URI, Date, String)} instead. - */ - @Deprecated - public QName(final URI namespace, final Date revision, final String localName) { - this(QNameModule.create(namespace, revision), null, localName); - } - - /** - * Construct new QName which reuses namespace, revision and prefix from - * base. - * - * @param base - * @param localName - * @deprecated Use {@link #create(QName, String)} instead. - */ - @Deprecated - public QName(final QName base, final String localName) { - this(base.getModule(), base.getPrefix(), localName); - } - - /** - * @deprecated Use {@link #create(String)} instead. This implementation is - * broken. - */ - @Deprecated - public QName(final String input) throws ParseException { - final String nsAndRev = input.substring(input.indexOf("(") + 1, input.indexOf(")")); - final Date revision; - final URI namespace; - if (nsAndRev.contains("?")) { - String[] splitted = nsAndRev.split("\\?"); - namespace = URI.create(splitted[0]); - revision = getRevisionFormat().parse(splitted[1]); - } else { - namespace = URI.create(nsAndRev); - revision = null; - } - - this.localName = checkLocalName(input.substring(input.indexOf(")") + 1)); - this.prefix = null; - this.module = QNameModule.create(namespace, revision); - } - public static QName create(final String input) { Matcher matcher = QNAME_PATTERN_FULL.matcher(input); if (matcher.matches()) { diff --git a/yang/yang-model-util/src/main/java/org/opendaylight/yangtools/yang/model/util/BaseTypes.java b/yang/yang-model-util/src/main/java/org/opendaylight/yangtools/yang/model/util/BaseTypes.java index c4831ef3f2..002746fa57 100644 --- a/yang/yang-model-util/src/main/java/org/opendaylight/yangtools/yang/model/util/BaseTypes.java +++ b/yang/yang-model-util/src/main/java/org/opendaylight/yangtools/yang/model/util/BaseTypes.java @@ -123,7 +123,7 @@ public final class BaseTypes { } final List pathList = new ArrayList(); for (final String path : actualPath) { - final QName qname = new QName(namespace, revision, path); + final QName qname = QName.create(namespace, revision, path); if (qname != null) { pathList.add(qname); } -- 2.36.6