From 7fd2e6471eabd2fb5c01b0694229ea4e7b145b07 Mon Sep 17 00:00:00 2001
From: Robert Varga <robert.varga@pantheon.tech>
Date: Tue, 11 Sep 2018 10:37:47 +0200
Subject: [PATCH] Fix warnings in openconfig support

This fixes warnings reported in openconfig-model-api and
openconfig-parser-support, and enables findbugs enforcement.

Change-Id: I6769c4b4ddb4f4782911619e4d6c177d55f7dccf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---
 yang/openconfig-model-api/pom.xml                      |  7 +++++++
 .../openconfig/model/api/OpenConfigStatements.java     | 10 ----------
 yang/openconfig-parser-support/pom.xml                 |  7 +++++++
 3 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/yang/openconfig-model-api/pom.xml b/yang/openconfig-model-api/pom.xml
index e0eddedd71..faa8fc7f52 100644
--- a/yang/openconfig-model-api/pom.xml
+++ b/yang/openconfig-model-api/pom.xml
@@ -60,6 +60,13 @@
                     <propertyExpansion>checkstyle.violationSeverity=error</propertyExpansion>
                 </configuration>
             </plugin>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>findbugs-maven-plugin</artifactId>
+                <configuration>
+                    <failOnError>true</failOnError>
+                </configuration>
+           </plugin>
         </plugins>
     </build>
 
diff --git a/yang/openconfig-model-api/src/main/java/org/opendaylight/yangtools/openconfig/model/api/OpenConfigStatements.java b/yang/openconfig-model-api/src/main/java/org/opendaylight/yangtools/openconfig/model/api/OpenConfigStatements.java
index 2cef28e0e7..0172cafdcc 100644
--- a/yang/openconfig-model-api/src/main/java/org/opendaylight/yangtools/openconfig/model/api/OpenConfigStatements.java
+++ b/yang/openconfig-model-api/src/main/java/org/opendaylight/yangtools/openconfig/model/api/OpenConfigStatements.java
@@ -40,16 +40,6 @@ public enum OpenConfigStatements implements StatementDefinition {
         this.effectiveRepresentation = requireNonNull(effectiveRepresentation);
     }
 
-    @Nonnull
-    private static QName createQName(final String namespace, final String localName) {
-        return QName.create(namespace, localName).intern();
-    }
-
-    @Nonnull
-    private static QName createQName(final String namespace, final String revision, final String localName) {
-        return QName.create(namespace, revision, localName).intern();
-    }
-
     @Nonnull
     @Override
     public QName getStatementName() {
diff --git a/yang/openconfig-parser-support/pom.xml b/yang/openconfig-parser-support/pom.xml
index 23618b32a5..afeb7d762e 100644
--- a/yang/openconfig-parser-support/pom.xml
+++ b/yang/openconfig-parser-support/pom.xml
@@ -66,6 +66,13 @@
                     <propertyExpansion>checkstyle.violationSeverity=error</propertyExpansion>
                 </configuration>
             </plugin>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>findbugs-maven-plugin</artifactId>
+                <configuration>
+                    <failOnError>true</failOnError>
+                </configuration>
+           </plugin>
         </plugins>
     </build>
 
-- 
2.36.6