From 8c3dac760295503ec53cb2fab0d6e7f750d672d8 Mon Sep 17 00:00:00 2001
From: "guillaume.lambert" <guillaume.lambert@orange.com>
Date: Fri, 13 Dec 2019 15:16:52 +0100
Subject: [PATCH] Remove unchecked warnings from Junit tests

Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1115d54f831001250d94ec5d66232edd21cbda65
---
 .../org/opendaylight/transportpce/olm/stub/MountPointStub.java  | 1 +
 .../opendaylight/transportpce/olm/util/OlmTransactionUtils.java | 1 +
 .../opendaylight/transportpce/olm/util/TransactionUtils.java    | 1 +
 .../opendaylight/transportpce/renderer/stub/MountPointStub.java | 1 +
 .../transportpce/renderer/utils/TransactionUtils.java           | 2 +-
 .../opendaylight/transportpce/tapi/utils/TopologyDataUtils.java | 1 +
 6 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/olm/src/test/java/org/opendaylight/transportpce/olm/stub/MountPointStub.java b/olm/src/test/java/org/opendaylight/transportpce/olm/stub/MountPointStub.java
index 25de9a585..6ba508ed4 100644
--- a/olm/src/test/java/org/opendaylight/transportpce/olm/stub/MountPointStub.java
+++ b/olm/src/test/java/org/opendaylight/transportpce/olm/stub/MountPointStub.java
@@ -32,6 +32,7 @@ public class MountPointStub  implements MountPoint {
     }
 
     @Override
+    @SuppressWarnings("unchecked")
     public <T extends BindingService> Optional<T> getService(Class<T> service) {
         if (service.isInstance(dataBroker)) {
             return Optional.ofNullable((T)dataBroker);
diff --git a/olm/src/test/java/org/opendaylight/transportpce/olm/util/OlmTransactionUtils.java b/olm/src/test/java/org/opendaylight/transportpce/olm/util/OlmTransactionUtils.java
index 812269204..b5dd347c3 100644
--- a/olm/src/test/java/org/opendaylight/transportpce/olm/util/OlmTransactionUtils.java
+++ b/olm/src/test/java/org/opendaylight/transportpce/olm/util/OlmTransactionUtils.java
@@ -72,6 +72,7 @@ public final class OlmTransactionUtils {
     private OlmTransactionUtils() {
     }
 
+    @SuppressWarnings("unchecked")
     public static void writeTransaction(DataBroker dataBroker, InstanceIdentifier instanceIdentifier,
                                         DataObject object) {
         @NonNull
diff --git a/olm/src/test/java/org/opendaylight/transportpce/olm/util/TransactionUtils.java b/olm/src/test/java/org/opendaylight/transportpce/olm/util/TransactionUtils.java
index ea38cd400..d96d880a3 100644
--- a/olm/src/test/java/org/opendaylight/transportpce/olm/util/TransactionUtils.java
+++ b/olm/src/test/java/org/opendaylight/transportpce/olm/util/TransactionUtils.java
@@ -70,6 +70,7 @@ public final class TransactionUtils {
 
     }
 
+    @SuppressWarnings("unchecked")
     public static boolean writeTransaction(DataBroker dataBroker, InstanceIdentifier instanceIdentifier,
         DataObject object) {
         ReadWriteTransaction transaction = dataBroker.newReadWriteTransaction();
diff --git a/renderer/src/test/java/org/opendaylight/transportpce/renderer/stub/MountPointStub.java b/renderer/src/test/java/org/opendaylight/transportpce/renderer/stub/MountPointStub.java
index 0ee8393f8..3a2a38850 100644
--- a/renderer/src/test/java/org/opendaylight/transportpce/renderer/stub/MountPointStub.java
+++ b/renderer/src/test/java/org/opendaylight/transportpce/renderer/stub/MountPointStub.java
@@ -32,6 +32,7 @@ public class MountPointStub  implements MountPoint {
     }
 
     @Override
+    @SuppressWarnings("unchecked")
     public <T extends BindingService> Optional<T> getService(Class<T> service) {
         if (service.isInstance(dataBroker)) {
             return Optional.ofNullable((T)dataBroker);
diff --git a/renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/TransactionUtils.java b/renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/TransactionUtils.java
index 6b68bf1c7..406eece81 100644
--- a/renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/TransactionUtils.java
+++ b/renderer/src/test/java/org/opendaylight/transportpce/renderer/utils/TransactionUtils.java
@@ -24,7 +24,7 @@ public final class TransactionUtils {
 
     }
 
-    @SuppressWarnings("deprecation")
+    @SuppressWarnings({ "unchecked", "deprecation" })
     // deviceTx.put needs the "true" boolean parameter at the end in order to not compromise the Junit test suite
     public static boolean writeTransaction(DeviceTransactionManager deviceTransactionManager,
                                     String nodeId,
diff --git a/tapi/src/test/java/org/opendaylight/transportpce/tapi/utils/TopologyDataUtils.java b/tapi/src/test/java/org/opendaylight/transportpce/tapi/utils/TopologyDataUtils.java
index 53f7e3b38..936ff6f66 100644
--- a/tapi/src/test/java/org/opendaylight/transportpce/tapi/utils/TopologyDataUtils.java
+++ b/tapi/src/test/java/org/opendaylight/transportpce/tapi/utils/TopologyDataUtils.java
@@ -77,6 +77,7 @@ public final class TopologyDataUtils {
         LOG.info("openroadm-topology stored with success in datastore");
     }
 
+    @SuppressWarnings("unchecked")
     private static boolean writeTransaction(DataBroker dataBroker, InstanceIdentifier instanceIdentifier,
         DataObject object) {
         @NonNull
-- 
2.36.6