From 9a0ea242348dc415d2aca4f9fdf68210778ce93d Mon Sep 17 00:00:00 2001
From: Robert Varga <robert.varga@pantheon.tech>
Date: Fri, 11 Mar 2022 14:56:29 +0100
Subject: [PATCH] Do not use blueprint-maven-plugin in topology-manager

Inline the generated container and dist dependencies on annotations
and the plugin.

Change-Id: Idb3905c005a37d2d46ccccc0243c6c77c91d6c86
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---
 applications/topology-manager/pom.xml         | 13 -----------
 .../manager/FlowCapableTopologyProvider.java  |  8 +++----
 .../manager/NodeChangeListenerImpl.java       |  3 +--
 .../topology/manager/OperationProcessor.java  |  3 +--
 .../TerminationPointChangeListenerImpl.java   |  3 +--
 .../src/main/resources/blueprint/autowire.xml | 23 +++++++++++++++++++
 6 files changed, 29 insertions(+), 24 deletions(-)
 create mode 100644 applications/topology-manager/src/main/resources/blueprint/autowire.xml

diff --git a/applications/topology-manager/pom.xml b/applications/topology-manager/pom.xml
index 48d7fb4091..126e7dd7f1 100644
--- a/applications/topology-manager/pom.xml
+++ b/applications/topology-manager/pom.xml
@@ -66,21 +66,8 @@
       <artifactId>javax.annotation-api</artifactId>
       <optional>true</optional>
     </dependency>
-    <dependency>
-      <groupId>org.apache.aries.blueprint</groupId>
-      <artifactId>blueprint-maven-plugin-annotation</artifactId>
-      <optional>true</optional>
-    </dependency>
   </dependencies>
 
-  <build>
-    <plugins>
-      <plugin>
-        <groupId>org.apache.aries.blueprint</groupId>
-        <artifactId>blueprint-maven-plugin</artifactId>
-      </plugin>
-    </plugins>
-  </build>
   <scm>
     <connection>scm:git:ssh://git.opendaylight.org:29418/openflowplugin.git</connection>
     <developerConnection>scm:git:ssh://git.opendaylight.org:29418/openflowplugin.git</developerConnection>
diff --git a/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/FlowCapableTopologyProvider.java b/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/FlowCapableTopologyProvider.java
index 83bcb9f81c..d765949c07 100644
--- a/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/FlowCapableTopologyProvider.java
+++ b/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/FlowCapableTopologyProvider.java
@@ -15,7 +15,6 @@ import javax.annotation.PostConstruct;
 import javax.annotation.PreDestroy;
 import javax.inject.Inject;
 import javax.inject.Singleton;
-import org.apache.aries.blueprint.annotation.service.Reference;
 import org.opendaylight.mdsal.binding.api.DataBroker;
 import org.opendaylight.mdsal.binding.api.NotificationService;
 import org.opendaylight.mdsal.common.api.LogicalDatastoreType;
@@ -51,11 +50,10 @@ public class FlowCapableTopologyProvider implements ClusterSingletonService, Aut
     private ClusterSingletonServiceRegistration singletonServiceRegistration;
 
     @Inject
-    public FlowCapableTopologyProvider(@Reference final DataBroker dataBroker,
-                                       @Reference final NotificationService notificationService,
+    public FlowCapableTopologyProvider(final DataBroker dataBroker,
+                                       final NotificationService notificationService,
                                        final OperationProcessor processor,
-                                       @Reference final ClusterSingletonServiceProvider
-                                               clusterSingletonServiceProvider) {
+                                       final ClusterSingletonServiceProvider clusterSingletonServiceProvider) {
         this.dataBroker = dataBroker;
         this.notificationService = notificationService;
         this.processor = processor;
diff --git a/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/NodeChangeListenerImpl.java b/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/NodeChangeListenerImpl.java
index 9814d1fe8f..18a5766f39 100644
--- a/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/NodeChangeListenerImpl.java
+++ b/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/NodeChangeListenerImpl.java
@@ -11,7 +11,6 @@ import java.util.Collection;
 import javax.annotation.PreDestroy;
 import javax.inject.Inject;
 import javax.inject.Singleton;
-import org.apache.aries.blueprint.annotation.service.Reference;
 import org.opendaylight.mdsal.binding.api.DataBroker;
 import org.opendaylight.mdsal.binding.api.DataTreeModification;
 import org.opendaylight.mdsal.common.api.LogicalDatastoreType;
@@ -31,7 +30,7 @@ public class NodeChangeListenerImpl extends DataTreeChangeListenerImpl<FlowCapab
     private static final Logger LOG = LoggerFactory.getLogger(NodeChangeListenerImpl.class);
 
     @Inject
-    public NodeChangeListenerImpl(@Reference final DataBroker dataBroker, final OperationProcessor operationProcessor) {
+    public NodeChangeListenerImpl(final DataBroker dataBroker, final OperationProcessor operationProcessor) {
         // TODO: listener on FlowCapableNode. what if node id in Node.class is changed (it won't be caught by this
         // listener)
         super(operationProcessor, dataBroker,
diff --git a/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/OperationProcessor.java b/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/OperationProcessor.java
index 3312779c8e..6890544f36 100644
--- a/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/OperationProcessor.java
+++ b/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/OperationProcessor.java
@@ -13,7 +13,6 @@ import javax.annotation.PostConstruct;
 import javax.annotation.PreDestroy;
 import javax.inject.Inject;
 import javax.inject.Singleton;
-import org.apache.aries.blueprint.annotation.service.Reference;
 import org.opendaylight.mdsal.binding.api.DataBroker;
 import org.opendaylight.openflowplugin.common.txchain.TransactionChainManager;
 import org.slf4j.Logger;
@@ -32,7 +31,7 @@ public final class OperationProcessor implements AutoCloseable, Runnable {
     private volatile boolean finishing = false;
 
     @Inject
-    public OperationProcessor(@Reference final DataBroker dataBroker) {
+    public OperationProcessor(final DataBroker dataBroker) {
         transactionChainManager = new TransactionChainManager(dataBroker, TOPOLOGY_MANAGER);
         transactionChainManager.activateTransactionManager();
         transactionChainManager.initialSubmitWriteTransaction();
diff --git a/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/TerminationPointChangeListenerImpl.java b/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/TerminationPointChangeListenerImpl.java
index 16e52aa31a..6b0472e4f2 100644
--- a/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/TerminationPointChangeListenerImpl.java
+++ b/applications/topology-manager/src/main/java/org/opendaylight/openflowplugin/applications/topology/manager/TerminationPointChangeListenerImpl.java
@@ -13,7 +13,6 @@ import java.util.concurrent.ExecutionException;
 import javax.annotation.PreDestroy;
 import javax.inject.Inject;
 import javax.inject.Singleton;
-import org.apache.aries.blueprint.annotation.service.Reference;
 import org.opendaylight.mdsal.binding.api.DataBroker;
 import org.opendaylight.mdsal.binding.api.DataTreeModification;
 import org.opendaylight.mdsal.common.api.LogicalDatastoreType;
@@ -38,7 +37,7 @@ public class TerminationPointChangeListenerImpl extends DataTreeChangeListenerIm
     private static final Logger LOG = LoggerFactory.getLogger(TerminationPointChangeListenerImpl.class);
 
     @Inject
-    public TerminationPointChangeListenerImpl(@Reference final DataBroker dataBroker,
+    public TerminationPointChangeListenerImpl(final DataBroker dataBroker,
                                               final OperationProcessor operationProcessor) {
         super(operationProcessor, dataBroker,
               InstanceIdentifier.builder(Nodes.class).child(Node.class).child(NodeConnector.class)
diff --git a/applications/topology-manager/src/main/resources/blueprint/autowire.xml b/applications/topology-manager/src/main/resources/blueprint/autowire.xml
new file mode 100644
index 0000000000..8a351717c2
--- /dev/null
+++ b/applications/topology-manager/src/main/resources/blueprint/autowire.xml
@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<blueprint xmlns="http://www.osgi.org/xmlns/blueprint/v1.0.0">
+    <bean id="flowCapableTopologyProvider" class="org.opendaylight.openflowplugin.applications.topology.manager.FlowCapableTopologyProvider" init-method="start" destroy-method="close">
+        <argument ref="dataBroker"/>
+        <argument ref="notificationService"/>
+        <argument ref="operationProcessor"/>
+        <argument ref="clusterSingletonServiceProvider"/>
+    </bean>
+    <bean id="nodeChangeListenerImpl" class="org.opendaylight.openflowplugin.applications.topology.manager.NodeChangeListenerImpl" destroy-method="close">
+        <argument ref="dataBroker"/>
+        <argument ref="operationProcessor"/>
+    </bean>
+    <bean id="operationProcessor" class="org.opendaylight.openflowplugin.applications.topology.manager.OperationProcessor" init-method="start" destroy-method="close">
+        <argument ref="dataBroker"/>
+    </bean>
+    <bean id="terminationPointChangeListenerImpl" class="org.opendaylight.openflowplugin.applications.topology.manager.TerminationPointChangeListenerImpl" destroy-method="close">
+        <argument ref="dataBroker"/>
+        <argument ref="operationProcessor"/>
+    </bean>
+    <reference id="dataBroker" interface="org.opendaylight.mdsal.binding.api.DataBroker"/>
+    <reference id="notificationService" interface="org.opendaylight.mdsal.binding.api.NotificationService"/>
+    <reference id="clusterSingletonServiceProvider" interface="org.opendaylight.mdsal.singleton.common.api.ClusterSingletonServiceProvider"/>
+</blueprint>
-- 
2.36.6