From 9d0e430e7f936148bf1fe23744b7190a808f09cc Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Mon, 13 Jul 2020 22:11:22 +0200 Subject: [PATCH] Inline single-use locals We are storing instrumented type in a local, and use that local only once. Just inline the getter to trim down some generator bytecode. Change-Id: Ibfac0c2dc1d294643cbe2619d14e1672314d8bdf Signed-off-by: Robert Varga --- .../binding/dom/codec/impl/CodecDataObjectGenerator.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/CodecDataObjectGenerator.java b/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/CodecDataObjectGenerator.java index c965a087a9..46cd63f35f 100644 --- a/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/CodecDataObjectGenerator.java +++ b/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/CodecDataObjectGenerator.java @@ -451,11 +451,10 @@ abstract class CodecDataObjectGenerator> implements @Override public ByteCodeAppender appender(final Target implementationTarget) { - final TypeDescription instrumentedType = implementationTarget.getInstrumentedType(); return new ByteCodeAppender.Simple( // return (FooType) codecKey(getFoo$$$V); THIS, - getField(instrumentedType, handleName), + getField(implementationTarget.getInstrumentedType(), handleName), CODEC_KEY, TypeCasting.to(retType), MethodReturn.REFERENCE); @@ -525,11 +524,10 @@ abstract class CodecDataObjectGenerator> implements @Override public ByteCodeAppender appender(final Target implementationTarget) { - final TypeDescription instrumentedType = implementationTarget.getInstrumentedType(); return new ByteCodeAppender.Simple( // return (FooType) codecMember(getFoo$$$V, FooType.class); THIS, - getField(instrumentedType, handleName), + getField(implementationTarget.getInstrumentedType(), handleName), ClassConstant.of(TypeDefinition.Sort.describe(bindingClass).asErasure()), CODEC_MEMBER, TypeCasting.to(retType), -- 2.36.6