From 9fc47088ce6e1047d2ab6e44e1512a1371cbf359 Mon Sep 17 00:00:00 2001 From: Thanh Ha Date: Tue, 20 Aug 2019 10:36:09 -0400 Subject: [PATCH] Fix TESTOPTIONS and SUITES variables These variables should not be double quoted as we expect them to expand with spaces. Change-Id: Ifc52c012285a56a6a9f66aff9514ec33714e480e Signed-off-by: Thanh Ha --- jjb/integration/integration-deploy-openstack-run-test.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/jjb/integration/integration-deploy-openstack-run-test.sh b/jjb/integration/integration-deploy-openstack-run-test.sh index c550c7bc6..6569665aa 100644 --- a/jjb/integration/integration-deploy-openstack-run-test.sh +++ b/jjb/integration/integration-deploy-openstack-run-test.sh @@ -1144,6 +1144,8 @@ printf "Stacking elapsed time: %s\n" "${stacktime}" echo "Starting Robot test suites ${SUITES} ..." # please add robot -v arguments on a single line and alphabetized suite_num=0 +# ${TESTOPTIONS}, ${SUITES} are space-separated parameters and should not be quoted. + # shellcheck disable=SC2086 for suite in ${SUITES}; do # prepend an incremental counter to the suite name so that the full robot log combining all the suites as is done # in the rebot step below will list all the suites in chronological order as rebot seems to alphabetize them @@ -1208,7 +1210,7 @@ for suite in ${SUITES}; do -v TOOLS_SYSTEM_3_IP:"${TOOLS_SYSTEM_3_IP}" \ -v USER_HOME:"${HOME}" \ -v WORKSPACE:/tmp \ - "${TESTOPTIONS}" "${suite}" || true + ${TESTOPTIONS} ${suite} || true done #rebot exit codes seem to be different rebot --output "${WORKSPACE}/output.xml" --log log_full.html --report report.html -N openstack output_*.xml || true -- 2.36.6