From a10cb9551ddd43dac64c00fc4d8d55fb10e4011c Mon Sep 17 00:00:00 2001
From: Robert Varga <robert.varga@pantheon.tech>
Date: Tue, 20 Apr 2021 23:40:40 +0200
Subject: [PATCH] Require symbolic name in {IR,YinDom}SchemaSource

Constructors which do not take a symbolic name are making it easy to
forget to come up with a strategy. While a symbolic name is not
required, require callers to be explicit about what they want to use.

JIRA: YANGTOOLS-1275
Change-Id: Ib3c253c3d380968bf54a4590551aec61df61bac9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---
 .../yang/parser/rfc7950/ir/IRSchemaSource.java     |  5 -----
 .../yang/model/repo/api/YinDomSchemaSource.java    | 14 --------------
 2 files changed, 19 deletions(-)

diff --git a/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/ir/IRSchemaSource.java b/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/ir/IRSchemaSource.java
index 96ec99a1d2..8a1257f665 100644
--- a/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/ir/IRSchemaSource.java
+++ b/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/ir/IRSchemaSource.java
@@ -45,11 +45,6 @@ public final class IRSchemaSource extends AbstractSimpleIdentifiable<SourceIdent
         checkArgument(rootStatement.argument() != null, "Root statement does not have an argument");
     }
 
-    @Deprecated(forRemoval = true)
-    public IRSchemaSource(final @NonNull SourceIdentifier identifier, final @NonNull IRStatement rootStatement) {
-        this(identifier, rootStatement, null);
-    }
-
     @Override
     public Optional<String> getSymbolicName() {
         return Optional.ofNullable(symbolicName);
diff --git a/yang/yang-repo-api/src/main/java/org/opendaylight/yangtools/yang/model/repo/api/YinDomSchemaSource.java b/yang/yang-repo-api/src/main/java/org/opendaylight/yangtools/yang/model/repo/api/YinDomSchemaSource.java
index fb1187f462..bfcae8300e 100644
--- a/yang/yang-repo-api/src/main/java/org/opendaylight/yangtools/yang/model/repo/api/YinDomSchemaSource.java
+++ b/yang/yang-repo-api/src/main/java/org/opendaylight/yangtools/yang/model/repo/api/YinDomSchemaSource.java
@@ -48,20 +48,6 @@ public abstract class YinDomSchemaSource implements YinXmlSchemaSource {
         // Prevent outside instantiation
     }
 
-    /**
-     * Create a new {@link YinDomSchemaSource} using an identifier and a source.
-     *
-     * @param identifier Schema source identifier
-     * @param source W3C DOM source
-     * @return A new {@link YinDomSchemaSource} instance.
-     * @deprecated Use {@link #create(SourceIdentifier, DOMSource, String)} instead.
-     */
-    @Deprecated(forRemoval = true)
-    public static @NonNull YinDomSchemaSource create(final @NonNull SourceIdentifier identifier,
-            final @NonNull DOMSource source) {
-        return create(identifier, source, null);
-    }
-
     /**
      * Create a new {@link YinDomSchemaSource} using an identifier and a source.
      *
-- 
2.36.6