From ac6c032cd860ab50b798ba9a855af698a19e6d12 Mon Sep 17 00:00:00 2001 From: Lori Jakab Date: Tue, 16 Feb 2021 12:12:51 +0100 Subject: [PATCH] Deprecate mappingservice.neutron It has been many releases since this code has been tested against OpenStack, and no one is around to maintain it. Additionally, some architectural concerns were raised in relation to the use of some YANG models in this module. Deprecate in the current release and remove in the next release. Change-Id: I8fe637ff32efb92de6b0f9f99e4c5dcd153a6fe7 Signed-off-by: Lori Jakab --- .../org/opendaylight/lispflowmapping/neutron/DataProcessor.java | 1 + .../lispflowmapping/neutron/DelegatingDataTreeListener.java | 1 + .../lispflowmapping/neutron/ILispNeutronService.java | 1 + .../opendaylight/lispflowmapping/neutron/LispNeutronService.java | 1 + .../lispflowmapping/neutron/NetworkDataProcessor.java | 1 + .../opendaylight/lispflowmapping/neutron/NetworkListener.java | 1 + .../opendaylight/lispflowmapping/neutron/PortDataProcessor.java | 1 + .../org/opendaylight/lispflowmapping/neutron/PortListener.java | 1 + .../lispflowmapping/neutron/SubnetDataProcessor.java | 1 + .../org/opendaylight/lispflowmapping/neutron/SubnetListener.java | 1 + 10 files changed, 10 insertions(+) diff --git a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/DataProcessor.java b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/DataProcessor.java index 16cdccfd3..feefffa2b 100644 --- a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/DataProcessor.java +++ b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/DataProcessor.java @@ -9,6 +9,7 @@ package org.opendaylight.lispflowmapping.neutron; import org.opendaylight.yangtools.yang.binding.DataObject; +@Deprecated public interface DataProcessor { /** diff --git a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/DelegatingDataTreeListener.java b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/DelegatingDataTreeListener.java index ffcd053c3..fafec5342 100644 --- a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/DelegatingDataTreeListener.java +++ b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/DelegatingDataTreeListener.java @@ -23,6 +23,7 @@ import org.opendaylight.yangtools.yang.binding.DataObject; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +@Deprecated public class DelegatingDataTreeListener implements ClusteredDataTreeChangeListener, AutoCloseable { private static final Logger LOG = LoggerFactory.getLogger(DelegatingDataTreeListener.class); diff --git a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/ILispNeutronService.java b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/ILispNeutronService.java index 4c79196e0..c25457e33 100644 --- a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/ILispNeutronService.java +++ b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/ILispNeutronService.java @@ -10,6 +10,7 @@ package org.opendaylight.lispflowmapping.neutron; import org.opendaylight.lispflowmapping.interfaces.lisp.IFlowMapping; import org.opendaylight.yang.gen.v1.urn.opendaylight.lfm.mappingservice.rev150906.OdlMappingserviceService; +@Deprecated public interface ILispNeutronService { IFlowMapping getMappingService(); diff --git a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/LispNeutronService.java b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/LispNeutronService.java index e8f9defcc..f5519d8ba 100644 --- a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/LispNeutronService.java +++ b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/LispNeutronService.java @@ -17,6 +17,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.s import org.slf4j.Logger; import org.slf4j.LoggerFactory; +@Deprecated public class LispNeutronService implements ILispNeutronService { private static final Logger LOG = LoggerFactory.getLogger(LispNeutronService.class); diff --git a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/NetworkDataProcessor.java b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/NetworkDataProcessor.java index 7de315380..ae90db641 100644 --- a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/NetworkDataProcessor.java +++ b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/NetworkDataProcessor.java @@ -14,6 +14,7 @@ import org.slf4j.LoggerFactory; /** * LISP Service Implementation of creation and deletion of a Network. */ +@Deprecated public class NetworkDataProcessor implements DataProcessor { private static final Logger LOG = LoggerFactory.getLogger(NetworkDataProcessor.class); private volatile ILispNeutronService lispNeutronService; diff --git a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/NetworkListener.java b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/NetworkListener.java index bca16ebe4..0beb1522f 100644 --- a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/NetworkListener.java +++ b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/NetworkListener.java @@ -19,6 +19,7 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; * Implementation of a ClusteredDataTreeChangeListener that listens for northbound requests on a {@link Network} * subtree. */ +@Deprecated public class NetworkListener extends DelegatingDataTreeListener { private static final DataTreeIdentifier IDENTIFIER = diff --git a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/PortDataProcessor.java b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/PortDataProcessor.java index a8c38410e..cf594b141 100644 --- a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/PortDataProcessor.java +++ b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/PortDataProcessor.java @@ -29,6 +29,7 @@ import org.slf4j.LoggerFactory; * * @author Vina Ermagan */ +@Deprecated public class PortDataProcessor implements DataProcessor { private static final Logger LOG = LoggerFactory.getLogger(PortDataProcessor.class); diff --git a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/PortListener.java b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/PortListener.java index 723e69621..f08f5207d 100644 --- a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/PortListener.java +++ b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/PortListener.java @@ -18,6 +18,7 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; /** * Implementation of a ClusteredDataTreeChangeListener that listens for northbound requests on a {@link Port} subtree. */ +@Deprecated public class PortListener extends DelegatingDataTreeListener { private static final DataTreeIdentifier IDENTIFIER = diff --git a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/SubnetDataProcessor.java b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/SubnetDataProcessor.java index 13bc0bfb5..a3f763eab 100644 --- a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/SubnetDataProcessor.java +++ b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/SubnetDataProcessor.java @@ -30,6 +30,7 @@ import org.slf4j.LoggerFactory; * @author Vina Ermagan * */ +@Deprecated public class SubnetDataProcessor implements DataProcessor { private static final Logger LOG = LoggerFactory.getLogger(SubnetDataProcessor.class); // private static final Integer SIX = Integer.valueOf(6); diff --git a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/SubnetListener.java b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/SubnetListener.java index 449499559..fe0341086 100644 --- a/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/SubnetListener.java +++ b/mappingservice/neutron/src/main/java/org/opendaylight/lispflowmapping/neutron/SubnetListener.java @@ -18,6 +18,7 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; /** * Implementation of a ClusteredDataTreeChangeListener that listens for northbound requests on a {@link Subnet} subtree. */ +@Deprecated public class SubnetListener extends DelegatingDataTreeListener { private static final DataTreeIdentifier IDENTIFIER = -- 2.36.6