From ada2c265698298bdab0201bb9a2c30af64376a9d Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Tue, 20 Sep 2016 14:59:19 +0200 Subject: [PATCH] Eliminate ShardedDOMDataTreeWriteTransaction.doSubmit()'s return Returned future is not used anywhere, hence we can easily remove it. Change-Id: I4ead4da32d1c2658d5c88f01534b5452230068e7 Signed-off-by: Robert Varga --- .../dom/broker/ShardedDOMDataTreeWriteTransaction.java | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/ShardedDOMDataTreeWriteTransaction.java b/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/ShardedDOMDataTreeWriteTransaction.java index 0e1180ab12..08f359d216 100644 --- a/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/ShardedDOMDataTreeWriteTransaction.java +++ b/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/ShardedDOMDataTreeWriteTransaction.java @@ -122,8 +122,7 @@ final class ShardedDOMDataTreeWriteTransaction implements DOMDataTreeCursorAware return submitFuture; } - CheckedFuture doSubmit( - final Consumer success, + void doSubmit(final Consumer success, final BiConsumer failure) { final ListenableFuture> listListenableFuture = Futures.allAsList( @@ -133,22 +132,17 @@ final class ShardedDOMDataTreeWriteTransaction implements DOMDataTreeCursorAware return tx.submit(); }).collect(Collectors.toList())); - final SettableFuture ret = SettableFuture.create(); Futures.addCallback(listListenableFuture, new FutureCallback>() { @Override public void onSuccess(final List result) { success.accept(ShardedDOMDataTreeWriteTransaction.this); - ret.set(null); } @Override public void onFailure(final Throwable exp) { failure.accept(ShardedDOMDataTreeWriteTransaction.this, exp); - ret.setException(exp); } }); - - return Futures.makeChecked(ret, SUBMIT_FAILED_MAPPER); } void onTransactionSuccess(final Void result) { -- 2.36.6