From b260fb55a235bf4ce5b538515b9a4537ba0c3a6d Mon Sep 17 00:00:00 2001 From: David Date: Fri, 17 Mar 2017 23:09:09 +0100 Subject: [PATCH] Fix minor issues regarding checkstyle - Make BulkOMaticUtils a final class since its constructor is private. - Parenthesis not needed Change-Id: I2e0a58dfe204aec89ab49cb3fbd870229932c317 Signed-off-by: David --- .../bulk/o/matic/BulkOMaticUtils.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/applications/bulk-o-matic/src/main/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/BulkOMaticUtils.java b/applications/bulk-o-matic/src/main/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/BulkOMaticUtils.java index 37f9899546..8c80b15b03 100644 --- a/applications/bulk-o-matic/src/main/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/BulkOMaticUtils.java +++ b/applications/bulk-o-matic/src/main/java/org/opendaylight/openflowplugin/applications/bulk/o/matic/BulkOMaticUtils.java @@ -28,9 +28,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026 import org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; -public class BulkOMaticUtils { - - private BulkOMaticUtils () { } +public final class BulkOMaticUtils { public static final int DEFUALT_STATUS = FlowCounter.OperationStatus.INIT.status(); public static final int DEFAULT_FLOW_COUNT = 0; @@ -38,11 +36,14 @@ public class BulkOMaticUtils { public static final String DEFAULT_UNITS = "ns"; public static final String DEVICE_TYPE_PREFIX = "openflow:"; + private BulkOMaticUtils() { + } + public static String ipIntToStr (int k) { - return new StringBuilder().append(((k >> 24) & 0xFF)).append(".") - .append(((k >> 16) & 0xFF)).append(".") - .append(((k >> 8) & 0xFF)).append(".") - .append((k & 0xFF)).append("/32").toString(); + return new StringBuilder().append(k >> 24 & 0xFF).append(".") + .append(k >> 16 & 0xFF).append(".") + .append(k >> 8 & 0xFF).append(".") + .append(k & 0xFF).append("/32").toString(); } public static Match getMatch(final Integer sourceIp){ @@ -87,7 +88,6 @@ public class BulkOMaticUtils { .augmentation(FlowCapableNode.class) .child(Table.class, new TableKey(tableId)) .build(); - } public static InstanceIdentifier getFlowId(final InstanceIdentifier tablePath, final String flowId) { -- 2.36.6