From b5687b49bd2ca5cf3ab37f35edf518e82395d386 Mon Sep 17 00:00:00 2001
From: Robert Varga <robert.varga@pantheon.tech>
Date: Thu, 28 Apr 2022 20:30:37 +0200
Subject: [PATCH] Ditch Truth from web-jetty-impl

Use JUnit assertions instead.

Change-Id: Id5cc0addd95c0b313c86bc825f128163e7b6aa6e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
---
 web/impl-jetty/pom.xml                        |  5 ----
 .../aaa/web/test/AbstractWebServerTest.java   | 25 ++++++++-----------
 .../opendaylight/aaa/web/test/TestFilter.java |  6 ++---
 3 files changed, 13 insertions(+), 23 deletions(-)

diff --git a/web/impl-jetty/pom.xml b/web/impl-jetty/pom.xml
index 935dff0a6..c7f47d120 100644
--- a/web/impl-jetty/pom.xml
+++ b/web/impl-jetty/pom.xml
@@ -52,10 +52,5 @@
       <artifactId>javax.annotation-api</artifactId>
       <optional>true</optional>
     </dependency>
-
-    <dependency>
-      <groupId>com.google.truth</groupId>
-      <artifactId>truth</artifactId>
-    </dependency>
   </dependencies>
 </project>
diff --git a/web/impl-jetty/src/test/java/org/opendaylight/aaa/web/test/AbstractWebServerTest.java b/web/impl-jetty/src/test/java/org/opendaylight/aaa/web/test/AbstractWebServerTest.java
index 64aca73a5..290734796 100644
--- a/web/impl-jetty/src/test/java/org/opendaylight/aaa/web/test/AbstractWebServerTest.java
+++ b/web/impl-jetty/src/test/java/org/opendaylight/aaa/web/test/AbstractWebServerTest.java
@@ -7,15 +7,16 @@
  */
 package org.opendaylight.aaa.web.test;
 
-import static com.google.common.truth.Truth.assertThat;
-import static java.nio.charset.StandardCharsets.US_ASCII;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
 
 import com.google.common.io.CharStreams;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
 import java.net.URL;
-import java.net.URLConnection;
+import java.nio.charset.StandardCharsets;
 import javax.servlet.ServletException;
 import org.junit.Test;
 import org.opendaylight.aaa.web.FilterDetails;
@@ -64,7 +65,7 @@ public abstract class AbstractWebServerTest {
             .putContextParam("testParam1", "avalue")
             .addFilter(FilterDetails.builder().addUrlPattern("/*").name("Test").filter(testFilter).build());
         WebContextRegistration webContextRegistration = getWebServer().registerWebContext(webContextBuilder.build());
-        assertThat(testFilter.isInitialized).isTrue();
+        assertTrue(testFilter.isInitialized);
         webContextRegistration.close();
     }
 
@@ -73,24 +74,20 @@ public abstract class AbstractWebServerTest {
         WebContextBuilder webContextBuilder = WebContext.builder().contextPath("/testingListener");
         TestListener testListener = new TestListener();
         webContextBuilder.addListener(testListener);
-        assertThat(testListener.isInitialized).isFalse();
+        assertFalse(testListener.isInitialized);
         WebContextRegistration webContextRegistration = getWebServer().registerWebContext(webContextBuilder.build());
-        assertThat(testListener.isInitialized).isTrue();
+        assertTrue(testListener.isInitialized);
         webContextRegistration.close();
-        assertThat(testListener.isInitialized).isFalse();
+        assertFalse(testListener.isInitialized);
     }
 
     static void checkTestServlet(String urlPrefix) throws IOException {
-        URL url = new URL(urlPrefix + "/something");
-        URLConnection conn = url.openConnection();
-        try (InputStream inputStream = conn.getInputStream()) {
+        try (InputStream inputStream = new URL(urlPrefix + "/something").openConnection().getInputStream()) {
             // The hard-coded ASCII here is strictly speaking wrong of course
             // (should interpret header from reply), but good enough for a test.
-            try (InputStreamReader reader = new InputStreamReader(inputStream, US_ASCII)) {
-                String result = CharStreams.toString(reader);
-                assertThat(result).startsWith("hello, world");
+            try (InputStreamReader reader = new InputStreamReader(inputStream, StandardCharsets.US_ASCII)) {
+                assertEquals("hello, world\r\n", CharStreams.toString(reader));
             }
         }
     }
-
 }
diff --git a/web/impl-jetty/src/test/java/org/opendaylight/aaa/web/test/TestFilter.java b/web/impl-jetty/src/test/java/org/opendaylight/aaa/web/test/TestFilter.java
index ddfc38078..8ac6a49dd 100644
--- a/web/impl-jetty/src/test/java/org/opendaylight/aaa/web/test/TestFilter.java
+++ b/web/impl-jetty/src/test/java/org/opendaylight/aaa/web/test/TestFilter.java
@@ -7,7 +7,7 @@
  */
 package org.opendaylight.aaa.web.test;
 
-import static com.google.common.truth.Truth.assertThat;
+import static org.junit.Assert.assertEquals;
 
 import java.io.IOException;
 import javax.servlet.Filter;
@@ -18,12 +18,11 @@ import javax.servlet.ServletRequest;
 import javax.servlet.ServletResponse;
 
 public class TestFilter implements Filter {
-
     public boolean isInitialized = false;
 
     @Override
     public void init(FilterConfig filterConfig) throws ServletException {
-        assertThat(filterConfig.getServletContext().getAttribute("testParam1")).isEqualTo("avalue");
+        assertEquals("avalue", filterConfig.getServletContext().getAttribute("testParam1"));
         isInitialized = true;
     }
 
@@ -36,5 +35,4 @@ public class TestFilter implements Filter {
     @Override
     public void destroy() {
     }
-
 }
-- 
2.36.6