From da603ecd3b0e093bf00ff75d80c0957196d9856d Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Thu, 28 May 2015 02:46:35 +0200 Subject: [PATCH] BUG-1485: deprecate public static range/length methods These methods are not efficient and expose implementation internals. Mark them as deprecated for removal. This mirrors the deprecation in ClassTemplate, which was not instantiated before due to how the code is structured. Change-Id: I7fcb831f00fd3baab02e1f25e10655c8288c6d4e Signed-off-by: Robert Varga --- .../sal/java/api/generator/BuilderTemplate.xtend | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/code-generator/binding-java-api-generator/src/main/java/org/opendaylight/yangtools/sal/java/api/generator/BuilderTemplate.xtend b/code-generator/binding-java-api-generator/src/main/java/org/opendaylight/yangtools/sal/java/api/generator/BuilderTemplate.xtend index 5d3ed13994..b8b8810ae6 100644 --- a/code-generator/binding-java-api-generator/src/main/java/org/opendaylight/yangtools/sal/java/api/generator/BuilderTemplate.xtend +++ b/code-generator/binding-java-api-generator/src/main/java/org/opendaylight/yangtools/sal/java/api/generator/BuilderTemplate.xtend @@ -536,6 +536,10 @@ class BuilderTemplate extends BaseTemplate { «val Restrictions restrictions = type.restrictions» «IF restrictions != null && !(restrictions.lengthConstraints.empty)» «val numberClass = restrictions.lengthConstraints.iterator.next.min.class» + /** + * @deprecated This method is slated for removal in a future release. See BUG-1485 for details. + */ + @Deprecated public static «List.importedName»<«Range.importedName»<«numberClass.importedNumber»>> «methodName»() { «IF numberClass.equals(typeof(BigDecimal))» «lengthBody(restrictions, numberClass, className, varName)» @@ -564,6 +568,10 @@ class BuilderTemplate extends BaseTemplate { def private generateRangeMethod(String methodName, Restrictions restrictions, Type returnType, String className, String varName) ''' «IF restrictions != null && !(restrictions.rangeConstraints.empty)» «val number = returnType.importedNumber» + /** + * @deprecated This method is slated for removal in a future release. See BUG-1485 for details. + */ + @Deprecated public static «List.importedName»<«Range.importedName»<«number»>> «methodName»() { «IF returnType.fullyQualifiedName.equals(BigDecimal.canonicalName)» «rangeBody(restrictions, BigDecimal, className, varName)» -- 2.36.6