From f1f9a839ff6d8d932a0ec9a790cb1e015cb3ed30 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Sun, 14 Feb 2016 23:29:41 +0100 Subject: [PATCH] Remove an unneeded null check instanceof performs a null check, hence we do not have to do it ourselves. Saves a branch. Change-Id: Icb4e29c5adb94a1c971fa8019064324ef1cadbf2 Signed-off-by: Robert Varga --- .../opendaylight/yangtools/util/ConstantArrayCollection.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/common/util/src/main/java/org/opendaylight/yangtools/util/ConstantArrayCollection.java b/common/util/src/main/java/org/opendaylight/yangtools/util/ConstantArrayCollection.java index 8c29d9e0b9..b88a6ef992 100644 --- a/common/util/src/main/java/org/opendaylight/yangtools/util/ConstantArrayCollection.java +++ b/common/util/src/main/java/org/opendaylight/yangtools/util/ConstantArrayCollection.java @@ -145,9 +145,6 @@ final class ConstantArrayCollection implements Collection, Serializable { if (obj == this) { return true; } - if (obj == null) { - return false; - } if (!(obj instanceof ConstantArrayCollection)) { return false; } @@ -161,7 +158,7 @@ final class ConstantArrayCollection implements Collection, Serializable { return "[]"; } - StringBuilder sb = new StringBuilder("["); + final StringBuilder sb = new StringBuilder("["); int i = 0; while (i < array.length - 1) { sb.append(String.valueOf(array[i++])).append(", "); -- 2.36.6