From f374cf3d5fa7d98ba1b4d978607706b89100f100 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Tue, 9 Dec 2014 16:11:48 +0100 Subject: [PATCH] BUG-2475: Do not issue garbage collection on when pushing configurations This gc() call used to make sense when we were running this code as a one-shot initialization (e.g. Hydrogen container). With the Karaf changes, this was moved into a persistent codepath -- which does not make sense at all. Change-Id: I0e3d4a2b674241c80d682630b031fb3517621251 Signed-off-by: Robert Varga --- .../netconf/persist/impl/ConfigPusherImpl.java | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/opendaylight/netconf/config-persister-impl/src/main/java/org/opendaylight/controller/netconf/persist/impl/ConfigPusherImpl.java b/opendaylight/netconf/config-persister-impl/src/main/java/org/opendaylight/controller/netconf/persist/impl/ConfigPusherImpl.java index b06219c978..c20007d397 100644 --- a/opendaylight/netconf/config-persister-impl/src/main/java/org/opendaylight/controller/netconf/persist/impl/ConfigPusherImpl.java +++ b/opendaylight/netconf/config-persister-impl/src/main/java/org/opendaylight/controller/netconf/persist/impl/ConfigPusherImpl.java @@ -78,17 +78,9 @@ public class ConfigPusherImpl implements ConfigPusher { synchronized (autoCloseables) { autoCloseables.add(jmxNotificationHandler); } - /* - * We have completed initial configuration. At this point - * it is good idea to perform garbage collection to prune - * any garbage we have accumulated during startup. - */ - LOG.debug("Running post-initialization garbage collection..."); - System.gc(); - LOG.debug("Post-initialization garbage collection completed."); - LOG.debug("ConfigPusher has pushed configs {}, gc completed", configs); - } - catch (NetconfDocumentedException e) { + + LOG.debug("ConfigPusher has pushed configs {}", configs); + } catch (NetconfDocumentedException e) { LOG.error("Error pushing configs {}",configs); throw new IllegalStateException(e); } -- 2.36.6