From f3bd846001579df6c38b4e71be45ffd52c51d58c Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Mon, 2 Nov 2015 15:21:19 +0100 Subject: [PATCH] Remove a search-before-remove on ArrayList There is no need to make the removal conditional on presence. This forces two linear searches of the list, instead of just one. Change-Id: I3d3fb23ac02e95433cc17ccee119dbb1392cef42 Signed-off-by: Robert Varga --- .../yang/parser/impl/YangStatementParserListenerImpl.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/impl/YangStatementParserListenerImpl.java b/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/impl/YangStatementParserListenerImpl.java index 58aa60c167..95176b1955 100644 --- a/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/impl/YangStatementParserListenerImpl.java +++ b/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/impl/YangStatementParserListenerImpl.java @@ -40,7 +40,7 @@ public class YangStatementParserListenerImpl extends YangStatementParserBaseList private QNameToStatementDefinition stmtDef; private PrefixToModule prefixes; private final List toBeSkipped = new ArrayList<>(); - private boolean isType = false; + private final boolean isType = false; private static final Logger LOG = LoggerFactory.getLogger(YangStatementParserListenerImpl.class); public YangStatementParserListenerImpl(final String sourceName) { @@ -111,9 +111,9 @@ public class YangStatementParserListenerImpl extends YangStatementParserBaseList && toBeSkipped.isEmpty()) { writer.endStatement(ref); } - if (toBeSkipped.contains(statementName)) { - toBeSkipped.remove(statementName); - } + + // No-op if the statement is not on the list + toBeSkipped.remove(statementName); } catch (SourceException e) { LOG.warn(e.getMessage(), e); } -- 2.36.6