From f4bc7b78773fd6ad1d548e771afb90ac0145819c Mon Sep 17 00:00:00 2001 From: Kency Date: Fri, 12 Feb 2016 11:41:33 +0530 Subject: [PATCH] Bug 5199 : Corrected the log messages Change-Id: I8915fa29052b1adf2f3d830798642b929c55d063 Signed-off-by: Kency --- .../vpnservice/dhcpservice/DhcpPktHandler.java | 9 +++++---- .../FlowBasedServicesConfigUnbindHelper.java | 3 +-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/vpnservice/dhcpservice/DhcpPktHandler.java b/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/vpnservice/dhcpservice/DhcpPktHandler.java index 60d8bd72..01e4e99f 100644 --- a/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/vpnservice/dhcpservice/DhcpPktHandler.java +++ b/dhcpservice/dhcpservice-impl/src/main/java/org/opendaylight/vpnservice/dhcpservice/DhcpPktHandler.java @@ -86,7 +86,6 @@ public class DhcpPktHandler implements AutoCloseable, PacketProcessingListener { public void onPacketReceived(PacketReceived packet) { LOG.trace("Pkt received: {}", packet); Class pktInReason = packet.getPacketInReason(); - short tableId = packet.getTableId().getValue(); if (isPktInReasonSendtoCtrl(pktInReason)) { byte[] inPayload = packet.getPayload(); Ethernet ethPkt = new Ethernet(); @@ -110,7 +109,8 @@ public class DhcpPktHandler implements AutoCloseable, PacketProcessingListener { sendPacketOut(pktOut, pair.getLeft(), interfaceName); } } catch (Exception e) { - LOG.warn("Failed to get DHCP Reply {}", e); + LOG.warn("Failed to get DHCP Reply"); + LOG.trace("Reason for failure {}", e); } } } @@ -181,7 +181,7 @@ public class DhcpPktHandler implements AutoCloseable, PacketProcessingListener { private DHCP getDhcpPktIn(Ethernet actualEthernetPacket) { Ethernet ethPkt = actualEthernetPacket; - LOG.trace("Inside getDhcpPktIn ethPkt {} \n getPayload {}", ethPkt, ethPkt.getPayload()); + LOG.trace("Inside getDhcpPktIn ethPkt {}", ethPkt); if (ethPkt.getEtherType() == (short)NwConstants.ETHTYPE_802_1Q) { ethPkt = (Ethernet)ethPkt.getPayload(); } @@ -197,7 +197,8 @@ public class DhcpPktHandler implements AutoCloseable, PacketProcessingListener { try { reply.deserialize(rawDhcpPayload, 0, rawDhcpPayload.length); } catch (PacketException e) { - LOG.warn("Failed to deserialize DHCP pkt {}", e); + LOG.warn("Failed to deserialize DHCP pkt"); + LOG.trace("Reason for failure {}", e); return null; } return reply; diff --git a/interfacemgr/interfacemgr-impl/src/main/java/org/opendaylight/vpnservice/interfacemgr/servicebindings/flowbased/confighelpers/FlowBasedServicesConfigUnbindHelper.java b/interfacemgr/interfacemgr-impl/src/main/java/org/opendaylight/vpnservice/interfacemgr/servicebindings/flowbased/confighelpers/FlowBasedServicesConfigUnbindHelper.java index 25b93c24..25323e90 100644 --- a/interfacemgr/interfacemgr-impl/src/main/java/org/opendaylight/vpnservice/interfacemgr/servicebindings/flowbased/confighelpers/FlowBasedServicesConfigUnbindHelper.java +++ b/interfacemgr/interfacemgr-impl/src/main/java/org/opendaylight/vpnservice/interfacemgr/servicebindings/flowbased/confighelpers/FlowBasedServicesConfigUnbindHelper.java @@ -56,8 +56,7 @@ public class FlowBasedServicesConfigUnbindHelper { org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.state.Interface ifState = InterfaceManagerCommonUtils.getInterfaceStateFromOperDS(interfaceName, dataBroker); if (ifState == null || ifState.getOperStatus() == OperStatus.Down) { - LOG.info("Not unbinding Service since operstatus is {} for Interface: {}", - ifState.getOperStatus(), interfaceName); + LOG.info("Not unbinding Service since operstatus is DOWN for Interface: {}", interfaceName); return futures; } List boundServices = servicesInfo.getBoundServices(); -- 2.36.6