From f86d7eccccd5e50eb9e67a1a7e0455849a502565 Mon Sep 17 00:00:00 2001 From: Susmitha Date: Fri, 20 Mar 2020 13:10:43 -0400 Subject: [PATCH] Calculate spanloss crashes when OTS is not present -OTS interface check is added to avoid the crash JIRA: TRNSPRTPCE-172 Change-Id: Ic8fa52eaf98069d7fe581d2c9b2a9f75cbf0fadd --- .../transportpce/olm/service/OlmPowerServiceImpl.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/olm/src/main/java/org/opendaylight/transportpce/olm/service/OlmPowerServiceImpl.java b/olm/src/main/java/org/opendaylight/transportpce/olm/service/OlmPowerServiceImpl.java index 15a37d94e..0dcf6f148 100644 --- a/olm/src/main/java/org/opendaylight/transportpce/olm/service/OlmPowerServiceImpl.java +++ b/olm/src/main/java/org/opendaylight/transportpce/olm/service/OlmPowerServiceImpl.java @@ -523,6 +523,10 @@ public class OlmPowerServiceImpl implements OlmPowerService { String destTpId = link.getDestTpid(); OtsPmHolder srcOtsPmHoler = getPmMeasurements(sourceNodeId, sourceTpId, "OpticalPowerOutput"); OtsPmHolder destOtsPmHoler = getPmMeasurements(destNodeId, destTpId, "OpticalPowerInput"); + if (srcOtsPmHoler.getOtsInterfaceName() == null || destOtsPmHoler.getOtsInterfaceName() == null) { + LOG.warn("OTS is not present for the link {}", link); + continue; + } spanLoss = new BigDecimal(srcOtsPmHoler.getOtsParameterVal() - destOtsPmHoler.getOtsParameterVal()) .setScale(0, RoundingMode.HALF_UP); LOG.info("Spanloss Calculated as :{}={}-{}", -- 2.36.6