From fd84afd8245bd2459b0dc84033b5caa3947989c8 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Thu, 6 Feb 2020 18:07:53 +0100 Subject: [PATCH] Fix DataNodeContainerMixin.getChildNodes() Since our implementation relies hashCode()/equals(), we really want to make sure same-source comparison ends up being equal, hence we collect to a list (which is faster than a set). This is okay, as all equality checks sit behind an implementation instanceof. JIRA: YANGTOOLS-1065 Change-Id: I521a8a7cfc2af012928da55708a0a519dae85095 Signed-off-by: Robert Varga --- .../yang/parser/rfc7950/stmt/EffectiveStatementMixins.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/EffectiveStatementMixins.java b/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/EffectiveStatementMixins.java index 4d1045d0fe..c2b82e7f7d 100644 --- a/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/EffectiveStatementMixins.java +++ b/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/EffectiveStatementMixins.java @@ -179,7 +179,8 @@ public final class EffectiveStatementMixins { @Override default Collection getChildNodes() { - return filterEffectiveStatements(DataSchemaNode.class); + // Note: two invocations must end up being equal + return filterEffectiveStatementsList(DataSchemaNode.class); } @Override -- 2.36.6