From 10a7971e7547543096f4d540270d1211fe5d2104 Mon Sep 17 00:00:00 2001 From: Daniel Farrell Date: Fri, 14 Dec 2018 12:29:50 -0500 Subject: [PATCH] Disable fail-on-errors during RVM source Recent changes to RVM have introduced a non-zero exit in the source command that makes functions available. This causes our jobs to fail, since we run with fail-on-errors. Turn off fail-on-errors during that step and enable right after. Change-Id: Idd5f550639c714219d51395113f2089bc07682a2 Signed-off-by: Daniel Farrell --- jjb/packaging/test-puppet.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/jjb/packaging/test-puppet.sh b/jjb/packaging/test-puppet.sh index 39b753a87..d460e451e 100644 --- a/jjb/packaging/test-puppet.sh +++ b/jjb/packaging/test-puppet.sh @@ -22,8 +22,12 @@ curl -L get.rvm.io | bash -s stable # Expected by RVM, seems required to make RVM functions (`rvm use`) available # Silence absurdly verbose rvm output by temporally not echoing commands set +x +# Source line has a non-zero exit somewhere, that RVM doesn't mean to indicate +# a real failure, but causes our jobs to fail when fail-on-errors is enabled. +set +e # shellcheck disable=SC1090 source "$HOME/.rvm/scripts/rvm" +set -e rvm install 2.4.0 set -x ruby --version -- 2.36.6