From 2f4bb2f22fd6d1a9292a1983ac513774172a7f4c Mon Sep 17 00:00:00 2001
From: "guillaume.lambert" <guillaume.lambert@orange.com>
Date: Tue, 5 May 2020 16:18:04 +0200
Subject: [PATCH] Enforce SpotBugs in inventory build process

by annotating remaining warnings with a @SuppressFBwarnings decorator

JIRA: TRNSPRTPCE-207 TRNSPRTPCE-241 TRNSPRTPCE-265 TRNSPRTPCE-272
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iabd129118abf6c47f97bd63e83363c462f776456
---
 inventory/pom.xml                                           | 6 ------
 .../java/org/opendaylight/transportpce/inventory/INode.java | 3 +++
 .../org/opendaylight/transportpce/inventory/INode121.java   | 3 +++
 .../org/opendaylight/transportpce/inventory/INode221.java   | 4 +++-
 4 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/inventory/pom.xml b/inventory/pom.xml
index 5fa07070d..0a4dcb3e8 100644
--- a/inventory/pom.xml
+++ b/inventory/pom.xml
@@ -27,10 +27,4 @@
       </dependency>
     </dependencies>
 
-<!-- checkstyle and spotbugds enforced by odlparent since Magnesium -->
-  <properties>
-    <!-- odlparent.checkstyle.enforce>false</odlparent.checkstyle.enforce -->
-    <odlparent.spotbugs.enforce>false</odlparent.spotbugs.enforce>
-  </properties>
-
 </project>
diff --git a/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode.java b/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode.java
index 2d8bdd56c..cdcfc621e 100644
--- a/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode.java
+++ b/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode.java
@@ -17,6 +17,9 @@ import org.opendaylight.transportpce.common.device.DeviceTransactionManager;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+@edu.umd.cs.findbugs.annotations.SuppressFBWarnings(
+    value = "SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING",
+    justification = "TODO review the SQL statement generation process")
 public class INode {
     private static final Logger LOG = LoggerFactory.getLogger(INode.class);
 
diff --git a/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode121.java b/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode121.java
index 5fd8b089c..04e408cf4 100644
--- a/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode121.java
+++ b/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode121.java
@@ -58,6 +58,9 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+@edu.umd.cs.findbugs.annotations.SuppressFBWarnings(
+    value = "SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING",
+    justification = "TODO review the SQL statement generation process")
 public class INode121 {
 
     private static final Logger LOG = LoggerFactory.getLogger(INode121.class);
diff --git a/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode221.java b/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode221.java
index 2aff959d8..220338415 100644
--- a/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode221.java
+++ b/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode221.java
@@ -55,7 +55,9 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-
+@edu.umd.cs.findbugs.annotations.SuppressFBWarnings(
+    value = "SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING",
+    justification = "TODO review the SQL statement generation process")
 public class INode221 {
     private static final Logger LOG = LoggerFactory.getLogger(INode221.class);
 
-- 
2.36.6