From a9ef0268c64fa25f5c1047361a1421a3ef4619a5 Mon Sep 17 00:00:00 2001
From: Stephen Kitt <skitt@redhat.com>
Date: Thu, 9 Jun 2016 16:38:51 +0200
Subject: [PATCH] Update plugin property info

checkstyle.runtime.version, gmaven.plugin.version,
jar.plugin.version, and maven.release.version aren't used outside
odlparent, remove them.

Change-Id: Ic492b2f8ac01736c32485503c5418381423a650a
Signed-off-by: Stephen Kitt <skitt@redhat.com>
---
 odlparent/pom.xml | 43 ++++++++++++++++++++++++++++++++-----------
 1 file changed, 32 insertions(+), 11 deletions(-)

diff --git a/odlparent/pom.xml b/odlparent/pom.xml
index e35991c2d..a3970ec00 100644
--- a/odlparent/pom.xml
+++ b/odlparent/pom.xml
@@ -48,30 +48,46 @@
     <java.version.target>${maven.compiler.target}</java.version.target>
 
     <!-- Maven plugin versions, in the 'canonical' format -->
+    <!-- Used in controller -->
     <maven.antrun.plugin.version>1.8</maven.antrun.plugin.version>
+    <!-- Used in controller, didm, neutron, openflowplugin, persistence; see also affinity -->
     <maven.bundle.version>3.0.0</maven.bundle.version>
+    <!-- Used in sxp -->
     <maven.clean.plugin.version>2.6.1</maven.clean.plugin.version>
+    <!-- Used in controller, didm, l2switch, lacp, persistence; see also toolkit, tsdr, ttp -->
     <maven.compile.plugin.version>3.3</maven.compile.plugin.version>
+    <!-- Used in mdsal, yangtools -->
     <maven.jar.version>2.6</maven.jar.version>
+    <!-- Used in controller, coretutorials, mdsal, snbi, tcpmd5, yangtools -->
     <maven.javadoc.version>2.10.3</maven.javadoc.version>
+    <!-- Used in snmp -->
     <maven.plugin.version>3.4</maven.plugin.version>
-    <maven.release.version>2.5.2</maven.release.version>
+    <!-- Used in neutron, of-config, tcpmd5, tsdr, yangtools -->
+    <!-- Later versions break tests in downstream projects -->
     <maven.surefire.version>2.18.1</maven.surefire.version>
 
     <!-- Maven plugin versions, in random formats -->
+    <!-- Used in aaa, alto, controller, didm, tsdr; see also affinity, snmp4sdn, toolkit, ttp -->
     <bundle.plugin.version>${maven.bundle.version}</bundle.plugin.version>
-    <checkstyle.runtime.version>6.16</checkstyle.runtime.version>
     <!-- TODO rename checkstyle.version to checkstyle.(maven.)plugin.version,
          or just remove it, incl. all usages of it in a number of pom.xml; because normally,
          as maven-checkstyle-plugin is in pluginManagement, this should not have to be repeated. -->
+    <!-- Used in alto, controller, lacp, netide, openflowjava, packetcable, snmp4sdn, ttp; see also affinity, opendove,
+         toolkit -->
     <checkstyle.version>2.17</checkstyle.version>
+    <!-- Used in controller, packetcable -->
     <odl.checkstyle.version>0.2.0-SNAPSHOT</odl.checkstyle.version>
+    <!-- Used in snmp4sdn; see also toolkit -->
     <compiler.version>${maven.compile.plugin.version}</compiler.version>
+    <!-- Used in controller, l2switch, netide, openflowjava, openflowplugin, snbi, tsdr, ttp; see also toolkit -->
     <enforcer.version>1.4.1</enforcer.version>
-    <enunciate.version>1.31</enunciate.version> <!-- Needs to remain exported, as its used for dependencies, too -->
-    <exam.version>4.4.0</exam.version> <!-- Needs to remain exported, as its used for dependencies, too -->
+    <!-- Used in affinity, controller, nemo, opendove, snmp4sdn -->
+    <enunciate.version>1.31</enunciate.version>
+    <!-- Used in affinity, coretutorials, netide -->
+    <exam.version>4.4.0</exam.version>
+    <!-- Used in affinity, controller, neutron, of-config; see also snmp4sdn -->
+    <!-- Later versions break tests in downstream projects -->
     <failsafe.version>2.18.1</failsafe.version>
-    <gmaven.plugin.version>1.0</gmaven.plugin.version>
     <!--
         Regression in jacoco-plugin 0.7.5 prevents us from upgrading to it
         http://jira.xwiki.org/browse/XCOMMONS-821
@@ -81,14 +97,17 @@
         that use PowerMock.
         https://github.com/jayway/powermock/issues/564
     -->
+    <!-- Used in controller, netvirt, neutron, of-config, ovsdb, persistence, snmp4sdn, vtn; see also usc -->
     <jacoco.version>0.7.2.201409121644</jacoco.version>
-    <jar.plugin.version>${maven.jar.version}</jar.plugin.version>
     <!-- Used in aaa, controller, coretutorials, integration/distribution, l2switch, lacp, lispflowmapping, netide,
          nic, openflowplugin, ovsdb, persistence, sfc, snbi, snmp4sdn?, sxp, topoprocessing, unimgr, vtn -->
     <karaf.version>3.0.6</karaf.version>
+    <!-- Used in lispflowmapping, snmp4sdn, vtn -->
     <projectinfo>2.8.1</projectinfo>
+    <!-- Used in of-config; see also snmp4sdn -->
     <propertymavenplugin.version>1.0-alpha-2</propertymavenplugin.version>
-    <releaseplugin.version>${maven.release.version}</releaseplugin.version>
+    <!-- Used in topoprocessing; see also defense4all, snmp4sdn, toolkit -->
+    <releaseplugin.version>2.5.2</releaseplugin.version>
 
     <!-- Supporting Libraries -->
     <!-- Used by controller -->
@@ -130,7 +149,8 @@
       <dependency>
         <groupId>com.puppycrawl.tools</groupId>
         <artifactId>checkstyle</artifactId>
-        <version>${checkstyle.runtime.version}</version>
+        <!-- This should match the plugin management on maven-checkstyle-plugin below -->
+        <version>6.16</version>
       </dependency>
 
       <!-- Testing Dependencies -->
@@ -1117,7 +1137,8 @@
             <dependency>
               <groupId>com.puppycrawl.tools</groupId>
               <artifactId>checkstyle</artifactId>
-              <version>${checkstyle.runtime.version}</version>
+              <!-- This should match the dependency management on com.puppycrawl.tools:checkstyle above -->
+              <version>6.16</version>
             </dependency>
             <dependency>
               <groupId>org.opendaylight.odlparent</groupId>
@@ -1199,7 +1220,7 @@
         </plugin>
         <plugin>
           <artifactId>maven-release-plugin</artifactId>
-          <version>${maven.release.version}</version>
+          <version>${releaseplugin.version}</version>
         </plugin>
         <plugin>
           <artifactId>maven-dependency-plugin</artifactId>
@@ -1303,7 +1324,7 @@
         <plugin>
           <groupId>org.codehaus.groovy.maven</groupId>
           <artifactId>gmaven-plugin</artifactId>
-          <version>${gmaven.plugin.version}</version>
+          <version>1.0</version>
         </plugin>
         <plugin>
           <groupId>org.codehaus.mojo</groupId>
-- 
2.36.6