From 881fb9e1db92bc3997138e164e899041b62013d1 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Sat, 6 Jun 2015 15:57:12 +0200 Subject: [PATCH] Fix inefficient String buffering Instead of using string concatenation before adding to stribuilder, add the componets directly. Change-Id: Ibbd9131f1a1ec5df5f32c84e86c140e52c5ec84d Signed-off-by: Robert Varga --- .../yangtools/yang/data/impl/leafref/LeafRefPath.java | 4 ++-- .../yang/data/impl/leafref/QNamePredicateBuilder.java | 6 +++--- .../yang/data/impl/leafref/QNamePredicateImpl.java | 6 +++--- .../yang/data/impl/leafref/QNameWithPredicateBuilder.java | 6 +++--- .../yang/data/impl/leafref/QNameWithPredicateImpl.java | 6 +++--- 5 files changed, 14 insertions(+), 14 deletions(-) diff --git a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/LeafRefPath.java b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/LeafRefPath.java index 649d911ac3..8f092dfebd 100644 --- a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/LeafRefPath.java +++ b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/LeafRefPath.java @@ -7,7 +7,6 @@ */ package org.opendaylight.yangtools.yang.data.impl.leafref; -import org.opendaylight.yangtools.concepts.Immutable; import com.google.common.base.Preconditions; import com.google.common.collect.ImmutableList; import com.google.common.collect.Iterables; @@ -16,6 +15,7 @@ import java.util.Iterator; import java.util.List; import java.util.NoSuchElementException; import java.util.concurrent.atomic.AtomicReferenceFieldUpdater; +import org.opendaylight.yangtools.concepts.Immutable; public abstract class LeafRefPath implements Immutable { @@ -354,7 +354,7 @@ public abstract class LeafRefPath implements Immutable { sb.append(isAbsolute() ? "Absolute path:" : "Relative path:"); for (QNameWithPredicate qName : pathFromRoot) { - sb.append("/" + qName); + sb.append('/').append(qName); } return sb.toString(); diff --git a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNamePredicateBuilder.java b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNamePredicateBuilder.java index 0cdb9dd662..778a851d72 100644 --- a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNamePredicateBuilder.java +++ b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNamePredicateBuilder.java @@ -45,7 +45,7 @@ class QNamePredicateBuilder { @Override public String toString() { final StringBuilder sb = new StringBuilder(); - sb.append("["); + sb.append('['); sb.append(identifier); sb.append("=current()"); @@ -54,10 +54,10 @@ class QNamePredicateBuilder { .getPathFromRoot(); for (final QNameWithPredicate qName : pathFromRoot) { - sb.append("/" + qName); + sb.append('/').append(qName); } - sb.append("]"); + sb.append(']'); return sb.toString(); } } diff --git a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNamePredicateImpl.java b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNamePredicateImpl.java index 6607475ace..4bfb861f2b 100644 --- a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNamePredicateImpl.java +++ b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNamePredicateImpl.java @@ -37,7 +37,7 @@ class QNamePredicateImpl implements Immutable, Serializable, @Override public String toString() { final StringBuilder sb = new StringBuilder(); - sb.append("["); + sb.append('['); sb.append(identifier); sb.append("=current()"); @@ -46,10 +46,10 @@ class QNamePredicateImpl implements Immutable, Serializable, .getPathFromRoot(); for (final QNameWithPredicate qName : pathFromRoot) { - sb.append("/" + qName); + sb.append('/').append(qName); } - sb.append("]"); + sb.append(']'); return sb.toString(); } diff --git a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNameWithPredicateBuilder.java b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNameWithPredicateBuilder.java index 0fe0d443e1..b1b0666548 100644 --- a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNameWithPredicateBuilder.java +++ b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNameWithPredicateBuilder.java @@ -89,9 +89,9 @@ class QNameWithPredicateBuilder { final StringBuilder sb = new StringBuilder(); if (moduleQname != null) { - sb.append("(" + moduleQname.getNamespace()); - sb.append("?revision=" + moduleQname.getRevision()); - sb.append(")"); + sb.append('(').append(moduleQname.getNamespace()); + sb.append("?revision=").append(moduleQname.getRevision()); + sb.append(')'); } sb.append(localName); diff --git a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNameWithPredicateImpl.java b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNameWithPredicateImpl.java index 757e349090..5b14433266 100644 --- a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNameWithPredicateImpl.java +++ b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/leafref/QNameWithPredicateImpl.java @@ -74,9 +74,9 @@ final class QNameWithPredicateImpl implements Immutable, Serializable, final StringBuilder sb = new StringBuilder(); if (moduleQname != null) { - sb.append("(" + moduleQname.getNamespace()); - sb.append("?revision=" + moduleQname.getRevision()); - sb.append(")"); + sb.append('(').append(moduleQname.getNamespace()); + sb.append("?revision=").append(moduleQname.getRevision()); + sb.append(')'); } sb.append(localName); -- 2.36.6